14f012be75
## Mirror of PR #26009: [Fixed bug with appearance of ammo battery magazine guns](https://github.com/space-wizards/space-station-14/pull/26009) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `63232389ca9a499fb614960ccf9eae9b3d186037` PR opened by <img src="https://avatars.githubusercontent.com/u/33431126?v=4" width="16"/><a href="https://github.com/778b"> 778b</a> at 2024-03-11 18:34:37 UTC --- PR changed 1 files with 9 additions and 0 deletions. The PR had the following labels: --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Fix bug with guns which used MagazineAmmoProviderComponent with Battery magazines like svalinn laser pistol. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Bugfix, no balance here > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > Just added subscribe for AmmoCounterControlEvent which using AmmoCounterComponent because battery magazines must redefine control in this event to display ammo, now its work well. > Also checked some other guns which using MagazineAmmoProviderComponent and they work like always, without new bugs > > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > Before: >  > > After: > https://github.com/space-wizards/space-station-14/assets/33431126/d4aa3c99-7e89-44d7-9030-1fa2a3db13ab > > > > - [x] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > 🆑 778b > > - fix: Guns which use battery as magazines now display ammo. Like Svalinn pistol. > > </details> Co-authored-by: SimpleStation14 <Unknown>
Einstein Engines
Einstein Engines is a hard fork of Space Station 14 built around the ideals and design inspirations of the Baystation family of servers from Space Station 13 with a focus on having modular code that anyone can use to make the RP server of their dreams. Our founding organization is based on a democratic system whereby our mutual contributors and downstreams have a say in what code goes into their own upstream. If you are a representative of a former downstream of Delta-V, we would like to invite you to contact us for an opportunity to represent your fork in this new upstream.
Space Station 14 is inspired heavily by Space Station 13 and runs on Robust Toolbox, a homegrown engine written in C#.
As a hard fork, any code sourced from a different upstream cannot ever be merged directly here, and must instead be ported. All code present in this repository is subject to change as desired by the council of maintainers.
Official Server Policy
No official servers will ever be made for Einstein-Engines.
In order to prevent a potential conflict of interest, we will never open any server directly using the Einstein Engines codebase itself. Any server claiming to be an official representation of this fork is not endorsed in any way by this organization. We however would like to invite anyone wishing to create a server to make a fork of Einstein Engines.
Links
Website | Discord | Steam(SSMV Launcher) | Steam(WizDen Launcher) | Standalone
Contributing
We are happy to accept contributions from anybody, come join our Discord if you want to help. We've got a list of issues that need to be done and anybody can pick them up. Don't be afraid to ask for help in Discord either!
We are currently accepting translations of the game on our main repository. If you would like to translate the game into another language check the #contributor-general channel in our Discord.
Building
Refer to the Space Wizards' guide on setting up a development environment for general information, but keep in mind that Einstein Engines is not the same and many things may not apply. We provide some scripts shown below to make the job easier.
Build dependencies
- Git
- DOTNET SDK 7.0 or higher
- python 3.7 or higher
Windows
- Clone this repository
- Run
RUN_THIS.pyto init submodules and download the engine, or rungit submodule update --init --recursivein a terminal- Run the
Scripts/bat/run1buildDebug.bat- Run the
Scripts/bat/run2configDev.batif you need other configurations run other config scripts- Run both the
Scripts/bat/run3server.batandScripts/bat/run4client.bat- Connect to localhost and play
Linux
- Clone this repository
- Run
RUN_THIS.pyto init submodules and download the engine, or rungit submodule update --init --recursivein a terminal- Run the
Scripts/sh/run1buildDebug.sh- Run the
Scripts/sh/run2configDev.shif you need other configurations run other config scripts- Run both the
Scripts/sh/run3server.batandscripts/sh/run4client.sh- Connect to localhost and play
MacOS
I don't know anybody using MacOS to test this, but it's probably roughly the same steps as Linux
License
Content contributed to this repository after commit 87c70a89a6 (17 February 2024 23:00:00 UTC) is licensed under the GNU Affero General Public License version 3.0 unless otherwise stated.
See LICENSE-AGPLv3.
Content contributed to this repository before commit 87c70a89a6 (17 February 2024 23:00:00 UTC) is licensed under the MIT license unless otherwise stated.
See LICENSE-MIT.
Most assets are licensed under CC-BY-SA 3.0 unless stated otherwise. Assets have their license and the copyright in the metadata file. Example.
Note that some assets are licensed under the non-commercial CC-BY-NC-SA 3.0 or similar non-commercial licenses and will need to be removed if you wish to use this project commercially.