SimpleStation14
825ca8772d
Mirror: Trading Outpost now has half buy-only and half sell-only pallets ( #191 )
...
## Mirror of PR #25955 : [Trading Outpost now has half buy-only and half
sell-only
pallets](https://github.com/space-wizards/space-station-14/pull/25955 )
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4 "
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards )/[space-station-14](https://github.com/space-wizards/space-station-14 )
###### `c0bbbc33c19eafcc8defaa7f1ec2df42e485b435`
PR opened by <img
src="https://avatars.githubusercontent.com/u/1471082?v=4 " width="16"/><a
href="https://github.com/wafehling "> wafehling</a> at 2024-03-10
02:47:02 UTC
---
PR changed 8 files with 226 additions and 123 deletions.
The PR had the following labels:
- Changes: Sprites
- Status: Needs Review
---
<details open="true"><summary><h1>Original Body</h1></summary>
> ## About the PR
> I added two new entity types, a buy and sell only cargo pallet, and
added them to the trading outpost in place of the old pallets.
>
> ## Why / Balance
> Since the day this was added, every single shift, at some point I'll
hear someone in cargo yelling about how **"You sold stuff I just
bought!"**
>
> This seemed like the easiest way to fix the problem.
>
> ## Technical details
> Added a variable to the cargo pallet component for labeling which type
it is, added two new varieties of the cargo pallet to the yml, and
adjusted all the calls for GetCargoPallets() to have boolean variables
for buyOnly and sellOnly to tell the function what kind of call you're
looking for.
>
> If you don't give it any specifics it'll still treat any pallet as a
two-way one, but this function is only called 2 or 3 times and I've
adjusted them all and commented the function itself for anyone looking
to change/add it in the future.
>
> The old pallet is still in the game and is set to "both" by default,
so it should work just fine for backwards compatibility.
>
> ## Media
>
>
>
>
>
>
>
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
>
> Shouldn't break anything, I've left the old pallets fully in, and
updated them to work with the new GetCargoPallets() function just like
they used to. Not sure if/where you'd still need them, but better safe
than sorry.
>
> **Changelog**
> 🆑
> - tweak: The trading outpost now has dedicated buy-only and sell-only
pallets. No more accidentally selling orders you just bought. Cargonians
rejoice!
>
</details>
Co-authored-by: SimpleStation14 <Unknown>
2024-06-16 11:39:17 -04:00
Flesh
44613e6544
Made ordering multiple crates at cargo order multiple crates ( #25518 )
...
* please tell me this is empty
* it wasn't empty, fixing that
* This should fix it
* fix for the fix
* address changes
* fix
* Added some comments, hoping that failed test was a fluke.
(cherry picked from commit aa4e7c061939fbe314be97a2e7f559477b941c07)
2024-03-08 12:54:53 +01:00
themias
554f664994
Fix centcom cargo gifts ( #24701 )
...
(cherry picked from commit 3933490962993e839c71efea46c3e799ac824778)
2024-03-08 12:54:52 +01:00
metalgearsloth
fa3e17de86
Clear cargo orders on approval ( #24278 )
...
(cherry picked from commit f82fd23f2c87b7cab852bdc2563cfa30c2d2a6dd)
2024-03-08 12:54:51 +01:00
Debug
76d06416ab
Modify trade station for Delta
2024-03-08 12:54:50 +01:00
metalgearsloth
fa61952f51
Add trade stations ( #23863 )
2024-03-08 09:52:50 +01:00
Nemanja
47d24fc3e5
Fix cargo product groups ( #24212 )
...
(cherry picked from commit 21e77dffb00d631ea0e6a5c0ad55bed5dcbaa809)
2024-01-26 23:13:54 +01:00
metalgearsloth
b51b6f65b5
Add ability to put spesos into cargo console ( #24263 )
...
I thought we had it already but maybe it was an unfinished pr or something.
(cherry picked from commit ad23facb7a9670bcc10e2f9e89d2e22db2052697)
2024-01-26 23:08:06 +01:00
Leon Friedrich
e66c0b5035
Un-revert IPlayerManager refactor ( #21244 )
2023-10-31 19:00:44 +01:00
DrSmugleaf
9cc8a7fc81
Remove 700 usages of Component.Owner ( #21100 )
2023-10-20 15:31:13 +02:00
metalgearsloth
c9648da984
Content update for NetEntities ( #18935 )
2023-09-27 21:59:12 +02:00
Leon Friedrich
9c2af43af6
Deduplicate & fix prediction reconciliation test ( #18635 )
2023-08-04 12:21:44 +10:00
metalgearsloth
68b56878bc
Cargo selling fixes ( #17876 )
...
- Prevent selling dead mobs (getting used as easy corpse disposal).
- Fix a broadcast event being raised O(n) times instead of O(1)
2023-07-09 13:24:48 -06:00
TemporalOroboros
3ac4cf85db
Cleaner BoundUserInterfaces ( #17736 )
2023-07-09 02:02:17 +10:00
deltanedas
b9f24b2681
expedition rewards ( #16972 )
...
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com >
2023-06-16 15:19:02 +10:00
Tom Leys
db81e59013
NanoTrasen might send Gifts to the station via Cargo ( #16556 )
...
* Rebase Cargo Gifts
* Remove Chaos values from gifts (for now)
* Translate CargoGifts, rename fields
* Fix gift errors, detect missing products
* Fix order Id, some crate IDs
* Fix get Station. Gifts for Sec, Med, Fire, spacing
* Minimum players for various gifts
# Conflicts:
# Resources/Prototypes/GameRules/cargo_gifts.yml
2023-05-22 15:55:27 -06:00
Julian Giebel
6ebd784cb6
Device Linking and better linking ui ( #13645 )
...
Co-authored-by: AJCM-git <60196617+AJCM-git@users.noreply.github.com >
Co-authored-by: Visne <39844191+Visne@users.noreply.github.com >
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com >
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com >
2023-05-07 16:07:24 +10:00
metalgearsloth
b65bfd1fcf
Don't sell non-dead mobs on cargo ( #15228 )
2023-04-09 11:59:41 +10:00
metalgearsloth
569f30b721
Cargo shuttle changes ( #14363 )
2023-03-23 16:10:49 +11:00
eoineoineoin
6722adcd83
Cleanup cargo shuttle/telepad order code ( #13591 )
...
Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es >
2023-03-05 15:27:30 +11:00
eoineoineoin
cd10d6fb5e
Minor changes to display of cargo order manifests ( #12618 )
...
Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es >
2023-01-14 21:49:00 -04:00
Checkraze
66a01ccbf2
cargo system cleanup ( #13396 )
2023-01-10 20:55:59 +11:00
Leon Friedrich
881a2b2ece
PopupSystem public methods rejig ( #12830 )
2022-12-19 08:41:47 +11:00
Chief-Engineer
eb18363bd2
Add multiple logs ( #12857 )
2022-12-15 19:33:27 +01:00
Marat Gadzhiev
d610f2a56c
Order manifests for shuttle orders. Now with item names and approver info. ( #9464 )
...
Co-authored-by: Kara <lunarautomaton6@gmail.com >
2022-07-09 06:48:57 -07:00
metalgearsloth
77a8e16104
Add cargo shuttle ( #8686 )
2022-06-23 14:36:47 +10:00
