<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->
# Description
<!--
Explain this PR in as much detail as applicable
Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->
Adds the inverse of lightweight drunk, which makes you less susceptible
to the effects of ethanol.
(more specifically, it halves the damage of alcohol and you need to
drink twice as much to feel the effects in the first place)
To make the change happen, `LightweightDrunk` component was reworked to:
- A) no longer change any drunk effects (including non-alcohol related
drunkness like bloodloss)
- B) instead multiply the effects of ethanol in your bloodstream
I chose this route in particular, because the other option of
multiplying the amount of ethanol gained from alcohols is nonsense.
---
# TODO
<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->
- [X] Add a `TryMetabolizeReagent` event to `MetabolizerSystem.cs` so a
`LightweightDrunkSystem.cs` can listen to the event and multiply the
effects of "Ethanol" specifically.
- [X] Add the Heavyweight Drunk trait
- ~~Fix a minor spelling mistake that caused the trait condition to not
show up~~
- [ ] Would we be able to name trait files after categories? I don't
want to put every positive trait in a file named 'skills.yml'
---
<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->
<details><summary><h1>Media</h1></summary>
<p>
</p>
</details>
---
# Changelog
<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->
🆑
- add: Added the Heavyweight Drunk trait, which doubles your alcoholism
potential.
---------
Signed-off-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
# Description
#525 Added foreigner traits, now during testing I revealed a few bugs.
This PR fixes them:
- The light version now correctly allows you to understand common (it
would not because I forgot to add [DataField])
- The translator now correctly starts with a high-capacity power cell
- Equipping the translator in a pocket slot no longer takes time
<details><summary><h1>Media</h1></summary><p>
</p></details>
# Changelog
🆑
- fix: Foreigner traits now work correctly.
# Description
Adds two negative traits, foreigner and its light version. Both of them
make you unable to speak galactic common and give you a translator that
lets you speak/understand GC, and also requires you to know one of the
non-GC languages your entity normally speaks in order to work. The
translator starts with a high-capacity power cell to compensate for the
usual scarcity of publicly accessible chargers on most stations.
The light version of the trait only makes you unable to speak GC. The
heavy version also makes you unable to understand others when they speak
it.
This PR also makes you able to wear translator in the neck slot for
convenience and transparency, and rewamps the examination menu of
translators to provide more useful info.
One little known issue (as seen in the screenshots below) is that, since
the system chooses the first language in the list of languages your
entity can speak, it can sometimes pick wrong if your species speaks
more than two language, but it won't prevent you from using the
translator normally.
Also, the name of the light version of the trait is subject to change. I
just couldn't think of anything more creative for it.
# Why
Although supposedly trystan or others have a language menu in mind, it's
still not even being worked on yet. At the same time, I've already seen
some people roleplay as though their characters do not speak galactic
common.
<details><summary><h1>Media</h1></summary>
<p>
</p>
</details>
---
# Changelog
🆑
- add: Added two new foreigner traits that make your character unable to
speak Galactic Common and give you a translator instead.
- tweak: Translators can now be equipped in the neck slot and display
useful info when examined.
## Mirror of PR #26263: [Add
stealthmins](https://github.com/space-wizards/space-station-14/pull/26263)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `dca0c6694bce56fcf962feab2b59ad4a849f4533`
PR opened by <img
src="https://avatars.githubusercontent.com/u/32041239?v=4"
width="16"/><a href="https://github.com/nikthechampiongr">
nikthechampiongr</a> at 2024-03-19 16:14:22 UTC
---
PR changed 11 files with 197 additions and 10 deletions.
The PR had the following labels:
- Status: Needs Review
---
<details open="true"><summary><h1>Original Body</h1></summary>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> resolve#26013
>
> ## About the PR
> <!-- What did you change in this PR? -->
> This pr implements stealthmins as laid out in issue #26013.
>
> There is now the Stealth permission flag. This allows admins to use
the stealthmin command and to see other stealthmins.
>
> When stealthmin is toggled, the admin will not show up in adminwho
except for other admins with the Stealth permission.
>
> The stealthmin command sends fake de-admin/re-admin messages to admins
without the Stealth flag.
>
> stealthmin persists in the same way deadmin does(it persists for the
lifetime of the server).
>
> Admin login/logout messages are suppressed for stealthmins except for
other admins with the Stealth flag.
>
> It is still possible possible to find stealthed admins using toolshed
commands or logs. This is in line with the requirements of the issue,
and I don't want to start clobbering functionality of logs and toolshed.
>
> ## Why / Balance
>
> See #26013
>
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
>
> Stealth flag now exist for AdminFlags.
>
> An admin's stealth status is saved in their admin registration and in
ContentData.
>
> SendAdminAnnouncement now takes a whitelist flag and blacklist flag
(This will work with multiple flags). This is necessary to suppress
admin announcements where necessary. Blacklist takes priority over
whitelist.
>
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
>
https://github.com/space-wizards/space-station-14/assets/32041239/98ec48c3-170e-406a-b177-07003ff7d59f
>
>
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
>
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
>
> 🆑
> ADMIN:
> - add: The stealthmin command has been added. Admins with the Stealth
permission can now hide themselves from adminwho except for other admins
with that permission.
</details>
---------
Signed-off-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
## Mirror of PR #26421: [Nerf ninja research
stealing](https://github.com/space-wizards/space-station-14/pull/26421)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `3b9c5d43ec97a0693ced0118fcfcb8467aa5595e`
PR opened by <img
src="https://avatars.githubusercontent.com/u/98561806?v=4"
width="16"/><a href="https://github.com/EmoGarbage404">
EmoGarbage404</a> at 2024-03-25 01:44:21 UTC - merged at 2024-03-26
00:52:27 UTC
---
PR changed 4 files with 75 additions and 8 deletions.
The PR had the following labels:
- Status: Needs Review
---
<details open="true"><summary><h1>Original Body</h1></summary>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> ## About the PR
> <!-- What did you change in this PR? -->
> Changes ninja gloves to steal a flat rate of techs instead of wiping
all of them.
> Additionally adjusts the objective to require 1 to 2 steals to reach
the target amount.
>
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> Ninja's stealing research was previously an extremely trivial and
annoying objective. For them, you can pretty easily break into the
server room and wait out the 20 second doafter. It's not super hard and
you're not exactly shooting off warning signs. At this very low cost,
science loses literally an hour+ of progress.
>
> This nerf changes it to only remove 4-8 random technologies, or only
about 20k to 40k points worth. This is still pretty crippling but not
awful. On top of that, they need to do it twice to hit the target
amounts of 9 to 12 techs stolen. This provides counterplay by actually
giving science a chance to see that all their research has vanished
before the ninja is already gone. It also makes it significantly harder
for ninja to obliterate everything science has done.
>
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
>
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
>
> 🆑
> - tweak: Ninjas no longer wipe all technologies when using their
gloves on a research server.
>
</details>
Co-authored-by: SimpleStation14 <Unknown>
## Mirror of PR #25908: [SS14-17313 Chatfactor: Chat Censorship
Systems](https://github.com/space-wizards/space-station-14/pull/25908)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `bf98a6a8bb2a57fb149459d6b053eaaf6abc8cd7`
PR opened by <img
src="https://avatars.githubusercontent.com/u/732532?v=4" width="16"/><a
href="https://github.com/FairlySadPanda"> FairlySadPanda</a> at
2024-03-07 12:13:16 UTC - merged at 2024-03-25 23:50:20 UTC
---
PR changed 4 files with 576 additions and 0 deletions.
The PR had the following labels:
- Status: Needs Review
---
<details open="true"><summary><h1>Original Body</h1></summary>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> ## About the PR
> Adds some systems to manage chat censorship:
>
> 1. No-op: does nothing
> 2. SimpleCensor: a regex-free censor with a variety of rules to use
> 3. RegexCensor: a censor that uses regex.
>
> This exposes a singleton backed by a builder pattern (ChatCensor) that
is set up, probably during the code init phase, and then globally
available for your censorship needs.
>
> ## Why / Balance
> Partial fulfilment of #17313
>
> ## Technical details
> CE wants regex, CE gets regex
>
> Otherwise SimpleCensor is designed to be usable by people who don't
want to faff with regex.
>
> This would be setup during server or client init, so would be driven
by Cvars.
>
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
> nope
> **Changelog**
> nope
</details>
Co-authored-by: SimpleStation14 <Unknown>
## Mirror of PR #26045: [Fix recycled containers deleting items inside
them](https://github.com/space-wizards/space-station-14/pull/26045) from
<img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `d7484ae9f57477a5ec5c575e3077aa94c0564db6`
PR opened by <img
src="https://avatars.githubusercontent.com/u/83650252?v=4"
width="16"/><a href="https://github.com/SlamBamActionman">
SlamBamActionman</a> at 2024-03-12 16:16:42 UTC
---
PR changed 2 files with 19 additions and 1 deletions.
The PR had the following labels:
- Status: Awaiting Changes
---
<details open="true"><summary><h1>Original Body</h1></summary>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> ## About the PR
> <!-- What did you change in this PR? -->
>
> Right now you can delete any item that fits in a survival box by
placing it inside of one and then recycling the box in a
Recycler/Material Reclaimer. This PR fixes this by dumping out any item
inside containers.
>
> - For Reclaimers, any recyclable items inside the container get placed
on top of the Reclaimer.
> - For Recyclers, any recyclable items inside the container get
recursively recycled as well.
>
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
>
> I doubt it's intended behavior to be able to effectively delete any
item that fits in a box. Also ensures a recycled box provides the
correct amount of material as its contents also get recycled.
>
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
>
> When trying to recycle, once all checks are passed it iterates through
the object's containers if it has any and dumps out any items onto the
machine doing the recycling.
>
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
> The result of recycling a survival box in a Recycler/Reclaimer.
>
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
>
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
>
> 🆑
> - fix: Recyclers no longer delete items stored inside of recycled
entities.
>
</details>
---------
Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
# Description
Adds traitors and hellshift to the list of gamemodes offered by the
gamemode vote.
Traitors just make sense.
Hellshift is a new version of survival. It starts out roughly as slow as
survival, but it slowly devolves into a torrent of station events as
frequent as one every 10-30 seconds. Good for when there's no other
~~self-antaggers~~ players to spice up the shift, or when there's one
too many security officers to deal with all the threats this brings.
# Technical details
Had to refactor a lot of RampingStationEventScheduler. Firstly, it was
total shitcode, secondly, it had everything hardcoded, thirdly, it had a
bug that made it possible for events to appear with little to no delay
whatsoever. Now its component features four data fields that can be used
to configure the scheduler and its system contains cleaner and more
readable code.
<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->
<details><summary><h1>Media</h1></summary>
<p>
</p>
</details>
# Changelog
🆑
- tweak: Players can now vote on two more gamemodes: Traitors and
Hellshift.
---------
Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
# Description
Cherry-picks
https://github.com/space-wizards/space-station-14/pull/27138
# Changelog
<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->
🆑 osjarw
- add: Wallmount substation electronics can now be created at an
autolathe.
Co-authored-by: osjarw <62134478+osjarw@users.noreply.github.com>
## Mirror of PR #26160: [Added 18 new bounties to
cargo](https://github.com/space-wizards/space-station-14/pull/26160)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `4357b9ef08fee0e08c4fdf4eeef714fa8eb38112`
PR opened by <img
src="https://avatars.githubusercontent.com/u/1471082?v=4" width="16"/><a
href="https://github.com/wafehling"> wafehling</a> at 2024-03-15
20:21:21 UTC
---
PR changed 19 files with 373 additions and 22 deletions.
The PR had the following labels:
---
<details open="true"><summary><h1>Original Body</h1></summary>
> ## About the PR
> I added 18 new bounties to cargo's bounty system, and tweaked a couple
values in the existing system. (6 bounties at once instead of 5, reduced
# of headsets needed for bounty to a sane number, fixed a couple
inconsistencies)
>
> ## Why / Balance
>
> Spice things up, add variety, add a bit of balance. For fun!
>
> ## Technical details
> Pretty much just Yaml/Ftl changes, added new bounty info + tags,
Tweaked the active bounty count.
>
> ## Media
>
>
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
> None! Nothing got removed, and it's all just surface level yaml work.
>
> **Changelog**
> 🆑
> - add: Added 18 new bounties to cargo bounty system.
>
>
</details>
---------
Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
## Mirror of PR #26312: [Fix puller being improperly unset when pulling
stops.](https://github.com/space-wizards/space-station-14/pull/26312)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `a6c018d755ee4f35fb8e3ab597fa90c7592fe920`
PR opened by <img
src="https://avatars.githubusercontent.com/u/32041239?v=4"
width="16"/><a href="https://github.com/nikthechampiongr">
nikthechampiongr</a> at 2024-03-21 15:07:50 UTC
---
PR changed 1 files with 8 additions and 6 deletions.
The PR had the following labels:
---
<details open="true"><summary><h1>Original Body</h1></summary>
> fixes#26310
>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> ## About the PR
> <!-- What did you change in this PR? -->
> This pr fixes the bug with people being unable to move while in cuffs
if they were previously pulled even if they were no longer being pulled.
>
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> A security cadet should not be able to merge my legs with the ground
by simply touching me while I'm in cuffs.
>
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
>
> When unpulled, the pullableComp has its puller field set to null after
the message signifying the pulling has stopped has been sent. Since the
component has a field to determine whether its owner is being pulled
which is determined by the puller field, systems listening on the event
would think that the owner of the component was still being pulled.
>
> As a result, when the message was fired and the SharedCuffableSystem
checked whether it should allow the cuffed person to move it thought
they were still being pulled and as such didn't allow them to move.
>
> I spent some time trying to determine whether setting the puller to
null earlier would have other negative effects, however to my
understanding of the code and the systems that listen to the message I
believe this is now the correct behavior. Still just in case
@metalgearsloth please check this out thanks.
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
>
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
>
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 🆑
> - fix: You can now move again if you stop being pulled while in cuffs.
</details>
Co-authored-by: nikthechampiongr <32041239+nikthechampiongr@users.noreply.github.com>
## Mirror of PR #25928: [Fix cream pie bomb when eaten or
sliced](https://github.com/space-wizards/space-station-14/pull/25928)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `0d0edbba4a1c2af7ecef3318b5f9fe287a63fab5`
PR opened by <img
src="https://avatars.githubusercontent.com/u/40753025?v=4"
width="16"/><a href="https://github.com/Slava0135"> Slava0135</a> at
2024-03-08 13:16:38 UTC
PR merged by <img
src="https://avatars.githubusercontent.com/u/19864447?v=4"
width="16"/><a href="https://github.com/web-flow"> web-flow</a> at
2024-03-13 08:36:08 UTC
---
PR changed 4 files with 22 additions and 4 deletions.
The PR had the following labels:
---
<details open="true"><summary><h1>Original Body</h1></summary>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> ## About the PR
> <!-- What did you change in this PR? -->
>
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
>
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
>
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
> 
>
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
>
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
>
> 🆑
> - fix: Fixed pie bomb not detonating when eaten or sliced (remember to
keep hungry mice away from it)!
> - tweak: Pie bomb now cannot be ejected or swapped (just hope there is
no bomb inside)
>
</details>
---------
Co-authored-by: Vyacheslav Kovalevsky <40753025+Slava0135@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
## Mirror of PR #26205: [fix decoy bomb uplink
category](https://github.com/space-wizards/space-station-14/pull/26205)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `21c527d6d09847a742202613d8aefce62c79b334`
PR opened by <img
src="https://avatars.githubusercontent.com/u/57039557?v=4"
width="16"/><a href="https://github.com/Ilya246"> Ilya246</a> at
2024-03-17 10:11:15 UTC
---
PR changed 1 files with 10 additions and 10 deletions.
The PR had the following labels:
- No C#
---
<details open="true"><summary><h1>Original Body</h1></summary>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> ## About the PR
> moves the decoy syndicate bomb from explosives category to deception
category
>
> ## Why / Balance
> PR was made before the uplink categories update so the bomb ended up
miscategorised
>
> ## Technical details
> this is a webedit but it should be sufficiently simple to be fine
>
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> not tested
>
> - [ ] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
</details>
---------
Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
## Mirror of PR #26309: [Fix scram! implant keeping you pulled to
someone when teleporting
you](https://github.com/space-wizards/space-station-14/pull/26309) from
<img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `eb80d9752e0309f8485478a43bcba6fb15fc3711`
PR opened by <img
src="https://avatars.githubusercontent.com/u/32041239?v=4"
width="16"/><a href="https://github.com/nikthechampiongr">
nikthechampiongr</a> at 2024-03-21 14:19:01 UTC
---
PR changed 1 files with 8 additions and 0 deletions.
The PR had the following labels:
---
<details open="true"><summary><h1>Original Body</h1></summary>
> fixes#26301
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> ## About the PR
> <!-- What did you change in this PR? -->
> The scram implant will no longer leave you pulled when teleporting
you.
>
>
> I know the entire teleporting system for it needs to be redone and I
might do that but please do not make me do it in this pr.
>
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> It allows your captor to pull you through time and space itself back
to where you were like nothing happened.
>
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> Scram! tries to unpull you before teleporting you.
>
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
>
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
>
> 🆑
> - fix: Scram! implant no longer allows for someone to keep pulling you
when it teleports you.
</details>
Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
## Mirror of PR #26162: [Door Remote now shows Mode in
UI](https://github.com/space-wizards/space-station-14/pull/26162) from
<img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `e627a0d24bc8ae89665feb0b0d519b5fbb77ce32`
PR opened by <img
src="https://avatars.githubusercontent.com/u/58439124?v=4"
width="16"/><a href="https://github.com/Plykiya"> Plykiya</a> at
2024-03-15 23:14:52 UTC
---
PR changed 7 files with 151 additions and 67 deletions.
The PR had the following labels:
- Status: Awaiting Changes
---
<details open="true"><summary><h1>Original Body</h1></summary>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> ## About the PR
> <!-- What did you change in this PR? -->
> Changed the door remote to show what mode it's in on the UI so you
don't have to toggle it to figure out if you're bolting a door or
setting it to emergency access...
>
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> There is no indicator and it's awkward to set a door to emergency
access instead of bolting it against nukies.
>
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> - Split DoorRemoteSystem into Shared/Server/Client from just Server
> - Added door remote status control that updates itself on first pickup
and then whenever the mode is toggled
> - Got rid of the custom "ShowPopupToUser" function that the DoorRemote
used to have in favor of PopupClient/PopupEntity
> - Created new Door Remote locale messages.
>
> The only problem I have with my code change is that I created a shitty
fourth placeholder enum so that I could check for a difference on
initial pickup with PrevOperatingMode. Without it, the mode string only
appears on pickup for 2/3 options instead of 3/3 options because the
default PrevOperatingMode would end up matching the current Mode the
door remote is set to, thus not updating the UI. Would love a better
implementation suggestion for that...
>
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
> - [ X ] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
>
https://github.com/space-wizards/space-station-14/assets/58439124/733eb78a-d1a6-4678-a325-9fda8dc1a4c8
>
>
>
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> DoorRemoteComponent moved from Content.Server.Remotes to
Content.Shared.Remotes.Components, DoorRemoteSystem OnInHandActivation
changed from Public to Private, DoorRemoteSystem moved from
Content.Server to Content.Shared, DoorRemoteSystem is now
SharedDoorRemoteSystem
>
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
>
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 🆑
> - add: Door remote UI now shows the mode it is in.
>
</details>
Signed-off-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->
# Description
<!--
Explain this PR in as much detail as applicable
Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->
**FIGHT THE POWER WITH THE POWER!**
Here is a major resprite for most power related things, mostly for SMES,
APC, Airlarm, ect...
Wizden made PRs horible to look at, lets not make that mistake here!
---
# TODO
<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->
- [x] SMES
- [x] APC
- [x] Airalarm
- [x] Cameras
- [x] LightTube
- [x] Intercom
- [x] FireAlarm
- [x] Substation
---
<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->
<details><summary><h1>Media</h1></summary>
<p>
</p>
</details>
---
# Changelog
<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->
🆑 FoxxoTrrystan
- tweak: Power Resprites! (New SMES, APC, Airlarm, Camera, Substation,
LightTube, Intercom, FireAlarm and Substation)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->
# Description
<!--
Explain this PR in as much detail as applicable
Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->
Require #459
Add 3 optional settings for LanguagePrototypes to play with richtext
tags to they could be reconized as Makings
color - Set a specefic color to the text.
fontId - Set a font to the text by using the Id.
fontSize - Set the size of the text
All 3 are optional if not set message will be handeled like normal.
This should be mostly used to know what language your currently speaking
and assist with markings.
Take note those changes happent only in the TextBox chat, bubblechat is
left unchanged.
---
# TODO
<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->
- [x] Add Markings
- [x] Add Fonts
---
<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->
<details><summary><h1>Media</h1></summary>
<p>
</p>
</details>
---
# Changelog
<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->
🆑 FoxxoTrystan
- add: Languages are now marked in the chat!
---------
Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
Signed-off-by: FoxxoTrystan <45297731+FoxxoTrystan@users.noreply.github.com>
Co-authored-by: fox <daytimer253@gmail.com>
Co-authored-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
This is an automated Pull Request. This PR updates the GitHub
contributors in the credits section.
Co-authored-by: SimpleStation Changelogs <SimpleStation14@users.noreply.github.com>
# Description
This PR adds the ability to transfer objects from one player's hand to
another player's hand, as in SS13.
I have little coding experience, so my solutions may not be ideal.
---
# TODO
- [x] Make the code work
- [x] Add popup
- [x] Write a summary of the code
- [x] Сorrect inaccuracies
<details><summary><h1>Media</h1></summary>
<p>
https://youtu.be/zTQWTsYm1gw
</p>
</details>
---
# Changelog
🆑
- add: Added system
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
- - - - - - - -
---------
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
# Description
The language PR was merged early and OH GOD I ALREADY REGRET IT
This PR is intended to provide the missing refactors and address the
issues that were missed due to the early merge.
---
# TODO
- [X] Introduced a polymorphic obfuscation property to the
LanguagePrototype - now it supports more than just 2 hardcoded methods,
and each method can be configured per-language. Currently there are 3
obfuscation methods: replacement (same as replacement accent),
obuscation by syllables and obfuscation by phrases.
- [X] Refactored the existing obfuscation methods to not be a big
hardcoded mess.
- [X] Updated the existing languages accordingly: animalistic languages
are now less of an unreadable mess and include less syllables. Certain
languages like binary and snake seriously benefit from that.
- [X] Refactored the existing commands in response to the
never-addressed review (it got lost among hundreds of others)
- [X] Refactored the commands to be more user-friendly (you can now use
the number of the language in saylang and languageselect which can allow
using keybinds to switch between languages)
- [X] Moved a lot of obfuscation-related stuff from server to shared.
The actual obfuscation process, however, is still done on the server.
That may or may not be subject to change, too.
- [X] Refactored the entire process of resolution of entities'
languages. Instead of raising an event every time it's required to learn
what languages an entity knows, the lists of ALL languages available to
the entity (including via translators) is stored in
LanguageSpeakerComponent and only updated when necessary (e.g. when a
translator gets toggled). The list of languages the entity knows on its
own is now stored in LanguageKnowledgeComponent.
- [X] Made handheld translators automatically change your current
language when activated.
- [X] Rewrote the translator implanter system, now using the real
implants and implanters
- [ ] Rebalance science stuff (translators are incredibly expensive for
what they're worth)
- [ ] Uhhh stuff
---
<details><summary><h1>Media</h1></summary>
<p>
N/A for now
</p>
</details>
---
# Changelog
🆑
- tweak: Translator implants are now proper implants that can be
removed.
- tweak: Animalistic languages should now look less messy.
- fix: Hopefully fixed language menu desync and other issues.
---------
Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
# Description
This PR brings back a previous briefly existing feature, that of the
NormalVisionComponent, which now exists as a single point positive trait
that can be taken only by Harpies and Vulpkanin(A list to later be
expanded if we ever get new species that have modified vision types).
This trait is called "Trichromat Modification", and it simply removes
any species based vision modifications an entity may have, such as
Ultraviolet Vision.
🆑
- add: Trichromat Modification has been added as a new positive trait.
It can be taken by Harpies and Vulpkanin to buy off their unique vision
negative traits.
Signed-off-by: VMSolidus <evilexecutive@gmail.com>
# Description
The original release of Loadouts to EE did not have much in the way of
actual implementation as far as the item list was concerned. This PR
seeks to get a head start at fixing that by implementing a fairly
sizeable chunk of new items that can be bought with loadout points.
One important addition is the use of "non-clothing-job-related items",
which helps further set this version of Loadouts apart from the /tg/
style of loadouts implemented elsewhere. One of the key strengths of
this loadout system is that it's not limited to just replacing a job's
clothing selections, but can also add items unrelated to clothing. My
given example for this is the new option for Security
characters(provided they have sufficient number of hours as a Security
Officer) can spend roughly half their loadout points to start with a
spare magazine for their handgun.
Secondly, we also now have an opportunity to place non-nanotrasen
corporate items in the game, in such a way that players can tie their
characters to other corporations. Ostensibly this is to build up to the
idea of "Contractor" characters. I hope that this will help broaden
people's horizons.
# On "Syndie" items
I'd like to take this as an opportunity to kind of push people away from
the whole thing of "THATS A SYNDICATE ITEM!!!!" wherever possible. For
the most part this is very much NRP behavior that I'd like to
discourage. With some notable exceptions, this doesn't mean outright
antag items should be obtainable through Loadouts. To that end, items
such as Interdyne branded smokes, Cybersun branded clothing, and other
items with "In-Universe Company Brands" should be moved away from their
identity as strictly antag objects, and instead things characters could
reasonably have bought with their paycheck.
# Technical Changes
I had to make some improvements to the way Loadouts handles species,
namely it wasn't previously possible to have an item require any entry
from a list of species. I updated it so that SpeciesRequirement takes a
list of Species, and will accept any entry from that list. My given
example for this is the entries for Nitrogen air tanks, which can only
be purchased in loadouts by SlimePersons and Vox(who are not currently
playable, but I am accounting for them). Other usage of this is in the
Oni-specific Security items. I do hope to use this as an opportunity to
introduce more species-specific goods in the future.
# Media
Outerwear
More job-related selections available to some departments
More variety of trinkets and items, including instruments!
Species Specific Items!
# Changelog
🆑 VMSolidus
- add: The catalog of items available via Loadouts has been greatly
expanded. Have fun customizing your characters!
---------
Signed-off-by: VMSolidus <evilexecutive@gmail.com>
Signed-off-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Co-authored-by: SimpleStation14 <130339894+SimpleStation14@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: SimpleStation Changelogs <SimpleStation14@users.noreply.github.com>
Co-authored-by: Pspritechologist <81725545+Pspritechologist@users.noreply.github.com>
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Co-authored-by: stellar-novas <stellar_novas@riseup.net>
# Description
This restores the basic/survival event rates to how they were before
before #486 (however, it keeps the CVars created in it).
- 5-25 minutes for basic instead of 15-35
- 4-12 minutes for survival instead of 20-45
---
# Why
The PR made it so that survival rounds actually have less events than
extended - that is considering that survival rounds are supposed to be
troublesome and filled with events while extended ones are supposed to
be a chill alternative.
Other forks don't bother with editing CVars every 5 minutes, so this
"opportunity to configure their experience" was never addressed. Based
on the feedback I've received from other players, the change was rather
negative.
From my personal experience, survival rounds became an extended
extended, where during a 2-hour shift you can get a grand total of one
power outage and two mice infestations, and nothing else at all.
---
# Changelog
🆑
- tweak: Events should now occur as frequently as before. Note: server
owner can configure the frequency on their server manually.
Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
