Commit Graph

22004 Commits

Author SHA1 Message Date
Ed
8bca049ca7 New Thief minor antagonist (#21520)
* start working

* add right-click thief antagins
some architecture restruct

* add meh thief greeting audio

* add thief subgamemode to Traitors gamemode

* add late join thief (not tested yet)
add briefing

* add pacifism

* add Steal tasks to thief

* fix crash thief+traitor on person

* add new condition: collection steal

* add tracking of succes collection objective

* add stamp collection target
remove some boring steal target
add check pulling entity to collection target

* finalize first 2 group objective

* start merging stealing objective systems

* merging

* finish merging. Now traitor steal objective work better

* we don't check the items of pullable sentient entity

* clear naming, enable thief signle item objective start

* objective pack add

* finish with steal item objectives

* convert string to ProtoId<>

* some clean up

* add thieves to revolution game mode

* Update Resources/Locale/en-US/game-ticking/game-presets/preset-thief.ftl

Co-authored-by: Flareguy <78941145+Flareguy@users.noreply.github.com>

* Update Resources/Locale/en-US/game-ticking/game-presets/preset-thief.ftl

Co-authored-by: Flareguy <78941145+Flareguy@users.noreply.github.com>

* update pacifism: fix crashing, monkey-thief without pacified

* adaptive animal briefing, cleaning locales

* add structure steal objectives

* remove RCD target

* add thiefs to manifest, but bug with traitor duplications

* add escape objective

* add chat briefing

* setup animal objective group system

* add animal steal objectives

* add animal objectives notroleconditions

* add morty

* now thief mode has a chance of not launching Now there are a random number of thieves per round from 1 to 3

* 6 hours of trying to fix duplicate tasks. Failure

* added thief pinpointer (buggy)

* start thief backpack UI work

* revert pinpointer for scope reason

* UI continue work

* add thief starter kits content

* remove ERP kit :trollface:

* finally! giving starting items to thief. Now it playable, but still need more work

* clean up

* fix

* fox

* add merged items into thief
new Starting Kit (buggy)

* fix YES antag menu

* objection tweaks

* remove hearts objective, working on spawning things from toolbox

* smug

* fixes

* add race specifier objective condition LAMPS

* meh

* fix fix fix

* the alive

* Adding stamps

* Update backpack.ftl

* Revert1

* Revert ftl

* add voice mask to communicator kit

* Update Resources/Locale/en-US/administration/antag.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

* Update Resources/Locale/en-US/game-ticking/game-presets/preset-thief.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

* Update Resources/Locale/en-US/thief/backpack.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

* Update Resources/Locale/en-US/objectives/conditions/steal.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

* Update Resources/Locale/en-US/thief/backpack.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

* Update Resources/Locale/en-US/thief/backpack.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

* Update Resources/Locale/en-US/thief/backpack.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

* Update Resources/Locale/en-US/thief/backpack.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

* Update Resources/Locale/en-US/prototypes/roles/antags.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

* Update Resources/Locale/en-US/thief/backpack.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

* update

* fix

* more reusable function, add documentation

* fix doc

* faint fixes

---------

Co-authored-by: Flareguy <78941145+Flareguy@users.noreply.github.com>
Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>

(cherry picked from commit 144af233c4f4135cccacfa5d50281fce44a1595e)
2024-01-22 18:30:44 +01:00
LordCarve
ed1813f1dd Fixed PaperSystem bugs (#22896)
(cherry picked from commit 044f5e7c4ebda196c1cd57322424b9ff932e6f9f)
2024-01-22 18:29:24 +01:00
Nemanja
1fa68eefb0 Ion law visuals (#22908)
(cherry picked from commit 681f9a2c852033949f0b984f9f3b711c52e4cfdf)
2024-01-22 18:29:23 +01:00
Darkie
03abecd365 ItemToggle system expansion (#22369)
* Fixed EnergySword and variants having incorrect sound on attacking when in their Off state.

* Removed the unused ItemToggle from the serverside and created a new shared ItemToggleComponent and System, now used for the e-blade family of items. Also added e-blade hum and swing sounds. Thanks Sloth for the initial code!

* Changing Stunbaton system to include the itemToggle system.

* Adapted changes that have come up in the meantime.

* Changed damagespecifier to be serializable and autoNetworked in melee weapon components. Fixes a bug that makes it so client-side, damage values are not updated on toggle.

* Made the ItemToggleSystem have both a shared and a server component. Ported the Stun Baton and Stun Prod to the new toggleable system. Added a failure to activate noise component.

* Ported the welders to the new item toggle system. Set it so deactivated damage and item size default to the item's regular options.

* Removed unnecessary usings.

* Small modification to the stun prod.

* Made the integration test use the new method to turn the welders on.

* Fixed a few testing issues, applied a few changes requested by Delta.

* Updated Stunbaton code for consistentcy when it comes to calling the itemToggle component.

* Removed a redundant return; as per Delta.
Made examining the stun baton for charge rely on the battery component instead.

* Removed the welder visualizer system, now using the generic one. Removed some unused usings. Removed the welder visuals and layers.
Ported lighters to the new system.
Added zippi (sic) lighters.

* Renamed variables used to make them less generic.

* Simplified the light update code.

* Fixed the unit test to use the itemToggle system for welders now.

* Made the name shorter. I can't tell if the welding damage when interacted with actually does anything though. I can't figure out how to trigger it.

* Fixed some YML issues.

* Added a client side item toggle system just to make the shared code run on local UID's too.

* Fixed some more Yaml.

* Made the Zippi lighter have its own parent item, so it doesnt' conflict with the random pattern on the regular lighter.

* Made the zippi lighter its own in-hand sprites.

* Added a summary for the activated property in itemtoggle component.

* Fixed a typo in the itemToggle Component.

* Fixed a typo.

* Added to the remarks for the ItemToggleComponent.

* Fixed up the lighter yaml to make it use a generic term instead of a toggle layer enum for the random skin.

* Fixed a bug I introduced accidentally with the humming sound.

* Removed 2 unnecessary events from the ItemToggleSystem and component.

* Fixed a bug by only making the server run the item activation code, since the client cannot predict whether or not the activation will be cancelled.

* Cleaned up some names and functions getting called.

* Renamed a couple of variables and removed the explicit datafields from the component. Removed "activated: false" from yml since they're already deactivated by default.

* Added an IsActivated function, used it in the welder and stun baton systems code.
Refactored welder code to remove the WelderToggle event, now using the ItemToggleActivatedEvent instead for eye protection check.

* Fixed a typo. Added some comments.

* Split the ItemToggle into smaller components.
Changed the items that used the toggle system to work with the smaller components.
Made the mirror shield reflect energy shots with a 95% chance.

* Fixed the namespaces for the server components and whatnot.

* Fixed a doubled deactivation sound from using activated wieldable items (like the double Esword).
Fixed wrong yml with the e-dagger.
Fixed the disarm malus code.

* Added the zippo lighter to the detective's trench coat.

* Removed the default hit sound for the double e-sword since it was unnecessary.

* Changed e-sword damage numbers to be in line with the changes made by Emisse.

* Made no damage sounds be autoNetworked, so it changes can be changed on activation/deactivation of items.
Made Welders and Eswords sound like themselves but quieter if they hit for 0 damage, instead of taps.
You can choose what sound to play when a weapon does 0 damage when activated now.
Fixed a bug with swing sounds.

* Typo.

* Fixed a bug where the welder would blind you if you used it while it was off.

* Created a single abstract method called when an item has completed its toggle.

* Update Content.Server/Eye/Blinding/EyeProtection/EyeProtectionSystem.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Fixed a comment.

* Made most component variables readOnly for ItemToggle. There is no need to be able to change them from within the variable viewer.

* Removed trailing white spaces.

* Made the Use a field instead of a property in the itemToggleActivation/Deactivation attempt events.

* Small fixes.

* Removed ForceToggle, just use the toggle method instead.

* Fixed a bug with item sharpness staying even after getting deactivated, if the item gained sharpness that way (esword).

* Used ProtoId in the welder component.

* Made damage NetSerializable as well.

* Added networking and data fields to a couple of components.

* Made component variables autonetworked. Added some comments.

* Moved the events that modify item components on toggle to events, handled (where possible) in the systems linked to said components.

* Made all the component variables readWrite again.

* Added the component get to the WelderStatus.

* Added a predictable bool to the item toggle component.

* Replaced the Activated/Deactivated events with ToggleDone, with an Activated argument. Used that to simplify some systems.

* Added a reflect update raise event.

* Removed the Zippo changes. To add in a later PR.

* Removed the zippo from meta.json too.

* Small fix.

* Another small fix.

* Fixed the wieldable system thing in ItemToggle.

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

(cherry picked from commit a3fbab84e645a16a30845aa1e683e7ffc0e3b8cd)
2024-01-22 18:29:05 +01:00
chromiumboy
a37bf27456 Power monitoring console overhaul (#20927)
* Prototyping whole station wire map

* More prototyping

* Added icons for the different power distributors and toggleable cable displays

* Power cable layouts are now only sent to the client when the power monitor is open

* UI prototyping

* Power monitors can now see the sprites of distant entities, long entity names are truncated

* Updated how network devices are added to the player's PVS

* More feature prototypes

* Added source / load symbols

* Final prototype! Time to actually code it properly...

* Start of code clean up

* Continuing code clean up

* Fixed UI appearance

* Code clean up complete

* Removed unnecessary changes

* Updated how power values are calculated, added UI warnings for power sinks and power net checks

* Updated how power values are calculated again, added support for portable generators

* Removed unnecessary files

* Map beacons start toggled off, console map now works outside the station, fixed substation icon

* Made some of Sloth's requested changes. Power distributors don't blink anymore, unless selected

* Moved a number of static variables in PowerMonitoringHelper to sensible places in the main files. Added a NavMapTrackableComponent so that you can specify how individual entities appear on the navmap

* Updated the colors/positions of HV cables and SMESes to improve contrast

* Fixed SMES color in map legend

* Partially fixed auto-scrolling on device selection, made sublists alphabetical

* Changed how auto-scroll is handled

* Changed the font color of the console warning messages

* Reduced the font size of beacon labels

* Added the station name to the console

* Organized references

* Removed unwanted changes to RobustToolbox

* Fix merge conflict

* Fix merge conflict, maybe

* Fix merge conflict

* Updated outdated reference

* Fixed portable_generator.yml

* Implemented a number of requested changes, move bit masks to a shared component

* Navigate listings via the navmap

* First attempt at improving efficiency

* Second attempt at optimization, entity grouping added for solar panels

* Finished solar panel entity joining

* Finished major revisions, code clean up needed

* Finializing optimizations

* Made requested changes

* Bug fix, removed obsolete code

* Bug fixes

* Bug fixes

* STarted revisions

* Further revisions

* More revision

* Finalizing revisions. Need to make RT PR

* Code tidying

* More code tidying

* Trying to avoid merge conflicts

* Trying to avoid merge conflicts

* Removed use of PVS

* Improving efficiency

* Addressed a bunch of outstanding issues

* Clear old data on console refresh

* UI adjustments

* Made node comparison more robust. More devices can be combined into one entry

* Added missing component 'dirty'

(cherry picked from commit 1de682e23fd3cb832fa3328a7e6c4bd4b1a858f7)
2024-01-22 18:28:33 +01:00
lzk
7a8c1569e9 Fix nettle seeds inhand sprite (#22891)
fix

(cherry picked from commit e6b52cc294a9ecafadda75ff62b91c60152b7d96)
2024-01-22 18:28:31 +01:00
StanTheCarpenter
aa1e17ca47 Added Santa's hardsuit and helmet. (#22898)
* Added Santa's hardsuit and helmet.

* Fixed missing files

(cherry picked from commit 734da59202b2dfb255e0d0b0cda4b81009243068)
2024-01-22 18:28:30 +01:00
deathride58
5f2e378236 Adds a vscode launch option for starting the client in the compatibility renderer (#22904)
adds a vscode launch option to start the client with the compatibility renderer

(cherry picked from commit 30ff5fde6922d129f63642ef0ce1c0c641d2739b)
2024-01-22 18:28:19 +01:00
lzk
cc3d38adb9 fix cargo backpack inhand sprite (#22888)
Update inhand-right.png

(cherry picked from commit 5d0624bd343879fa43a11e7aa8ff1c4a2c96fbd6)
2024-01-22 18:28:18 +01:00
deathride58
fd26c9dedb fixes drug shader in compatibility mode FOR REAL THIS TIME (#22903)
fixes drug shader FOR REAL THIS TIME

(cherry picked from commit 3addd3e32c3d9e30ddc3ae8d1f72452d15941301)
2024-01-22 18:28:09 +01:00
router
1890d1affe Fix accidental plasma burn nerf (#22894)
(cherry picked from commit f2cb05bc619347fd822a7a17e5d5008da685322e)
2024-01-22 18:28:08 +01:00
deathride58
a638869729 Fixes GLES2 crashing when compiling the drug shader (#22899)
fixes drug shader not compiling in gles2 and also applies DRY

(cherry picked from commit 9870c7f9eb23cc8559c37d8744c7b7945b32d055)
2024-01-22 18:28:07 +01:00
SpaceyLady
f5768ce72e Correct spelling mistakes for daily tips (#22893)
Update tips.yml

(cherry picked from commit 9103061ac0ed248526a70763d7f171b52916084d)
2024-01-22 18:27:53 +01:00
Velcroboy
1b1745b41c Add Chef's Belt (#22868)
* Add Chef's Belt

* Reduce contents in filled belt to just s&p

---------

Co-authored-by: Jeff <velcroboy333@hotmail.com>

(cherry picked from commit dfa71af1f85e49c6017618c68d960b5cfc6897d9)
2024-01-22 18:27:05 +01:00
Alzore
9a37f71a37 Add a bottle of water to the survival box (#22881)
* BO'OH'O'WA'ER

* smallbottle

* extendedbox

(cherry picked from commit a09efd47cde04cced5d0f220ad6811775e67c599)
2024-01-22 18:26:08 +01:00
Nemanja
c065f42b4f Move HUD options to general options tab (#22884)
(cherry picked from commit 06a663d3ab525d0317e4f4c7803014e4afad9d79)
2024-01-22 18:24:38 +01:00
Nemanja
21548d9cf8 Corner Clothing UI (#22883)
* Corner clothing (save point)

* IT WORKS. YIPPEE

* the last of it

* template rejigs

(cherry picked from commit 9b18357a882d6a9e3dfb3b4fccaa42f65238c9f0)
2024-01-22 18:24:28 +01:00
liltenhead
a5bd383e66 Vial Drinking (#22886)
vial drink

(cherry picked from commit 33399db6c2c9621ad6d2865f9d197a2062e99ecc)
2024-01-22 18:24:21 +01:00
lapatison
18a7449f86 Cargo request plasma canister locale (#22858)
* name and desc removal

* locale

* shouldnt have touch that for now

(cherry picked from commit 6baf564fa089ebd90f5938ae53aca90b8fcfac17)
2024-01-22 18:24:15 +01:00
deathride58
15ed6ea3ee Drug overlay shader rework - a little more motion-sickness friendly, a little less shonky (#22872)
* reworks the drug overlay effect to be less motion-sickness inducing and a bit less shonky

* UNAUTHORIZED fucking THING. DESTROY it immediately

* further tweaks - adds another gradient to control the color effect too

(cherry picked from commit e61b7d105c398a925bb4d53fb39df886e7448e98)
2024-01-22 18:24:09 +01:00
Moomoobeef
785a1906fd New sprites for books on bookshelves in order to look less sad. (#22874)
Changed sprites for books on bookshelves, added one missing sprite

(cherry picked from commit c64c98ec1d48ace10443100aa2e6a84974751b5a)
2024-01-22 18:24:03 +01:00
Ed
6621f70af5 Anomaly synchronizer buff (#22771)
* Update production.yml

* Update electronics.yml

* Wat

* Update anomaly_sync.yml

* Update anomaly_sync.yml

(cherry picked from commit 3f8ad3a13d62ac1a6a401026e02a92f2f8471c19)
2024-01-22 18:23:57 +01:00
lzk
b6593a1916 add saturation to TC inhand sprites (#22870)
change

(cherry picked from commit 8604efc520934e1de5c67f96ebb1df9d1da600d1)
2024-01-22 18:23:50 +01:00
deltanedas
cc6848ff75 jaws cant pry bolted doors (#22860)
* jaws cant pry bolted doors valid jaws can

* no valid jaw

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
(cherry picked from commit ffe4569854c5ac54f77b56f73a9617659443053a)
2024-01-22 18:23:44 +01:00
Ed
22a763deae Doggy Ears (#22832)
* add content

* sprite update

* goodbuy nose

(cherry picked from commit def4e0f60e5adeeb869ac2b7233531c9daadc95e)
2024-01-22 18:23:34 +01:00
lzk
91df22e2fd Remove job specific traitor items from vendors (#22867)
Update chapel.yml

(cherry picked from commit fe8e0e6f9f4fd4cfbc83eab3391382cbadc76070)
2024-01-22 18:22:44 +01:00
Debug
46c41c6f90 Hopefully fix roboisseur zzzz-the (#700)
Quickly, you fools, zzzz-the
2024-01-22 11:20:20 +01:00
Debug
a1b3d4e4b8 No more fuckrules (#705)
Update clientCommandPerms.yml

Signed-off-by: Debug <49997488+DebugOk@users.noreply.github.com>
2024-01-22 11:20:00 +01:00
DeltaV-Bot
89d107b7cd Automatic Changelog Update (#703) 2024-01-21 18:58:43 +00:00
Debug
18f0af1f68 Implement gridinv, proper (#703)
* Implement gridinv, 1500 squashed commits :elp:

* Me when

* Linter errors

* Fix katana belts
2024-01-21 19:58:28 +01:00
Velcroboy
5727e2797b Map Hotfix: Hammurabi (#699)
* Map Hotfix: Hammurabi

* fix corpsman's airlock

---------

Co-authored-by: Velcroboy <>
2024-01-20 03:52:27 +00:00
DeltaV-Bot
396973d254 Automatic Changelog Update (#698) 2024-01-19 22:33:36 +00:00
Debug
0eef1fe0ee Gamemode votes (#698)
* Allow voting for the extended and survival gamemode

These votes shouldn't be called ever anyways, so might aswell use them for the adminless server

* Update periapsis.toml
2024-01-19 23:33:21 +01:00
Debug
7af57039b5 Fix SpareIdCabinet prototypes (#697) 2024-01-19 21:50:02 +00:00
DeltaV-Bot
ae8f3fab95 Automatic Changelog Update (#631) 2024-01-19 21:06:47 +00:00
lleftTheDragon
16e07742b9 Salvage cloak (#631)
* CLAOK TO BRRR

* Correct cloak placement

* more corrections

* removed unwanted code

* Update Resources/Prototypes/Catalog/Fills/Lockers/cargo.yml

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
Signed-off-by: lleftTheDragon <125433431+lleftTheDragon@users.noreply.github.com>

* Update Resources/Prototypes/Catalog/Fills/Crates/salvage.yml

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
Signed-off-by: lleftTheDragon <125433431+lleftTheDragon@users.noreply.github.com>

* Update Resources/Prototypes/Catalog/Fills/Lockers/cargo.yml

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
Signed-off-by: lleftTheDragon <125433431+lleftTheDragon@users.noreply.github.com>

---------

Signed-off-by: lleftTheDragon <125433431+lleftTheDragon@users.noreply.github.com>
Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
2024-01-19 22:06:32 +01:00
Debug
f06d4ac695 Remove remaining spare ID card (#696)
Update heads.yml

I forgor

Signed-off-by: Debug <49997488+DebugOk@users.noreply.github.com>
2024-01-19 22:00:03 +01:00
DeltaV-Bot
f2ad4eb9a8 Automatic Changelog Update (#678) 2024-01-19 20:57:25 +00:00
Adrian16199
022ca05116 Laika change. (#678) 2024-01-19 21:57:10 +01:00
DeltaV-Bot
c791a6a78f Automatic Changelog Update (#643) 2024-01-19 20:54:45 +00:00
Adrian16199
fa044a0f99 Fixes mantis not spawnin with their respective bag. (#643)
* Fixes mantis not spawnin with their respective bag.

A small thing but somethin to note nontheless.

* Fixes it as I didnt notice that there was already yml for the other ones, eeh

* Update backpack.yml
2024-01-19 21:54:29 +01:00
OCO_Omega
13b0a784a1 Fix psionic invisiblity to others (#650)
Set vis flags to cyborgs, silicon, ghost
2024-01-19 21:54:17 +01:00
DeltaV-Bot
59773dcbe0 Automatic Changelog Update (#679) 2024-01-19 20:53:22 +00:00
Debug
1a5469fd90 Prevent zombies from becoming psionic (#679)
* Prevent zombies from becoming psionic, and remove existing powers.

* Minor spelling mistake
2024-01-19 21:53:05 +01:00
Velcroboy
1f20714b87 Fixes snake spawner spawning spiders (#688)
Co-authored-by: Jeff <>
2024-01-19 21:52:51 +01:00
DeltaV-Bot
f0d3e58a2e Automatic Changelog Update (#690) 2024-01-19 10:30:49 +00:00
Colin-Tel
e33e3aca9a Update Rules.txt (#690)
* Update Rules.txt

* Update Rules.txt
2024-01-19 11:30:33 +01:00
Velcroboy
3b842b6fae Map Edits: Hammurabi (#694)
Co-authored-by: Velcroboy <>
2024-01-19 02:24:37 +00:00
Velcroboy
fe40f3365f Map Edits: Hammurabi (#689)
* Map Edits: Hammurabi

* add psionic mantis

---------

Co-authored-by: Velcroboy <>
2024-01-18 07:34:51 +00:00
Velcroboy
3b1abac497 Map Hotfixes (#687)
Co-authored-by: IamVelcroboy<>
2024-01-17 05:30:35 +00:00