Commit Graph

4 Commits

Author SHA1 Message Date
Spatison
a2557f75a6 Upstream (#129) 2024-11-21 17:49:04 +07:00
Mnemotechnican
b87cb9ce42 Pulling Minor Fixes (#966)
# Description
- Fixes BeingActivelyPushed not resetting when pulling stops, resulting
in entities who broke out of pulling being able to fall into trashcans
and whatnot.
- Makes it so that the puller does not receive impulse while pushing
under gravity (as it turns out, it is, in fact, annoying when you are
small)
- Increases the default continuous push duration to 5 seconds to make
pushing heavy objects easier.

<details><summary><h1>Media</h1></summary>
<p>


https://github.com/user-attachments/assets/1808fb33-b9af-41b4-bec8-138eab088565


</p>
</details>

# Changelog
🆑
- tweak: Pushing something no longer causes your character to move, but
only if there is gravity holding you down.
- tweak: Pushing an object with Ctrl-RMB now pushes it continuously for
up to 5 seconds instead of 2.
2024-10-19 13:22:22 +07:00
Mnemotechnican
a7a9cf9e84 Physical Pulling (#883)
# Description
Fixes pulling being obnoxiously unphysical. Entities now exert a
specific amount of force defined as the product of their mass and the
SpecificForce set in their PullerComponent. Doing a ctrl-right click now
sets a target position where your entity begins to continuously push the
pulled entity towards, instead of throwing it or pushing it once
(however, it should still be possible to drag people and disposals and
the like). Additionally, your entity will properly experience recoil
from dragging someone around.

# TODO
- [X] Do stuff
- [X] Fix stuff
- [X] Fix aghosts not being able to push (?)
- [X] Fix pulling giving you free kinetic energy while in spess (how?)
- [ ] Test if throwing felinids into disposals via pulling still works
:trollface:

<details><summary><h1>Media</h1></summary>
<p>



https://github.com/user-attachments/assets/2498ef8c-f743-4702-b73c-b2da0c16e9aa


</p>
</details>

# Changelog
🆑
- add: Pulling has been reworked. Your character will now try to
continuously push the pulled entity when you use the push keybind.
- remove: You can no longer push the pulled entity while walking, and
pushing now follows the momentum conservation laws.
2024-10-19 12:54:31 +07:00
SimpleStation14
24f36c1803 Mirror: Pulling Rework V2 (#269)
## Mirror of PR #24936: [Pulling rework
v2](https://github.com/space-wizards/space-station-14/pull/24936) from
<img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `c584f6444a85cc53edb060230f7e7b2b76cc87bf`

PR opened by <img
src="https://avatars.githubusercontent.com/u/31366439?v=4"
width="16"/><a href="https://github.com/metalgearsloth">
metalgearsloth</a> at 2024-02-04 01:43:17 UTC

---

PR changed 53 files with 796 additions and 1356 deletions.

The PR had the following labels:
- Status: Needs Review


---

<details open="true"><summary><h1>Original Body</h1></summary>

> Health v2 moment
> 
> Fixes https://github.com/space-wizards/space-station-14/issues/24900
> 
> - Fixes container changes.
> - Fixes keybind.
> - Fixes multi-pull.
> - Fixes alerts cleanup for non-predicted pull stops.
> 
> I'm awake now for any issues.


</details>

---------

Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
2024-07-09 19:51:27 -04:00