* add button to menu
* networking and component work
* try to add access stuff
* main functionality done
* add access lock? I think?
* remove extra line
* fix access system
* move SkipTime to StationCargoBountyDatabaseComponent
* Disable/Enable skip button based on cooldown
* remove debugging
* add access denied sound
* remove DataField tags
* dynamic timer
## Mirror of PR #25931: [CargoConsoleMenu
localization](https://github.com/space-wizards/space-station-14/pull/25931)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `6e38b992cfc607e09178efc178b86f35152f0cde`
PR opened by <img
src="https://avatars.githubusercontent.com/u/87994977?v=4"
width="16"/><a href="https://github.com/modern-nm"> modern-nm</a> at
2024-03-08 14:46:29 UTC
PR merged by <img
src="https://avatars.githubusercontent.com/u/19864447?v=4"
width="16"/><a href="https://github.com/web-flow"> web-flow</a> at
2024-03-09 06:56:40 UTC
---
PR changed 20 files with 211 additions and 195 deletions.
The PR had the following labels:
- Changes: UI
---
<details open="true"><summary><h1>Original Body</h1></summary>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> ## About the PR
> <!-- What did you change in this PR? -->
> This PR adds localization capability for CargoConsoleMenu (name of
entity: ComputerCargoOrders)
>
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
>
> Please let me tell you a story of my vision. First i decided to make
these changes on one of russian community servers. But taking into
account future changes of .yml files by space-wizards community (they
are regularly added to our space-station build), we will have to
constantly edit xml files to remove duplicate categories — imagine
someone added cargoproduct with category "Fun", when we have tons of
items with category "Развлечения".
>
> To summarize: my PR makes possible to localize categories of
"cargoproduct" and makes communities do less work when upstream comes
>
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
>
> New code considers strings comparisons of prototype.Category
(Content.Client/Cargo/UI/CargoConsoleMenu.xaml.cs) using
Loc.GetString(...). And that's all.
>
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> Off course there are no visible changes on eng-localization
>
>
>
> That's how these changes look like on our community build, using other
.ftl file
>
>
>
>
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
>
>
> .yml
> - every category of type "cargoProduct" was edited to
"cargoproduct-category-name-{categoryName}"
>
> .ftl
> - file "cargoproduct-categories.ftl" was added to english localization
to localize categories of cargoProduct
>
> .cs
> - CargoConsoleMenu.xaml.cs got tweaks which prevent issues with
strings comparisons
>
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
>
</details>
---------
Signed-off-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: MODERN <87994977+modern-nm@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
* Use new Subs.CVar helper
Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.
This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.
* Fix a bunch of warnings
* More warning fixes
* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.
* Get rid of some more ISerializationHooks for enums
* And a little more
* Apply suggestions from code review
Co-authored-by: 0x6273 <0x40@keemail.me>
---------
Co-authored-by: 0x6273 <0x40@keemail.me>
(cherry picked from commit 68ce53ae17985876d6d112b764b2144964a9f42e)
- Change namespace, and folder of FancyWindow to Content.Client.UserInterface.Controls
- Change xaml reference from ui to controls in some places
- Change ClientAlertsSystem from internal to public
- Change namespace, and folder of HighDivider to Content.Client.UserInterface.Controls
