It functions identically to how V1 of orientation worked and it's incredibly annoying.
(cherry picked from commit 11dbf50ed62040c832941f3c46fc159497eca525)
Signed-off-by: Spatison <137375981+Spatison@users.noreply.github.com>
# Description
I got baited by Ectoplasm, so I then spent 3 hours shaving off a
sizeable chunk of this game's performance cost, including by taking 3 of
the "Top 10 frametime consumers", and reducing their performance costs
by 99% each. Along with various examples of slimming down some of the
worst EQE's.
Oh, and I fixed EmitSoundOnMove being desynced with actual movement. As
part of making EmitSoundOnMove use 99% less CPU time, it was also
synchronized with the MoverController.
# Changelog
🆑
- fix: Fixed items such as tactical webbing, bell collars, and hardsuits
being desynced with character movement.
- tweak: Made various large performance improvements.
(cherry picked from commit 684e8175443167beb0e20e3323a05b5f493b3374)
Problem I had on Parkstation, ported the fix here.
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
(cherry picked from commit 6061334d37f3bf89522da9703b607d86d7e67a5b)
* Уэээээээ
* Почти настрадались
* Скоро конец....
* СКОРО
* Мышки плакали, кололись, но продолжали упорно жрать кактус
* Все ближе!
* Это такой конец?
* Книжка говна
* фиксики
* ОНО ЖИВОЕ
* Телепорт
* разное
* Added byond
* ивенты теперь работают
* Разфикс телепорта
* Свет мой зеркальце скажи, да всю правду доложи - Я ль робастней всех на свете?
* Разное
* Еще многа всего
* Многа разнава
* Скоро конец....
* ЭТО КОНЕЦ
* Фикс линтера (ну, или я на это надеюсь)
* Еще один фикс линтера
* Победа!
* фиксики
* пу пу пу
* Фикс подмастерья
* Мисклик
* Высокочастотный меч
* Неймспейсы
* Пул способностей мага
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->
# Description
<!--
Explain this PR in as much detail as applicable
Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->
Ports the lone abductor and possibly(?) the duo abductors.
---
# TODO
<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->
- [X] Figure out why abductors aren't spawning as the abductor race.
- [X] Make sure it's not a buggy mess.
---
<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->
<details><summary><h1>Media</h1></summary>
<p>
</p>
</details>
---
# Credits
Thank to [Starlight ](https://discord.com/invite/wAyQKB78fH)for the
original version!
Darkrell, Rinary, and Landosaur made the funny little guys.
# Changelog
<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->
🆑 Darkrell, Rinary, Landosaur
- add: The Abductors are here to replace your organs. Gleep Glorp!
---------
Co-authored-by: gluesniffler <159397573+gluesniffler@users.noreply.github.com>
Co-authored-by: Solstice <solsticeofthewinter@gmail.com>
Co-authored-by: SX_7 <sn1.test.preria.2002@gmail.com>
Co-authored-by: Theodore Lukin <66275205+pheenty@users.noreply.github.com>
Co-authored-by: Piras314 <p1r4s@proton.me>
Co-authored-by: Ilya246 <57039557+ilya246@users.noreply.github.com>
(cherry picked from commit ea9f1526868289d20832989cb02f79c76c240918)
# Description
Implements the softcrit functionality.
Similiar to critical state but spessmen will be able to communicate and
crawl around, but not pick up items.
Also supports configuring what is and isn't allowed in different
MobStates (per mob prototype): you can enable picking up items while in
softcrit so people can pick up their lasgun and continue shooting after
taking a 40x46mm to their ass cheeks from the guest nukies while being
dragged to safety.
<details> <summary><h1>Technical details</h1></summary>
New prototype type: "mobStateParams" (`MobStateParametersPrototype`)
Used to specify what can and can't be done when in a certain mobstate.
Of note that they are not actually bound to any `MobState` by
themselves. To assign a params prototype to a mobstate, use
`InitMobStateParams` in `MobStateComponent`.
It has to be a prototype because if I just did something akin to
`Dictionary<MobState, Dictionary<string, bool>>`, you'd have to check
the parent and copy every flag besides the one you wish to modify. That
is, if I understand how the prototype system works correctly, which I
frankly doubt. <!-- Working on softcrit made me hate prototypes. -->
MobStateComponent now has:
- `Dictionary<string, string> InitMobStateParams`, for storing "mobstate
- parameter prototype" pairs. `<string, string>` because it has to be
editable via mob prototypes. Named "mobStateParams" for mob prototypes.
- `public Dictionary<MobState, MobStateParametersPrototype>
MobStateParams` for actually storing the params for each state
- `public Dictionary<MobState, MobStateParametersOverride>
MobStateParamsOverrides` for storing overrides.
`MobStateParametersOverride` is a struct which mirrors all
`MobStateParametersPrototype`'s fields, except they're all nullable.
This is meant for code which wants to temporarily override some setting,
like a spell which allows dead people to talk. This is not the best
solution, but it should do at first. A better option would be tracking
each change separately, instead of hoping different systems overriding
the same flag will play nicely with eachother.
- a shitton of getter methods
TraitModifyMobState now has:
- `public Dictionary<string, string> Params` to specify a new prototype
to use.
- Important note: All values of `MobStateParametersPrototype` are
nullable, which is a hack to support `TraitModifyMobState`. This trait
takes one `MobStateParametersPrototype` per mobstate and applies all of
its non-null values. This way, a params prototype can be created which
will only have `pointing: true` and the trait can apply it (e.g. to
critstate, so we can spam pointing while dying like it's a game of turbo
dota)
- The above is why that wall of getters exists: They check the relevant
override struct, then the relevant prototype. If both are null, they
default to false (0f for floats.) The only exception is
OxyDamageOverlay, because it's used both for oxy damage overlay (if
null) and as a vision-limiting black void in crit..
MobStateSystem now has:
- a bunch of new "IsSomething"/"CanDoSomething" methods to check the
various flags, alongside rewritten old ones.
-
lookin ahh predicate factory
</details>
---
# TODO
done:
- [x] Make proper use of `MobStateSystem.IsIncapacitated()`.
done: some checks were changed, some left as they did what was (more or
less) intended.
<details>Previous `IsIncapacitated()` implementation simply checked if
person was in crit or dead. Now there is a `IsIncapacitated` flag in the
parameters, but it's heavily underutilized. I may need some help on this
one, since I don't know where would be a good place to check for it and
I absolutely will not just scour the entire build in search for them.
</details>
- [x] Separate force-dropping items from being downed
done: dropItemsOnEntering bool field. If true, will drop items upon
entering linked mobstate.
- [x] Don't drop items if `ForceDown` is true but `PickingUp` is also
true.
done: dropItemsOnEntering bool field. If true, will drop items upon
entering linked mobstate.
- [x] Actually check what are "conscious attempts" are used for
done: whether or not mob is conscious. Renamed the bool field
accordingly.
- [x] Look into adding a way to make people choke "slowly" in softcrit
as opposed to choking at "regular speed" in crit. Make that into a param
option? Make that into a float so the speed can be finetuned?
done: `BreathingMultiplier` float field added.
<details>
1f is regular breathing, 0.25 is "quarter-breathing". Air taken is
multiplied by `BreathingMultiplier` and suffocation damage taken (that
is dealt by RespiratorSystem, not all oxy damage) is multiplied by
`1-BreathingMultiplier`.
</details>
- [x] make sure the serializer actually does its job
done: it doesn't. Removed.
- [x] Make an option to prohibit using radio headsets while in softcrit
done: Requires Incapacitated parameter to be false to be able to use
headset radio.
- [x] Make sure it at least compiles
not done:
- [ ] probably move some other stuff to Params if it makes sense. Same
thing as with `IsIncapacitated` though: I kinda don't want to, at least
for now.
---
<details><summary><h1>No media</h1></summary>
<p>
:p
</p>
</details>
---
# Changelog
🆑
- add: Soft critical state. Crawl to safety, or to your doom - whatever
is closer.
---------
Signed-off-by: RedFoxIV <38788538+RedFoxIV@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
(cherry picked from commit 9a357c1774f1a783844a07b5414f504ca574d84c)
* Update MoverController.cs
* Update a bunch of movement code to use Entity<T>
* Last errors
* wow, there were more errors
---------
Co-authored-by: plykiya <plykiya@protonmail.com>
(cherry picked from commit 5bb56c08d7dd6a64feefa503da3d004f8fb0966c)
# Description
Parkour Training, Sluggish and Snail-Paced have been reworked to be more
impactful in everyday space life. A new trait has been added, Bad Knees.
**Parkour Training** (-5 points)
- No longer modifies laying down
- Climbing speed bonus reduced from 65% to 50%
- 30% shorter slip stuns
- 50% resistance against slows in difficult terrain
- Example: Spider webs inflict a 50% slow, reduced by 50% results in a
25% slow.
Notably, the reworked Parkour Training is much closer to the CDDA trait
[Parkour
Expert](https://cddawiki.danmakudan.com/wiki/index.php/Parkour_Expert).
Difficult terrain examples: Spider webs, slime/blood puddles, kudzu,
space glue
**(NEW)** **Bad Knees** (3 points)
- Designed to be the opposite of Parkour Training
- 50% climbing speed penalty
- 40% longer slip stuns
- 35% increased slows in difficult terrain
- Example: Spider webs inflict a 50% slow, increased by 35% results in a
67.5% slow.
Inspired by the CDDA trait of the same name [Bad
Knees](https://cddawiki.danmakudan.com/wiki/index.php/Bad_Knees).
The stun time for banana peels and puddles is 3 seconds. With Bad Knees,
the stun is increased to 4.2 seconds. The time it takes to handcuff
someone is 3.5 seconds. Go figure :trollface:
**Sluggish** (3 points)
- No longer increases the time for laying down and climbing tables
(given to Bad Knees instead)
- Speed penalty increased from 15% to 16%
**Snail-Paced** (5 points)
- No longer increases the time for laying down and climbing tables
- Speed penalty increased from 30% to 32%
- No longer prevents you from slipping when running due to how slow your
sprint speed is. Snail-Paced trait users must suffer.
## Media
**Parkour Training**
**Bad Knees**
**Sluggish**
**Snail-Paced**
## Changelog
🆑 Skubman
- tweak: The Parkour Training trait has been reworked. It no longer
makes you lie down or get up faster, but grants you 30% shorter slip
stuns and 50% resistance against slows in difficult terrain.
- tweak: The Sluggish and Snail-Paced traits now only reduce your
movement speed with no other effects. The speed reductions have been
slightly increased from 15% to 16% for Sluggish, and 30% to 32% for
Snail-Paced.
- add: Added a new 3-point negative trait called Bad Knees. It is the
opposite of Parkour Training and it makes you climb tables slower,
stunned for longer against slip stuns, and move more slowly in difficult
terrain.
- tweak: Snail-Paced no longer prevents you from slipping when running.
(cherry picked from commit 89354922a0f6fb55111e0ce2b4b19e5f6d6ea0e2)
* Pistol-Whipping (Guns as Melee Weapons) (#1335)
# Description
Adds the ability to use guns as melee weapons and throwing weapons.
The gun melee attack is a Light Attack done with a right click. The
attack rate is slower than average melee weapons.
The cooldown on melee attacks after shooting has been removed entirely,
so you can right-click immediately after shooting (like in hero shooters
😎). The cooldown on shooting after a melee attack has been set to a
constant 0.5 seconds.
## Balance
Technically speaking, weaving shooting and pistol-whipping lowers your
overall DPS in most cases, because you can't shoot for 0.5 seconds after
doing a melee attack. With _skillful_ usage, however, it provides some
key tactical advantages:
- Preserving ammo by dealing damage without firing a shot.
- Deal stamina damage as a natural effect of dealing melee Blunt damage.
- Most non-pistol guns have increased blunt stamina damage factors to
help with this.
- Bypassing Piercing resists of armors with a higher Piercing resist
than Blunt resist like plate carriers.
- Doing the combo of right-clicking immediately after shooting deals a
big burst of damage.
Pistol-whipping also helps as a last resort when you run out of ammo.
However, it's almost always better to use a proper melee weapon instead
of a gun as a pure melee weapon, because you can't power attack with
guns and the guns' melee attack rate are slower by design than most
melee weapons.
Shotguns benefit the most from pistol-whipping, because their ideal
range is close-range where a melee attack can be performed, and their
low fire rate means they're not affected too much by the 0.5s shooting
cooldown.
Guns have received throwing damage. You can throw guns at the enemy once
you're out of ammo to deal extra damage. I think this makes fights a
little more spectacular to watch.
Melee damage sorted by group (from least to greatest):
1. Revolver
2. Pistol (+ Energy Pistol)
3. Sniper rifle
4. Rifle (+ Energy Rifle)
5. Sub Machine Gun
6. Shotgun
7. Light Machine Gun (L6 saw)
8. Heavy Machine Gun
## Media
**mk 58**
**Kardashev-Mosin (Wielded)**
**Basic Combat**
https://github.com/user-attachments/assets/922998d1-0cd0-4fea-8f0b-365bcff3c12b
**Particle Decelerator Combo (80 damage)**
https://github.com/user-attachments/assets/ce62334a-13dd-46d9-9c0e-453e26bf1261
Combo: Shoot + Power Attack, wait 1.6s then Power Attack + Throw
This combo costs 90 stamina which almost depletes 100 stamina leaving
you vulnerable, so the Vigor trait can help you pull off this combo.
## Changelog
🆑 Skubman
- add: Pistol-whipping has been added. You can press right click with a
gun to perform a Light Attack. Most guns will deal Blunt damage, apart
from the Kardashev-Mosin dealing Piercing/Slash damage with its bayonet.
Weaving bullets and melee attacks correctly will give you the upper hand
in combat.
- add: Guns can now be thrown to deal the same damage as their melee
damage.
(cherry picked from commit 5899f4ea5a978ded0362bdf46185f8fbb1a2607c)
* local #1335
* Fix Interact Verb (#1346)
Finally fixed it.
Interact verbs weren't appearing because this is required in BaseMob.
(cherry picked from commit 3e3ca59850f1a21f2bb8e249455d655ec6b63d2c)
* Fix Ripley Hydraulic Clamp (#1344)
# Description
Fix a bug in `MechGrabberSystem` causing the hydraulic clamps in Ripley
to drop items far away.
---
<details><summary><h1>Media</h1></summary>
<p>
https://github.com/user-attachments/assets/d2c8e951-e391-42d7-b45d-78a275dc8bf2
</p>
</details>
---
# Changelog
🆑
- fix: Hydraulic clamps now drop entities correctly
(cherry picked from commit f0e4612612fe18a126cdf47d712b63bc083b5483)
* Automatic Changelog Update (#1344)
(cherry picked from commit 6dcb367adb769f51bcaf1a647a4ca6c886a10be7)
* Salvage Magnet UI and Character Switching Height/Width Bug Fix (#1347)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->
# Description
<!--
Explain this PR in as much detail as applicable
Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->
i fixed it
also added a button "Connect & Go to Lobby" for people testing lobby
stuff!
Resolves#1131
---
# Changelog
<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->
🆑
- fix: Fixed the bug where switching characters made your width/height
change to incorrect values.
- fix: Fixed the salvage magnet opening ten times.
---------
Signed-off-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
(cherry picked from commit c4c3e4283ae077fd0f55e4cce31710f31de046f7)
* Automatic Changelog Update (#1347)
(cherry picked from commit 8ff70215d9f6e2a73150b55313333b9d5ca87749)
* Update Credits (#1350)
This is an automated Pull Request. This PR updates the GitHub
contributors in the credits section.
Co-authored-by: SimpleStation Changelogs <SimpleStation14@users.noreply.github.com>
(cherry picked from commit 2a7a4719d39b51ffd232c667b1ca49dbce68dce6)
* Fix Bartender Mosin (#1337)
Bartender Mosin was replacing their duffel bag at roundstart.
(cherry picked from commit 3aa430f486dcdf40629468c715092aee0089187c)
* Trait Purchasable Mentalic Powers (#1343)
# Description
This PR adds a few of the "Mentalic" category of psionic abilities to
the Traits System, allowing them to be purchased by any character that
is also a Latent Psychic. These powers are:
- Dispel
- Metapsionic Pulse
- Xenoglossy (Also requires Natural Telepath)
- Psychognomy (Also requires Natural Telepath)
These are all quite expensive, so to help address the "Expensive trait
proliferation", I've increased the points granted by the Blindness trait
to 10. Have fun being a blind wizard. From this point on, we're going to
need to start adding more "High point value" negative traits.
# Changelog
🆑
- add: Dispel, Metapsionic Pulse, Xenoglossy, and Psychognomy can all be
purchased during character creation using trait points.
- tweak: Blindness now grants 10 trait points instead of 6.
(cherry picked from commit acec14d08879ebaf16e5425fccd26d8f066eda55)
* Automatic Changelog Update (#1343)
(cherry picked from commit adddc1df27184f74e5e48e5220e0cd4eeb57084c)
* Pointy Ears For Harpies And Arachne (#1348)
# Description
Like half the art references I have for Harpies have them with elf-like
pointed ears, another half have them with their feather tufts. We have
pointy ears markings, so this PR makes it so that Harpies can have them.
Actually it also gives them to Arachne, for similar reasons(It's an
oddly common thing on Arachne/Lamia art depictions).
# Changelog
🆑
- add: Added a variety of Pointy Ears markings for Harpy and Arachne
characters.
(cherry picked from commit 59a55c9d6ae6772d4ead0e73d5dab7b24c539e53)
* Automatic Changelog Update (#1348)
(cherry picked from commit 99d616953af89462d827fd8ca6e50a92e63e8203)
* Port Cosmatic Drift Arrivals (#1340)
# Description
Done after a lengthy discussion with @OldDanceJacket about mapping
issues, namely the existence of "Walk-In Closets" on maps that take up
an inordinate amount of space that would otherwise be usable for other
purposes. Seriously, Saltern has a 4x6 room that contains >200 medical
uniforms, and is on a map intended only for 15 people(And maximum of 6
medbay personnel). Every map in rotation is like this.
Ostensibly, Loadouts were created to provide a solution to this problem,
by making it so that players choose their DRIP before spawning in, so
that mappers don't need to put in a whole ass room dedicated to medical
uniforms. But Mappers ended up keeping the "Walk-in Closets" even after
Loadouts were introduced to serve as a "Sanity check" in case of events
such as people not choosing their loadouts, or getting hired during the
round by the HoP to work in the medbay, etc. To solve this, me and ODJ
agreed upon adopting Cosmatic Drift's solution to this, by making it so
that the Arrivals Terminal serves as the "Walk-in Closet Hotel" that
every map can just piggyback off of. Nobody needs to make the stupid
closet rooms, on ANY map, because every map is fully guaranteed to have
every closet the players could ever need in arrivals.
# Media
<details><summary><h1>Media</h1></summary>
<p>
Dock
Dorms(Spawn points)
Medbay:
Security
Captain/HOP
Cargo:
Epistemics:
</p>
</details>
# Changelog
🆑
- add: Ported Cosmatic Drift's version of the Arrivals Terminal.
Terminal now includes every version of department clothing and material
lockers that players could ever need, allowing them to try on their
chosen job equipment and drip before departing for the station.
(cherry picked from commit 4509a9d030efb7eb45378824559a3f88c4caf4b4)
* Automatic Changelog Update (#1340)
(cherry picked from commit 9a1cda889a085974f666adb99c753ba4e1392355)
* More Dangerous Mindbreaking (#1249)
# Description
Somehow people weren't getting the memo despite the **HORRIFYING** texts
associated with Mindbreaking, that doing so is an almost comically evil
act akin to murder. So this PR fixes that. By making it even more
obvious.
<details><summary><h1>Media</h1></summary>
<p>
</p>
</details>
# Changelog
🆑
- add: Added a server option for "Scarier Mindbreaking". Mindbreaking
now irreversibly converts a player character into a non-sentient NPC.
- fix: Mindbreaking now only works on Psychics.
---------
Signed-off-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
Co-authored-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
(cherry picked from commit 80f83484e9653f159581ea0dfc82d56256e4947c)
* Automatic Changelog Update (#1249)
(cherry picked from commit 4d87be6ea66356156cdac6e7e9cd70af36daae24)
* Redshirt And Brittle Bone Traits (#1352)
# Description
This PR adds two additional "High Value" physical negative traits, to
help address a growing need for more high point value negatives, since
there is also a very large number of high point positive traits. These
two traits are fairly simple, the first is Redshirt, which decreases
your Dead threshold by 100, and Brittle Bone Disease , which reduces
your Crit threshold by 50. Taking both on an ordinary human would give
+18 trait points to work with, but would in turn give a healthbar of
only 50/100, compared with the standard healthbar of 100/200.
# Changelog
🆑
- add: Added Redshirt and Brittle Bone Disease traits. These give
extremely large negative modifiers to your healthbar, but also grant a
large amount of trait points to work with.
(cherry picked from commit 88edcd05aef76acb10e3d0924dd874eef22c7f71)
* Automatic Changelog Update (#1352)
(cherry picked from commit ed0e56aa446ea9ad9ecae1a1a1685438378b1814)
* Jackboots Slowdown Mitigation (PORT) (#1342)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->
# Description
<!--
Explain this PR in as much detail as applicable
Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->
Ports jackboot slowdown mitigation from [space-wizards
github](https://github.com/space-wizards/space-station-14/pull/30586).
Adds fake version for civilian use.
---
# Changelog
<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->
🆑
- add: Added slowdown mitigation to jackboots
- add: Added fake jackboots for style outside of sec
---------
Co-authored-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
(cherry picked from commit f5d45d790d793acbba7d21258cd206568fe79f99)
* Automatic Changelog Update (#1342)
(cherry picked from commit 03dc85aa7071c70cd9f01392cabf7cb7fb2fa6ac)
* Fix Redshirt & Brittle Bone Traits (#1355)
These were supposed to be negative traits(They give you points), but I
accidentally made them positive traits(They cost points).
(cherry picked from commit ec60940fe5eae5d7d3e969bac132e1da2a659272)
* Example Hub Ad List (#1356)
# Description
this PR extends the list of default advertiser hubs to include every
existing hub except for SSMV(Which is mutually exclusive with the
others). If there are more hubs I have missed, please let me know. This
will allow our servers to appear on as many hubs as possible.
(cherry picked from commit 577126f987ff70ba213f2898ea9e5170b0dc5ea6)
* Saltern Update (#1357)
# Description
I would like to offer my thanks to the Singularity Network Mapping Team
for this update, they've done some great work! This PR launches Saltern
with a significant rework to everything on it except for arrivals.
<details><summary><h1>Media</h1></summary>
<p>
Sorry, Map Renderer is dead right now.
</p>
</details>
# Changelog
Death do NOT change the name given for the Changelog author, the mappers
here have requested that "SiN Mapping Team" be given as the name for
this PR.
🆑 SiN Mapping Team
- add: Saltern has been fully reworked!
(cherry picked from commit a06b4661b08abe6f64460655962b98f4ccb9db07)
* Automatic Changelog Update (#1357)
(cherry picked from commit aab36bfe65d82cff13bb6d8b6a55c2b70a031aa2)
* v237.3.0 (#1354)
the robust toolbox updater!!
https://github.com/space-wizards/RobustToolbox/blob/v237.3.0/RELEASE-NOTES.md
(cherry picked from commit bf1b0d03aede161d62aedfc9166589335a5d7c4c)
* Hotfix Saltern (#1359)
# Description
Small maintenance to do. Bridge needed FixGridAtmos done, and a single
light in dorms needed wiring.
# Changelog
🆑
- fix: Fixed the Saltern bridge being a hard vacuum at roundstart.
(cherry picked from commit 3c1ed56ed3122866b32249006496c37be825c82a)
* Automatic Changelog Update (#1359)
(cherry picked from commit 48413d6a435de700197a4f6ceb1290d61f5130b4)
* Loadouts Debloating (Colorable Items) (#1364)
# Description
This PR cuts down significantly on Loadouts bloat by removing all
specific color versions of colorable items from the loadouts. I left the
original items untouched for compatibility reasons since certain things
in the game still need to be able to spawn a "Blue jumpsuit" etc.
Additionally, to help aid in clarity for players, I've added
localizations for all the generic colorable items so that they have
(colorable) in the loadout names, so that players can tell which items
have the option without needing to click into the customize button on
every item.
<details><summary><h1>Media</h1></summary>
<p>
</p>
</details>
# Changelog
🆑
- add: Added labels to all generic colorable items in loadouts, so that
players can see which items have custom colors as customization options.
- remove: Removed all 'specific color' variants of colorable items from
Loadouts, such as "Blue Jumpsuit" when a colorable jumpsuit exists.
(cherry picked from commit 452b9113f61790e8258b95904361de5ed34a034f)
* Automatic Changelog Update (#1364)
(cherry picked from commit cd5a6f8b5743904dbecbf04e5d70614e4444d149)
* More Colorable Items (#1365)
# Description
This PR adds even more colorable items to loadouts, this time making
entirely new whitescale versions of existing items that did not have one
previously. This replaces several more options for items that had a
whole bunch of specific color entries with a single item that can take
any color.
<details><summary><h1>Media</h1></summary>
<p>
</p>
</details>
# Changelog
🆑
- add: Added colorable variants of fingerless gloves, headbands, berets,
hairflowers, cloth masks, and the neck gaiter.
(cherry picked from commit 0674895a3b6a84c2761eb13c7b5f35bc826fe19c)
* Automatic Changelog Update (#1365)
(cherry picked from commit cc1e52c47c7b27b8da9be5da701580efe42590ca)
* Make the EE Logo Match the Banner (#1361)
# Description
Light mode logo
(cherry picked from commit 35c95a5da3ccb7d23620eaa1aad43022be3d6673)
* Loadout Modular Functions (And Loadout Pets) (#1366)
# Description
This PR implements a reflection based system for applying functions
directly to entities spawned by loadouts. In order to provide an
"Example" use of this system, I have created a "LoadoutMakeFollower"
function, which can be applied to a loadout entity that happens to be an
NPC with the Follower blackboard, making it follow the player who
purchased that loadout.
Basically. Pet mouse. The pet mouse will follow its owner.
Yes I actually have tested this ingame, and it works great. The longest
part about coding this was me spending almost 30 minutes straight
wondering why the mouse wasn't following my character, until I
remembered that I had to make a special "Pet" mouse variant that had the
right HTN root task.
This could be extended to other things. I happen to know that Nuclear14
wanted something like this for a Pet Dog.
<details><summary><h1>Media</h1></summary>
<p>
</p>
</details>
# Changelog
🆑
- add: Loadouts can now apply modular functions to items upon spawning
in.
- add: A new LoadoutMakeFollower function, which lets you buy NPC
followers in loadouts.
- add: added Pet Mice, Cockroach, Mothroach, and Hamster to Loadouts.
All of which use the new LoadoutMakeFollower function.
Co-authored-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
(cherry picked from commit 311b86e012ac7d40363b5027ab51b09c9d2285e2)
* Automatic Changelog Update (#1366)
(cherry picked from commit 18a751d5c3d53cd4ff36728dd585ada37e9175b9)
* Plushies! (#1369)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->
# Description
<!--
Explain this PR in as much detail as applicable
Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->
Added two new plushies to the game! A harpy plushie and a plushie for
the beloved station pet Morty!
---
# Changelog
<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->
🆑
- add: two new cuddly friends to the station! (harpy and morty plush)
---------
Signed-off-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
Co-authored-by: juniwoofs <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>
Co-authored-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
(cherry picked from commit 6fb12233d48de476c2b06415031fa2e9c9a1d327)
* Automatic Changelog Update (#1369)
(cherry picked from commit 5293b92007f7ca81375d9806cccf9be38846c8d3)
* Traits System Anticheat (#1358)
# Description
It turns out that there was no system in place for serverside fact
checking of whether or not people have a legal traits list. Last night a
bug was reported whereby a player used Cheat Engine to give himself
every trait in the game, bypassing the points system entirely. It's not
actually possible to reduce a trait selection down to a legal list
without creating interesting race conditions, which limits my options on
how to deal with it.
So I made it a vote on the Einstein Engines discord, and the vote was
unanimous. PUNISH THE CHEATERS.
<details><summary><h1>Media</h1></summary>
<p>
https://www.youtube.com/watch?v=X2QMN0a_TrA
</p>
</details>
# Changelog
🆑
- add: Implemented Anti-cheat for Traits. Attempting to join a round
with an illegal traits list will result in hilarious consequences.
(cherry picked from commit 2fc1f25bc0daa29e2017490adbdf41f9db4f4927)
* Automatic Changelog Update (#1358)
(cherry picked from commit 9d738c8f36c0762e0ba3942fb26ef25735ade327)
* Make Prisoner Not Shitter Role (#1341)
# Description
Prisoner is consistently the most problematic role in this entire game,
being seen as "The Self Antagging Role", which produces endless amounts
of administrative burden. This is especially a problem with lowpop
servers, or servers that are understaffed with admins. Players just join
as Prisoner, *immediately* break out of the permabrig, and then go on a
self antagging spree. The solution to this was staring us in the face
the whole time. Just give them the same Pacified component that the
Thief antag has. Now it's impossible for them to smash the permabrig
windows, someone has to intentionally let them out, and even if they do,
they will be hard pressed to selfantag when they can't turn on harm
intent.
# Changelog
🆑
- add: Prisoners now spawn with a Pacifier Implant.
(cherry picked from commit 7f8d76ea6f63d334c894fc0f7ada6fd1359408f1)
* Automatic Changelog Update (#1341)
(cherry picked from commit 68cb9ea4888c16056c6cfe9fea17de1a78420374)
* Fix Jittering (#1334)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->
# Description
<!--
Explain this PR in as much detail as applicable
Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->
Title.
Ported from https://github.com/Fansana/floofstation1/pull/393Resolves#1277
---
# Changelog
<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->
🆑
- fix: Fixed jittering displacing your character when shaken.
(cherry picked from commit a13d9640ec77e07b532b729ac540dc95b689c557)
* Automatic Changelog Update (#1334)
(cherry picked from commit bfb32cf24eda47ff3dbd5d4b15b58e25ae597947)
* Basic Soft-Crit Implementation (#1370)
# Description
This PR adds a simple server configuration option for enabling basic
"Soft-Crit", and not much else because oh my god this system is horribly
complicated. When enabled, characters can crawl around very slowly while
in crit, and really not much else. This more or less mirrors how crit
affects character movement in SS13, where you can at least crawl to
relative safety while bleeding to death.
# Changelog
🆑
- add: Added server config options for basic "Soft-Crit". When enabled,
characters who are critically injured can still slowly crawl, but are
otherwise still helpless and dying.
(cherry picked from commit dff8c69f2afff6714b893a7c9572a84bd384ff89)
* Automatic Changelog Update (#1370)
(cherry picked from commit 9430b9046a9a40cc2f96bb3c66251aabbaf9e80a)
* local upstream
* Revert "Make Prisoner Not Shitter Role (#1341)"
This reverts commit c7d0eddc96.
* RobustToolbox 237.3.0
* fix: snowball testfailing fix
---------
Co-authored-by: Skubman <ba.fallaria@gmail.com>
Co-authored-by: sleepyyapril <123355664+sleepyyapril@users.noreply.github.com>
Co-authored-by: Kyoth25f <41803390+Kyoth25f@users.noreply.github.com>
Co-authored-by: SimpleStation Changelogs <SimpleStation14@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: Blu <79374236+BlueHNT@users.noreply.github.com>
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Co-authored-by: juniwoofs <jakbroeder@gmail.com>
Co-authored-by: Remuchi <72476615+Remuchi@users.noreply.github.com>
# Description
"Walking by default" is now implemented as a client-side toggle in the
settings. Also, fixed walking alerts being shitcode and not displaying
the correct walking/running state.
One issue still persists: if you press the "toggle walk" button while
typing in the chat, it still resets the walking state to default. I
don't know what causes it, probably the input field leaking button-up
input events instead of marking them as handled.
<details><summary><h1>Media</h1></summary>
<p>
https://github.com/user-attachments/assets/97d5b495-ea9b-4854-a6b0-84815ed5a332
</p>
</details>
# Changelog
🆑
- add: You can now choose whether you want to walk or run by default in
the settings.
---------
Signed-off-by: Mnemotechnican <69920617+Mnemotechnician@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
# Conflicts:
# Content.Client/Options/UI/Tabs/KeyRebindTab.xaml.cs
# Content.Shared/CCVar/CCVars.cs
# Description
Jetpacks can now be configured via CCVar in a server's TOML file to
allow for certain behaviors that people have repeatedly asked for, and
were denied by Wizden on the basis that, "Wizden doesn't want this on
their servers". Well the request has reached my lap, and my response to
this is, "I have the power to give that choice directly to individual
servers."
Here you go. Enjoy.
This PR makes it so that jetpacks can be set in Server Configuration to
- Be usable in ANY condition, even on grids with gravity
- Be usable in zero gravity, even on grids
- Or set the 2 new CVars to false, and it'll just work like it did
before.
# Changelog
🆑
- add: Jetpacks now work in zero gravity.
- add: New CCVar "jetpack.enable_anywhere" allows server hosts to
optionally make it so that jetpacks can be used anywhere, even in
gravity and on grids.
- add: New CCVar "jetpack.enable_in_no_gravity" allows server hosts to
optionally disable jetpacks being usable in zero gravity.
# Description
Dionas now have 25% slower movement speed in exchange for total slip
immunity and slow immunity (except lying down).
Note that this also prevents slowdowns from hunger and thirst.
This also fixes an existing bug with Sluggish and Snail-Paced related to
`TraitSpeedModifierSystem`, as it was not applying the reduced movement
speed upon spawning, only when the movement speed has been modified by
another source. `TraitSpeedModifierSystem` has been moved from
`Content.Server` to `Content.Shared`.
This used to be a trait costing 3 points, but is now given for free to
all Dionas per request of @VMSolidus.
## Media
<details><summary>Expand</summary>
**Speed with no items**
**Speed wearing a jugsuit, wearing a duffel bag, holding one duffel bag
in each arm, and walking through a puddle of glue covered in spider
webs.**
</details>
# Changelog
🆑 Skubman
- add: Dionas have been given a 25% slower movement speed. In exchange
for that, they gain absolute slip immunity and movement speed modifier
immunity. This makes them immune to slowdown from things like
duffelbags, hardsuits, and spider webs.
- fix: Sluggish and Snail-Paced will now properly apply their movement
penalties upon joining.
# Description
**Light Step** is a 1-point Auditory trait that reduces the volume of
your footsteps by roughly 50%, enabling you to be quieter and
stealthier. Inspired by the SS13 trait of the same name.
## TODO
- [x] Locale strings
- [x] ~~Reduce the distance in which Light Step footsteps can be heard~~
- It turns out that whatever I did reduced the delay between footstep
sounds.
- [x] Discuss the balancing values for the trait
## Technical details
In the current implementation, Light Step reduces the volume of
footsteps by 10 dB, resulting in roughly halving the volume.
The fields in `FootstepVolumeModifierComponent` change the volume in
terms of decibels.
## Media
# Changelog
🆑 Skubman
- add: Add the Light Step trait, a 1-point trait that makes your
footsteps quieter.
---------
Signed-off-by: Angelo Fallaria <ba.fallaria@gmail.com>
# Description
Ports
https://github.com/Simple-Station/Parkstation-Friendly-Chainsaw/pull/39
A change made to encourage people to [stop and smell the
roses](https://www.urbandictionary.com/define.php?term=slow+down+and+smell+the+roses),
instead of sprinting everywhere trying to get shit done.
This goes well with #486, so people don't actually *have* to rush places
to try to get things done before the shift ends fatally.
It's weird anyway how we're all constantly sprinting everywhere and have
to *very actively* choose not to (and why would you?).
Increases the default speeds so that walking isn't painfully slow and
sprinting feels more like sprinting in combination with the active
choice to sprint.
Someone needs to PR changing the default sprint or examine buttons, so
people can fight and sprint with this change.
(A lot of other default keybinds suck or conflict too and need to
change)
# Media
Terrible video but whatever
https://github.com/user-attachments/assets/5ff3863d-92c8-4df3-b76b-82874b5e1ae3
# Changelog
🆑
- tweak: The station's crew hivemind has decided to slow down their
movement and enjoy The Park instead of sprinting everywhere
---------
Signed-off-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Co-authored-by: Pspritechologist <81725545+Pspritechologist@users.noreply.github.com>
# Description
First PR. Adds an alert on the user UI whenever they toggle between
walking or running. No more second guessing whether you will slip or not
when walking over that puddle of water, or if your usage of Shift on
chat toggled your movement speed.
The alert is displayed for entities with the component
'CanWalkComponent', which is added to the following prototypes:
- All genetic ancestors (MobBaseAncestor)
- Human controlled mechs (BaseMech, wont display on VIMs or HAMTRs
because rats or hamsters can't walk, and the edge case is not worth the
trouble)
- All human/player species (BaseMobSpeciesOrganic)
- All slimes/geras (BaseMobAdultSlimes)
- Reagent Slimes (ReagentSlime)
- Rat Kings (MobRatKing - yes they can fucking walk lmao)
- Borgs (BaseBorgChassis)
---
<details><summary><h1>Media</h1></summary>
<p>
https://github.com/Simple-Station/Einstein-Engines/assets/159397573/1a60711b-d048-444d-bd08-6a9eadeccc8a
</p>
</details>
---
# Future Stuff
I also wanted to make it toggle the user's speed on click like it would
in ss13, but sadly the majority of the input management/prediction seems
to be done exclusively client-side, making it a hassle to work around
the alert. **Will revisit if there's improvements or refactors to the
movement code.**
---
# Changelog
🆑
- add: Added an alert on the UI for when the user is walking or running.
---------
Signed-off-by: gluesniffler <159397573+gluesniffler@users.noreply.github.com>
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
# Description
Adds more zoom levels and CVars to configure them.
The defaults make it so that the new minimum zoom is roughly equal to
what ss14 had before (29.6%).
# Why
Playing as a tiny character made me love having the screen zoomed in,
but having only 3 zoom levels didn't quite allow to set the zoom level
to what I wanted. This PR fixes that.
<details><summary><h1>Media</h1></summary><p>
https://github.com/user-attachments/assets/61e56913-1c9d-4590-95ac-686018b5caa9
</p></details>
# Changelog
🆑
- add: You can now configure your zoom more precisely.
## Mirror of PR #26287: [Code cleanup: Purge obsoleted
SharedPhysicsSystem
methods](https://github.com/space-wizards/space-station-14/pull/26287)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `964c6d54caae45b205a326143f56d6458a1bbc8a`
PR opened by <img
src="https://avatars.githubusercontent.com/u/85356?v=4" width="16"/><a
href="https://github.com/Tayrtahn"> Tayrtahn</a> at 2024-03-20 13:37:25
UTC
---
PR changed 16 files with 43 additions and 43 deletions.
The PR had the following labels:
- Status: Needs Review
---
<details open="true"><summary><h1>Original Body</h1></summary>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> Requires https://github.com/space-wizards/RobustToolbox/pull/4979
>
> ## About the PR
> <!-- What did you change in this PR? -->
> Cleans up some obsolete method calls.
>
> ## Why / Balance / Technical
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> Cleaning up obsolete Dirty calls in RT required changing the
signatures of some public methods in SharedPhysicsSystem. This updates
the calls to those methods here in Content to use the new signatures
passing in UIDs.
>
>
</details>
Co-authored-by: SimpleStation14 <Unknown>
* Use new Subs.CVar helper
Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.
This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.
* Fix a bunch of warnings
* More warning fixes
* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.
* Get rid of some more ISerializationHooks for enums
* And a little more
* Apply suggestions from code review
Co-authored-by: 0x6273 <0x40@keemail.me>
---------
Co-authored-by: 0x6273 <0x40@keemail.me>
(cherry picked from commit 68ce53ae17985876d6d112b764b2144964a9f42e)
* Felinid changes.
A plan
* Just slappin it together
for a friend to see and help
* Somethin somethin
Cos I could be at yours on friday
Tonight's at the place we started
It's a long way back from sorry
But here I go ....
How does it feel, how does it feel
Just tell me something
I don't know what to tell you
I don't know what to say
I got into my head, i'm sorry i threw it away
But i'm so glad you came back, even through all the pain
Let me try and mend it, i can promise that i have changed
Oh, let me give you all of me
Can we just sort it out for real
* just makin this less messy.... I guess
* Just tell me somethin.
How does it feel, how does it feel.
* .
* cleaning....
* Makes it work. Yey.
* just a small change tbh.
* okay maybe just a bit.
* Hm, maybe....
* This feels bit better.
* hopefully fixes yaml linter
* Update Resources/Prototypes/Nyanotrasen/Entities/Mobs/Species/felinid.yml
Co-authored-by: Debug <49997488+DebugOk@users.noreply.github.com>
Signed-off-by: Adrian16199 <144424013+Adrian16199@users.noreply.github.com>
* Doin the changes.
* Renaming.
* Renaming notes.
---------
Signed-off-by: Adrian16199 <144424013+Adrian16199@users.noreply.github.com>
Co-authored-by: Debug <49997488+DebugOk@users.noreply.github.com>
* Add sprite movement states
Did it for borgs for reference for future implementations.
* Fix
* Fix prediction issue
* review
(cherry picked from commit 9a40cf81f55722083a985e4cdddda9c6008beb08)
* added TileAnomalySystem to AnomalyIce
* added FloorIce for station
* created ice crust entity to spawn under ice anomaly
* update draw depth for ice crust
* uh oh, added ice-sliding but at what cost
* resolved mispredicts
* updated sprite alpha, removed appearance component (not used)
* fixed function not reflecting event name, left datafield attributes blank, added one comment about saving data (?)
---------
Co-authored-by: Yurii Kis <yurii.kis@smartteksas.com>
