<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->
# Description
<!--
Explain this PR in as much detail as applicable
Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->
Previously, the "TryStopPull" function didn't make you drop a
virtualitem if you were strangling somebody, meaning that you could lose
use of a hand until disarmed because it would still consider you to be
holding the person. I fixed that, as well as additionally cleaned up the
table slam system, which should make it run a bit smoother and be
functionally about the same. The "tableable" and "posttabled" components
were removed, because they shouldn't have existed in the first place.
The only notable non-bugfix change that's player facing is that shoving
people who are knocked down on any climbable entity stuns them (as
opposed to just tables), but it's a rather minor change and I intend on
reworking it pretty heavily once my [other
PR](https://github.com/Simple-Station/Einstein-Engines/pull/2199) is
reviewed. On the backend, I added an optional variable to "TryClimb"
that gives you an option to skip the do-after. If it's possible to
change these actions to be predicted, I'd be interested in learning how.
---
# TODO
<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->
- [ ] Task
- [x] Completed Task
---
<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->
<details><summary><h1>Media</h1></summary>
<p>
Note that glass tables do much more damage when slammed into, and even
more if they would shatter when attempting to climb it.
https://github.com/user-attachments/assets/bc0a12e3-0b67-4d61-aa4e-785e3210c3bb
</p>
</details>
---
# Changelog
<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->
🆑
- tweak: Table slamming should be more consistent.
- fix: You should properly be able to use both hands after letting
somebody go from a stranglehold.
* Station AI overlay
* implement
* Bunch of ports
* Fix a heap of bugs and basic scouting
* helldivers
* Shuffle interactions a bit
* navmap stuff
* Revert "navmap stuff"
This reverts commit d1f89dd4be83233e22cf5dd062b2581f3c6da062.
* AI wires implemented
* Fix examines
* Optimise the overlay significantly
* Back to old static
* BUI radial working
* lots of work
* Saving work
* thanks fork
* alright
* pc
* AI upload console
* AI upload
* stuff
* Fix copy-paste shitcode
* AI actions
* navmap work
* Fixes
* first impressions
* a
* reh
* Revert "navmap work"
This reverts commit 6f63fea6e9245e189f368f97be3e32e9b210580e.
* OD
* radar
* weh
* Fix examines
* scoop mine eyes
* fixes
* reh
* Optimise
* Final round of optimisations
* Fixes
* fixes
(cherry picked from commit d8ae58efa903749314e334278c1a47c0fddd2b16)
# Description
**Parkour Training** is a 3-point Physical trait that increases your
table climbing speed (and all other climbables), and crawling speed, and
reduces the cooldown on laying down/standing up.
Inspired by the SS13 trait called Freerunning, expanding on it by
including new mechanics around the Laying Down system.
Stats (Adjustable):
- 30% faster table climbing speed
- 25% faster crawling speed
- Cooldown on laying down/standing up reduced from 2.5 seconds to 2
seconds
## Media
# Changelog
🆑 Skubman
- add: Add Parkour Training, a 3-point trait that makes you faster with
climbing tables and crawling.
---------
Signed-off-by: Angelo Fallaria <ba.fallaria@gmail.com>
## Mirror of PR #24977: [Fix bypassing vaulting clumsy check with verb
action.](https://github.com/space-wizards/space-station-14/pull/24977)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)
###### `225bc3c5aeffbef6286b607b02cd24a8ad75a437`
PR opened by <img
src="https://avatars.githubusercontent.com/u/85356?v=4" width="16"/><a
href="https://github.com/Tayrtahn"> Tayrtahn</a> at 2024-02-05 21:32:50
UTC
---
PR changed 7 files with 101 additions and 39 deletions.
The PR had the following labels:
- Status: Needs Review
---
<details open="true"><summary><h1>Original Body</h1></summary>
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
>
> ## About the PR
> <!-- What did you change in this PR? -->
> Stops clumsy characters being able to climb/vault onto tables and such
by using alt-click or the verb menu instead of drag-dropping.
>
> This also fixes a separate bug where, when a clumsy character managed
to pass the bonk check, the action would just cancel and the character
didn't actually climb the object. Passing the check will now let the
character climb.
>
> Additionally, this fixes a oddity where the ability for mobs to climb
was determined by whether or not they had feet/legs, which was arbitrary
and problematic for creatures like slimes (which should be able to ooze
up onto a table). This check could also be bypassed by using the verb
instead of drag-dropping, so that was fixed too. The ability for mobs to
climb is now controlled in the prototypes.
>
> The default chance of a clumsy character bonking on a climbable has
also been reduced from 75% to 50% to compensate somewhat.
>
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> Fixes#24951
> Fixes#17423
> Fixes#25951
>
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> ClimbSystem now raises AttemptClimbEvent as part of TryClimb, and
aborts climbing if it gets cancelled. This makes sure that all code
paths go through a clumsy check. BonkSystem now listens for
AttemptClimbEvents and responds to them instead of trying to intercept
DragDropEvents.
> CanVault now gets checked in TryClimb as well, to prevent bypassing
it.
>
> The logic for climbing capabilities is now:
> - The presence of ClimbingComponent makes an entity able to be placed
on surfaces like tables.
> - ClimbingComponent.CanClimb controls whether it can climb onto
surfaces by drag-drop or verb.
>
> The new field defaults to true to minimize changes to existing
behavior. Some mobs will have gained the ability to climb when
previously they couldn't, but that should be less impactful than the
opposite and can be resolved by YML changes in the future.
>
> ## Media
> <!--
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
>
> If you're unsure whether your PR will require media, ask a maintainer.
>
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
>
>
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
>
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 🆑
> - fix: Clumsy characters can no longer avoid bonking their heads by
using the Climb verb.
> - tweak: Clumsy characters are less likely to bonk their heads when
trying to climb.
</details>
Co-authored-by: SimpleStation14 <Unknown>
Also includes some (non critical) changes to the solution file to re-organize the Roslyn components.
(cherry picked from commit e00f74505c62310bd15aeaba8d6530f648397074)
* Cryogenic sleep units
* pause map support
* no more body deletion
* Cryogenic Storage Units
* boowomp
* no more emag, no more dropping present people
(cherry picked from commit 736b9dd7df6e35f07fed88686c7c863ac61af846)
