Commit Graph

8500 Commits

Author SHA1 Message Date
Mervill
4265b4a052 Replace obsolete functions in NPC systems (#31448)
(cherry picked from commit e85c25a7468b4daea7a5f1deb85900a9151651cf)
Signed-off-by: Spatison <137375981+Spatison@users.noreply.github.com>
2025-07-20 15:10:33 +10:00
osjarw
0226a6843f NPC exits MeleeOperator on invalid EntityUid (#30005)
EntityUid 0 problem fix

(cherry picked from commit 922be642904ede5988835a9143357d47be731b8d)
2025-07-20 15:10:32 +10:00
Tayrtahn
3e6d3856de Fix followers getting sent to nullspace when target is polymorphed (#33878)
* Add an event for polymorph actions

* Subscribe FollowerSystem to the event

* Add check that unfollow target is actually current target.

* Make followers try to follow on state update; Dirty follower on follow.

(cherry picked from commit 46b19291eae7311c3ee946e45432f0552328792d)
2025-07-20 15:08:44 +10:00
MilenVolf
8643496b9a Localize planet dataset names (#33398)
* Localize planet names (borer)

* DatasetPrototype -> LocalizedDatasetPrototype

* Apply requested changes

(cherry picked from commit 2002de9bb01e53e70b00fea5b3f4ffeed55a3cfa)
Signed-off-by: Spatison <137375981+Spatison@users.noreply.github.com>
2025-07-20 15:06:47 +10:00
DrSmugleaf
291f95c0c3 Move PlayerBeforeSpawnEvent and PlayerSpawnCompleteEvent to Shared (#33428) 2025-07-20 14:59:18 +10:00
ScarKy0
0fab35bb11 Ion storm refactor (#33311)
Signed-off-by: Spatison <137375981+Spatison@users.noreply.github.com>
2025-07-20 14:58:55 +10:00
BIGZi0348
2f700868e0 Moved hardcoded string "PEOPLE" to Loc.GetString() (#32164)
(cherry picked from commit 20914fea367289c36e9988f6c22ec802a74065b8)
2025-07-20 14:54:33 +10:00
Zachary Higgs
04fda905d8 Add Silicon Law cues to Every method a Silicon can have their laws change (#32887)
* Silicon Law Sound cue refactor

- Added CueEntityMind to Silicon Law system to more uniformally
send sounds to minds

- Switch all previous MindPlaySound to instead call to the new method

* Change SiliconLawEui to cue the mind

* CR: TryGetComponent and Change the Documentation

- Remove GetComponentOrNull for  _entityManager.TryGetComponent

- Change SiliconLawProviderComponent.LawUploadSound to be more general
rather than just referencing lawboards

* Update Content.Server/Silicons/Laws/SiliconLawEui.cs

* Update Content.Shared/Silicons/Laws/Components/SiliconLawProviderComponent.cs

* Silicon-law-cue-refactor - CR:

- Roll the cuing into NotifyLawsChanged via an optional variable for the
cue

- Modify "SetLaws" to take in an optional soundProvider for the cue

- modify Emagged, Ion, Eui and SetLaws to instead send the sound cue via
NotifyLawsChanged

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

(cherry picked from commit a3f10ccfbb01616d08559950b5de4dc1c6df7f6d)
2025-07-20 14:54:20 +10:00
nikthechampiongr
2b729395ef Rename fix (#31654)
* Localize RenameCommand and delegate most of the process to MetaDataSystem.SetEntityName()

* Make renaming rely on the EntityRenamedEvent. Fix issue where renaming would keep old Examine text

Requires engine change

* Fix localisation strings

* Make PDA search be based on a renamed entity's Uid instead of its old name

To do this the pda component now has an PdaOwner field which gets
assigned when it is given as a loadout to a player

* Fix bad merge???

huh

* Use AllEntityQuery

(cherry picked from commit ee434e397d483c10b1dbf29e736de6a134e82746)
2025-07-20 14:50:45 +10:00
deltanedas
6a233e8683 fix id card console not updating records (#28237)
* fix id card console not updating records

* test

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
(cherry picked from commit 37ad81c59ca04b10cdc420eb66ae7a9487ecdfaf)
2025-07-20 14:50:45 +10:00
lzk
f87b1dc280 Special latejoin message for captain (#31991)
* Special latejoin message for captain

* fix gender in locale

* remove this for now

* shame

* not really shame

* change

* do that

(cherry picked from commit f2b67fc76b5b3f68fd4dd39691710d1f425f3178)
2025-07-20 14:50:37 +10:00
Pieter-Jan Briers
0aadba0f72 I have spent more time today cleaning up garbage than coding new shit, and I am mad (#31246)
* Fix logging of GetWebhook errors

Yeah let's just not log the error only stack trace.

* I have spent more time today cleaning up garbage than coding new shit, and I am mad

Cleans up the custom vote Discord webhook code because I *happened* to lay my eyes on how completely terrible it was and immediately found an obvious bug with it.

Also did basic QA because jesus christ: it more clearly reports pending votes, properly indicates cancelled votes, improves footer formatting, better error logging, all the usual shit.

Requires https://github.com/space-wizards/RobustToolbox/pull/5375 to avoid test failures

(cherry picked from commit 582a644c243d1c0a0ff660933e811b89024597f6)
2025-07-20 14:48:27 +10:00
Pieter-Jan Briers
9ee3fc053a Don't create new JsonSerializerOptions for every discord webhook (#31240)
*sigh*

(cherry picked from commit d63115d1f76ecbee0618b93a196ff57f49be816f)
2025-07-20 14:48:26 +10:00
Jacob
d58d615533 Add failure logging to DiscordWebhook.cs (#30835)
* Add failure logging to DiscordWebhook.cs

Add a new function that logs errors with discord webhook's http requests.

Create, Delete, and Edit functions were modified slightly to call the log function but return the same information as before.

The log function logs the error code, caller method using a simple constant (could be better), and attempts to log headers mentioned in issue #30248.

* remove extra ';'

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Move header error logs to debug

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
(cherry picked from commit beb86fa0fec95798ecc3811a93efad3b6675ef93)
2025-07-20 14:48:26 +10:00
lzk
56f4eb6d3d Fix cryo locale again (#32654)
* Fix cryo locale again

* yeep

(cherry picked from commit 33042b00d0fa64e2880acecd7430c425caf3e8f4)
2025-07-20 14:48:25 +10:00
lzk
41e44fdcbb fix conjugate have in cryo locale string (#31993)
(cherry picked from commit e490b69b4e4fd49f6fecf7a1e066fab1c7a1e630)
2025-07-20 14:48:24 +10:00
Eris
eefbd9970d no risks taken. 2025-07-20 14:39:34 +10:00
Eris
3bc325e74b s 2025-07-20 14:39:33 +10:00
Eris
d1abb827ae h 2025-07-20 14:39:25 +10:00
Eris
75a463cf5d Saving changes 1 2025-07-20 14:37:13 +10:00
Eris
110e22aa2f a 2025-07-20 14:25:39 +10:00
Thomas
65fca27321 Disable Arrivals message for Cryosleep (#30888)
* Disable arrivals message for cryosleep late arrivals

* Provide silent to PlayerSpawnCompleteEvent

* Fix typo

* Move message to event and into arrivals system
2025-07-20 14:22:55 +10:00
PursuitInAshes
035c316591 Change Resave Permission Requirement to Host (#31397)
ChangePermissionFlagToHost

(cherry picked from commit c1aee02c7439daec2e2b302cd4023acd17a80a1d)
2025-07-20 14:22:53 +10:00
AsnDen
87f6fcc234 AI now "can" use media console (#32334)
(cherry picked from commit 72acce520070056432058bf430152bd542d1802c)
2025-07-20 14:22:52 +10:00
nikthechampiongr
04d5f5b5ad Fix RA0032 (#32514) 2025-07-20 14:22:41 +10:00
Mervill
57f4465934 Fix warnings related to non-exhaustive pattern matching. (#31763)
old man shakes fist at modern syntax

(cherry picked from commit de13ff96639d8da5ca45b214e0c4df5ebf20856a)
2025-07-20 14:20:14 +10:00
deltanedas
74f2623bae fix ninja hacking not affecting sechud (#28021)
minor refactor and fix

Co-authored-by: deltanedas <@deltanedas:kde.org>
(cherry picked from commit b453b9414810ed927228eb563c6b1c491532c5e3)
2025-07-20 14:20:12 +10:00
Nemanja
dd4b3a4150 PA ui cleanup + bugfixes (#28750)
* ui and visual aspect + radio

* finish jank ui shit and finish radio

* remove radio

* send it

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
(cherry picked from commit 0b5fe2a9acdc6b324dce7f45f6839f780223202e)
2025-07-20 14:20:11 +10:00
Partmedia
e93f886ff7 Update PA admin warnings (#28911)
With singulo fixed, PA strength 3 and below (level 2) are now safe.
Update the admin logging to reflect this.

(cherry picked from commit dc0327c3c0c7834823aeaf7e11eef6993e5fdc77)
2025-07-20 14:20:11 +10:00
themias
fed8b840c3 Save unpublished news articles (#31491)
* Add draft saving to news consoles

* fix after bui changes

* comments + rename vars

* no

(cherry picked from commit ec4d59f6088ecc14b9231d51df18a4a4334d28ff)
2025-07-20 14:20:10 +10:00
nikthechampiongr
5e5a7d2beb Fix suicide logs (#31661)
Make suicide logs include the username, as well as the character(where possible)

(cherry picked from commit 99db9ea39d3abfd896a081b6f58f142b8ef9fc25)
2025-07-20 14:20:09 +10:00
slarticodefast
0c4284b717 fix the admin verbs trying to kill players by filling their lungs with plasma (#30991)
fix the admin tools trying to kill players by filling their lungs with plasma

(cherry picked from commit 8cb2cfc0afdbee6b3745c3c37c292bcef8da28bd)
2025-07-20 14:20:09 +10:00
metalgearsloth
5ab011513f Add access to gun components (#30688)
* Add access to gun components

Found from an rmc14 PR.

* Admin verbs proving why access needs to exist

* Someone is probably going to post this pr to le reddit and complain about self-merges.

(cherry picked from commit 1649ed45bd395c850bd531752f7146ca073b04cd)
2025-07-20 14:20:00 +10:00
Leon Friedrich
a764d5235a Make NetworkConfigurator use BoundUserInterfaceCheckRangeEvent (#28293)
(cherry picked from commit b177fb8179eaf7a3b1c9fc9dabe36835e582cd06)
2025-07-20 14:18:36 +10:00
metalgearsloth
06474f6316 Fix PostMapInit tests not considering job containerspawns (#31538)
* Fix PostMapInit tests nto considering job containerspawns

* fix

(cherry picked from commit 99a41a12ab05ccb477ebe54f7d265666dc607be1)
2025-07-20 14:18:36 +10:00
Brandon Hu
b17cfa6ecf fix(Commands): Improve Localization of commands. Standardize some behaviors. (#30362)
* I should be studying for school but that is sofucking boring, I will pass my class no matter, however getting an A might be a challenge. My gpa is important but is the tourture for 1 point of GPA worth it? The american government says yes but they are responsible for the majority of all genocides that have ever been conducted since the dawn of man

* ugh

* ugh

(cherry picked from commit 31c5d3555ea97e6f6a317c5b208763e4f12a67c6)
2025-07-20 14:18:35 +10:00
Repo
00e173e2b2 Fix late join & observe to de-admin admins. (#28319)
(cherry picked from commit eb3f27526bc8748a45c3f56de97a982747e51842)
2025-07-20 14:18:35 +10:00
SpeltIncorrectyl
69b65ec514 Mime can no longer write on paper without breaking their vow (#35043)
Co-authored-by: Simon <63975668+Simyon264@users.noreply.github.com>

(cherry picked from commit e86770f5a03231e3189920c5d7ad93542d48e922)
2025-07-20 14:18:34 +10:00
Ed
4ff8981876 Localize tips (#28285)
* localize tip

* localizzedDataset

(cherry picked from commit a1bcaf58973d1b15ced827ee50bae724339d1ec0)
2025-07-20 14:18:31 +10:00
SlamBamActionman
e3259c077e Add a Walking alert (#32954)
* Initial commit

* Review feedback changes

* ProtoId

* TempCommit

* First attempt to have client alerts

* Review changes

(cherry picked from commit 1e368ae30076606501332f34ab786c14e25c477a)
2025-07-20 14:17:46 +10:00
Errant
d33556daf1 movercontroller namespace (#31749)
(cherry picked from commit 1c6b9aaae7b2dd64ca7e53aeeeb8ebb1438adb4a)
2025-07-20 14:14:34 +10:00
CheddaCheez
03462163df Fix mime broken vow alert (#33303)
Swap VowAlert and VowBrokenAlert on lines 149 and 150 so that the proper alerts are cleared and shown

(cherry picked from commit 815e37e512ce7d1df152bac1642b769cf3e9bb32)
2025-07-20 14:14:32 +10:00
Winkarst
4fe82b22f6 Move OnGhostAttempt to GhostSystem (#31445)
* Move OnGhostAttempt to GhostSystem

* Remove unused dependencies and sort them

(cherry picked from commit 2d85b4e7e9d5d37f4ebd3c4ffd249dc6381efad6)
2025-07-20 14:14:24 +10:00
lzk
b84039f7c5 Fix GhostCommand naming (#29671)
(cherry picked from commit 58d46ddd46c250a4df283638c3ba0295cae26194)
2025-07-20 14:12:41 +10:00
Errant
ca02358347 Aghosts can now /ghost (#29360)
I will not be subjected to criminal abuse

(cherry picked from commit 49128ba9d3492e41f64a3ad12f40226015a22387)
2025-07-20 14:12:41 +10:00
DrSmugleaf
562ea14e83 Add cvar to disable ghosting killing your crit mob (#28945)
* Add cvar to disable ghosting killing your crit mob

* Update Content.Shared/CCVar/CCVars.cs

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

(cherry picked from commit 4954b6d79e194a4dd8b7f2d9942fa707e259493d)
2025-07-20 14:12:40 +10:00
Leon Friedrich
302baba768 Fix AudioSystem nullability checks for engine PR (#32233) 2025-07-20 14:08:48 +10:00
Pieter-Jan Briers
de98315595 Extend shuttle dock time if the shuttle doesn't dock at evac. (#31496)
* Extend shuttle dock time if the shuttle doesn't dock at evac.

If the shuttle can't dock at evac for *some reason*, it will instead try to dock at another port on the station. And if that fails it goes somewhere random on the station.

Because of the chaos and confusion caused by this, many people will frequently not get to the shuttle in time under these circumstances. This sucks for everybody.

To alleviate this, the shuttle launch timer will now be extended if the station doesn't dock at its ideal spot. The default values (controlled via CVar) are 1.667x and 2x respectively for "wrong dock" and "no dock at all" scenarios.

The code around here was a mess, so I fixed that too. "CallEmergencyShuttle" has been renamed to "DockEmergencyShuttle", the overload that did the actual docking has been renamed to DockSingleEmergencyShuttle. Code has been split into separate dock -> announce methods so we can calculate shuttle delay in between the case of multiple stations.

Also made the "shuttle couldn't find a dock" text announce the time until it launches and fix the shuttle timers not triggering for it.

* Minor review
2025-07-20 14:08:47 +10:00
IProduceWidgets
ddbfb5aa59 Centcom & FTLDestination cleanup (#30226)
* centcomm name and ftlcomp

* networking microopstimization

* go sleep.

* map names and arrivals

(cherry picked from commit af65af836a319e5481929a3a6ef19ca719a5c0eb)
2025-07-20 14:08:45 +10:00
Mervill
c9918f33fe Replace obsolete code in shuttle systems. (#31408)
* Format DockingSystem.Shuttle

* arrivals system

* docking system

* shuttle console system

* emergency shuttle system

* shuttle system

* thruster system

* Fix compile error
2025-07-20 14:08:44 +10:00