This re-introduces the dummy entity naming code, originally introduced in #29178 and randomly removed by #30064 with no technical justification given.
Fixes#31373
(cherry picked from commit d15869f6007b2c772380c023153bfbfd264a328a)
* Make vendor machines use EntityPrototypeView
* Update
* 1
* Kill me
* For the love of god!!!
(cherry picked from commit 588661465a2ede2610bed4dbb440131122e74a6f)
* Spawn dummy entities on client for vending machine UI
* Asked sloth, and we kinda need this pr
---------
Co-authored-by: Vasilis <vasilis@pikachu.systems>
(cherry picked from commit ac1bdd2c840a126b9f5114440b6b26c08c7ea0c4)
# Description
This PR removes label duplicates from item names in order to make actual
labels work properly and make them visible in vending machines' menus as
well as loadout preferences.
As we can see in Fig 1, the aluminium jug is not only labelled as
"aluminium 10u" but contains "(aluminium 10u)" in the item name, which
drives chemists homicidal when it comes to labelling the jugs.
This issue also appears with other labelled items such as pill canisters
in item preferences (see Fig 2), which led to a row of nameless pill
canisters being present in our server's menu.
My solution is to fetch the item's LabelComponent in the menu so this
redundancy is no more needed.
See Fig 3 for an example.
The VendingMachineMenu.xaml.cs code fetches and localizes the text from
the LabelComponent from the prototype the same way it fetches sprites,
and in the LoadoutPreferenceSelector.xaml.cs the task is pretty
straightforward since the item is spawned in the Nullspace anyway.
---
- [x] Added label rendering for VendingMachineMenu.xaml.cs
- [x] Stripped reagent jugs' names off their fake labels
- [x] Added label rendering for LoadoutPreferenceSelector.xaml.cs
- [x] Stripped pill canisters' names off their fake labels
- [x] Reformatted pills *that do not have explicit descriptions* to
match "pill (label)" format
---
<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->
<details><summary><h1>Media</h1></summary>
<p>
Fig 1, the issue with ChemVend's reagent jugs:
Fig 2, the issue with pill canisters:
Fig 3, demonstration of the solution:
</p>
</details>
---
# Changelog
🆑 NeLepus
- add: Added label rendering for vending machines & item preferences
- tweak: Formatted pill without descriptions to follow "pill (label)"
- remove: Fake label duplicates in reagent jugs and pill canisters
(cherry picked from commit f0f9512b491fefa2416f661e8f6b20fab215fa2f)
* Cleans up disposal unit yaml and fixes inability to throw things in them.
* Comments out mailing units because they are beyond broken and need a refactor.
* Makes Disposal UI look better
* Localized the disposal unit
* Removes title line
* Removes changes to VendingMachineMenu, mistakenly committed.
* Applies code reviews
* Now uses BaseMachinePowered
* Engine namespace changes.
* Automated remove redundant using statements.
* Simplified Graphics namespace.
* Apparently the container system stores full type names in the map file.😞 This updates those names.
* API Changes to LocalizationManager.LoadCulture.
* Update submodule to v0.3.2
* Non-accessed local variable
* Merge cast and type checks.
* StringComparison.Ordinal added for better culture support
* Supposed code improvement in launcher. Remove unused code.
* Update ExplosionHelper.cs
Unintentional change.
* Optimized Import
* Add Robust.Shared.Utility import where it was deleted
* Other random suggestion
* Improve my comment
