Remove Vector assets and renames Vector SMG magazines (#34603)

* remove vector and assets

* reverts vector magazine removal; vector magazines renamed to SMG magazine (.45 magnum)

* remove vector from suspicion loot table

* vector migration set to null

(cherry picked from commit e9c033888476b5a8d628a10d3a2459cf355852a8)

Resources/Prototypes/Catalog/Fills/Boxes/ammunition.yml

@@ -56,11 +56,12 @@
       - id: MagazineLightRiflePractice
         amount: 4
 
+# Magnum
 - type: entity
-  name: box of Vector magazines
+  name: box of SMG .45 magnum magazines
   parent: BoxMagazine
   id: BoxMagazineMagnumSubMachineGun
-  description: A box full of Vector magazines.
+  description: A box full of SMG .45 magnum magazines.
   components:
   - type: StorageFill
     contents:
@@ -68,10 +69,10 @@
         amount: 3
 
 - type: entity
-  name: box of Vector (practice) magazines
+  name: box of SMG .45 magnum (practice) magazines
   parent: BoxMagazine
   id: BoxMagazineMagnumSubMachineGunPractice
-  description: A box full of Vector (practice) magazines.
+  description: A box full of SMG .45 magnum (practice) magazines.
   components:
   - type: StorageFill
     contents:

Resources/Prototypes/Entities/Objects/Weapons/Guns/Ammunition/Magazines/magnum.yml

@@ -16,7 +16,7 @@
 
 - type: entity
   id: BaseMagazineMagnumSubMachineGun
-  name: "Vector magazine (.45 magnum)"
+  name: SMG magazine (.45 magnum)
   parent: BaseItem
   abstract: true
   components:
@@ -130,6 +130,7 @@
     - state: mag-1
       map: ["enum.GunVisualLayers.Mag"]
 
+
 - type: entity
   id: MagazineMagnumShrapnel
   name: pistol magazine (.45 magnum shrapnel)
@@ -146,7 +147,7 @@
 
 - type: entity
   id: MagazineMagnumSubMachineGunEmpty
-  name: "Vector magazine (.45 magnum any)"
+  name: SMG magazine (.45 magnum any)
   suffix: empty
   parent: BaseMagazineMagnumSubMachineGun
   components:
@@ -159,7 +160,7 @@
 
 - type: entity
   id: MagazineMagnumSubMachineGun
-  name: "Vector magazine (.45 magnum)"
+  name: SMG magazine (.45 magnum)
   parent: BaseMagazineMagnumSubMachineGun
   components:
   - type: BallisticAmmoProvider
@@ -173,7 +174,7 @@
 
 - type: entity
   id: MagazineMagnumSubMachineGunPractice
-  name: "Vector magazine (.45 magnum practice)"
+  name: SMG magazine (.45 magnum practice)
   parent: BaseMagazineMagnumSubMachineGun
   components:
   - type: BallisticAmmoProvider
@@ -187,7 +188,7 @@
 
 - type: entity
   id: MagazineMagnumSubMachineGunUranium
-  name: "Vector magazine (.45 magnum uranium)"
+  name: SMG magazine (.45 magnum uranium)
   parent: BaseMagazineMagnumSubMachineGun
   components:
   - type: BallisticAmmoProvider
@@ -201,7 +202,7 @@
 
 - type: entity
   id: MagazineMagnumSubMachineGunPiercing
-  name: "Vector magazine (.45 magnum armor-piercing)"
+  name: SMG magazine (.45 magnum armour-piercing)
   parent: BaseMagazineMagnumSubMachineGun
   components:
   - type: BallisticAmmoProvider

Resources/Prototypes/Entities/Objects/Weapons/Guns/SMGs/smgs.yml

@@ -275,61 +275,6 @@
     - 0,0,5,1
   # WD EDIT END
 
-#Commented out the Vector, as it is deprecated.
-# - type: entity
-#  name: Vector
-#  parent: BaseWeaponSubMachineGun
-#  id: WeaponSubMachineGunVector
-#  suffix: Deprecated use Drozd
-#  description: An excellent fully automatic Heavy SMG. Uses .45 magnum ammo.
-#  components:
-#  - type: Sprite
-#    sprite: Objects/Weapons/Guns/SMGs/vector.rsi
-#    layers:
-#      - state: base
-#        map: ["enum.GunVisualLayers.Base"]
-#      - state: mag-0
-#        map: ["enum.GunVisualLayers.Mag"]
-#  - type: Clothing
-#    sprite: Objects/Weapons/Guns/SMGs/vector.rsi
-#  - type: Gun
-#    fireRate: 6
-#    selectedMode: FullAuto
-#    soundGunshot:
-#      path: /Audio/Weapons/Guns/Gunshots/atreides.ogg
-#    availableModes:
-#    - FullAuto
-#    fireOnDropChance: 0.1
-#  - type: ItemSlots
-#    slots:
-#      gun_magazine:
-#        name: Magazine
-#        startingItem: MagazineMagnumSubMachineGun
-#        insertSound: /Audio/Weapons/Guns/MagIn/smg_magin.ogg
-#        ejectSound: /Audio/Weapons/Guns/MagOut/smg_magout.ogg
-#        priority: 2
-#       whitelist:
-#          tags:
-#            - MagazineMagnumSubMachineGun
-#      gun_chamber:
-#        name: Chamber
-#        startingItem: CartridgeMagnum
-#        priority: 1
-#        whitelist:
-#          tags:
-#            - CartridgeMagnum
-#        whitelistFailPopup: gun-magazine-whitelist-fail
-#  - type: MagazineVisuals
-#    magState: mag
-#    steps: 1
-#    zeroVisible: true
-#  - type: Appearance
-#  # WD EDIT START: Guns resize
-#  - type: Item
-#    shape:
-#    - 0,0,5,1
-#  # WD EDIT END
-
 - type: entity
   name: WT550
   parent: [BaseWeaponSubMachineGun, BaseRestrictedContraband, BaseGunWieldable] # WD EDIT: BaseGunWieldable

Resources/Prototypes/LootTables/suspicion_loot_table.yml

@@ -68,9 +68,6 @@
   - id: WeaponSubMachineGunC20r
     amount: 0
     maxAmount: 5
-  # - id: WeaponSubMachineGunVector
-  #  amount: 0
-  #  maxAmount: 5
   - id: WeaponSubMachineGunWt550
     amount: 0
     maxAmount: 5

Resources/Textures/Objects/Weapons/Guns/SMGs/vector.rsi/meta.json

@@ -1,39 +0,0 @@
-{
-    "version": 1,
-    "license": "CC-BY-SA-3.0",
-    "copyright": "Taken/modified vgstation at https://github.com/vgstation-coders/vgstation13/pull/20330/commits/1604c9cc61a48585e25b5f9eba3e179c06362372, backpack sprite by Peptide (copy of Atreides), backpack sling sprite edited by Boaz1111",
-    "size": {
-        "x": 32,
-        "y": 32
-    },
-    "states": [
-        {
-            "name": "icon"
-        },
-        {
-            "name": "base"
-        },
-        {
-            "name": "bolt-open"
-        },
-        {
-            "name": "mag-0"
-        },
-        {
-            "name": "inhand-left",
-            "directions": 4
-        },
-        {
-            "name": "inhand-right",
-            "directions": 4
-        },
-        {
-            "name": "equipped-BACKPACK",
-            "directions": 4
-        },
-		{
-            "name": "equipped-SUITSTORAGE",
-            "directions": 4
-        }
-    ]
-}