mirror of
https://github.com/WWhiteDreamProject/wwdpublic.git
synced 2026-05-01 12:37:23 +03:00
## Mirror of PR #26292: [Code cleanup: Purge calls to obsolete EntityCoordinates methods](https://github.com/space-wizards/space-station-14/pull/26292) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `f4cb02fb0ca385c858569c07c51afb0d24ade949` PR opened by <img src="https://avatars.githubusercontent.com/u/85356?v=4" width="16"/><a href="https://github.com/Tayrtahn"> Tayrtahn</a> at 2024-03-20 16:04:43 UTC --- PR changed 34 files with 70 additions and 56 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Cleaned up some outdated code. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Clean code is happy code. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > Updated all calls to obsolete EntityCoordinates methods (ToMap, ToMapPos, FromMap, ToVector2i, InRange) to non-obsolete ones (by passing in SharedTransformSystem as an arg). > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > Code > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > 🆑 > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > </details> --------- Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com>
165 lines
6.3 KiB
C#
165 lines
6.3 KiB
C#
using Content.Server.Cuffs;
|
|
using Content.Server.Forensics;
|
|
using Content.Server.Humanoid;
|
|
using Content.Server.Implants.Components;
|
|
using Content.Server.Store.Components;
|
|
using Content.Server.Store.Systems;
|
|
using Content.Shared.Cuffs.Components;
|
|
using Content.Shared.Humanoid;
|
|
using Content.Shared.Implants;
|
|
using Content.Shared.Implants.Components;
|
|
using Content.Shared.Interaction;
|
|
using Content.Shared.Physics;
|
|
using Content.Shared.Popups;
|
|
using Content.Shared.Preferences;
|
|
using Robust.Shared.Audio.Systems;
|
|
using Robust.Shared.Map;
|
|
using Robust.Shared.Maths;
|
|
using Robust.Shared.Physics;
|
|
using Robust.Shared.Physics.Components;
|
|
using Robust.Shared.Random;
|
|
using System.Numerics;
|
|
|
|
namespace Content.Server.Implants;
|
|
|
|
public sealed class SubdermalImplantSystem : SharedSubdermalImplantSystem
|
|
{
|
|
[Dependency] private readonly CuffableSystem _cuffable = default!;
|
|
[Dependency] private readonly HumanoidAppearanceSystem _humanoidAppearance = default!;
|
|
[Dependency] private readonly IMapManager _mapManager = default!;
|
|
[Dependency] private readonly IRobustRandom _random = default!;
|
|
[Dependency] private readonly MetaDataSystem _metaData = default!;
|
|
[Dependency] private readonly StoreSystem _store = default!;
|
|
[Dependency] private readonly SharedAudioSystem _audio = default!;
|
|
[Dependency] private readonly SharedPopupSystem _popup = default!;
|
|
[Dependency] private readonly SharedTransformSystem _xform = default!;
|
|
[Dependency] private readonly ForensicsSystem _forensicsSystem = default!;
|
|
|
|
private EntityQuery<PhysicsComponent> _physicsQuery;
|
|
|
|
public override void Initialize()
|
|
{
|
|
base.Initialize();
|
|
|
|
_physicsQuery = GetEntityQuery<PhysicsComponent>();
|
|
|
|
SubscribeLocalEvent<SubdermalImplantComponent, UseFreedomImplantEvent>(OnFreedomImplant);
|
|
SubscribeLocalEvent<StoreComponent, ImplantRelayEvent<AfterInteractUsingEvent>>(OnStoreRelay);
|
|
SubscribeLocalEvent<SubdermalImplantComponent, ActivateImplantEvent>(OnActivateImplantEvent);
|
|
SubscribeLocalEvent<SubdermalImplantComponent, UseScramImplantEvent>(OnScramImplant);
|
|
SubscribeLocalEvent<SubdermalImplantComponent, UseDnaScramblerImplantEvent>(OnDnaScramblerImplant);
|
|
|
|
}
|
|
|
|
private void OnStoreRelay(EntityUid uid, StoreComponent store, ImplantRelayEvent<AfterInteractUsingEvent> implantRelay)
|
|
{
|
|
var args = implantRelay.Event;
|
|
|
|
if (args.Handled)
|
|
return;
|
|
|
|
// can only insert into yourself to prevent uplink checking with renault
|
|
if (args.Target != args.User)
|
|
return;
|
|
|
|
if (!TryComp<CurrencyComponent>(args.Used, out var currency))
|
|
return;
|
|
|
|
// same as store code, but message is only shown to yourself
|
|
args.Handled = _store.TryAddCurrency(_store.GetCurrencyValue(args.Used, currency), uid, store);
|
|
|
|
if (!args.Handled)
|
|
return;
|
|
|
|
var msg = Loc.GetString("store-currency-inserted-implant", ("used", args.Used));
|
|
_popup.PopupEntity(msg, args.User, args.User);
|
|
QueueDel(args.Used);
|
|
}
|
|
|
|
private void OnFreedomImplant(EntityUid uid, SubdermalImplantComponent component, UseFreedomImplantEvent args)
|
|
{
|
|
if (!TryComp<CuffableComponent>(component.ImplantedEntity, out var cuffs) || cuffs.Container.ContainedEntities.Count < 1)
|
|
return;
|
|
|
|
_cuffable.Uncuff(component.ImplantedEntity.Value, cuffs.LastAddedCuffs, cuffs.LastAddedCuffs);
|
|
args.Handled = true;
|
|
}
|
|
|
|
private void OnActivateImplantEvent(EntityUid uid, SubdermalImplantComponent component, ActivateImplantEvent args)
|
|
{
|
|
args.Handled = true;
|
|
}
|
|
|
|
private void OnScramImplant(EntityUid uid, SubdermalImplantComponent component, UseScramImplantEvent args)
|
|
{
|
|
if (component.ImplantedEntity is not { } ent)
|
|
return;
|
|
|
|
if (!TryComp<ScramImplantComponent>(uid, out var implant))
|
|
return;
|
|
|
|
var xform = Transform(ent);
|
|
var entityCoords = xform.Coordinates.ToMap(EntityManager, _xform);
|
|
|
|
// try to find a valid position to teleport to, teleport to whatever works if we can't
|
|
var targetCoords = new MapCoordinates();
|
|
for (var i = 0; i < implant.TeleportAttempts; i++)
|
|
{
|
|
var distance = implant.TeleportRadius * MathF.Sqrt(_random.NextFloat()); // to get an uniform distribution
|
|
targetCoords = entityCoords.Offset(_random.NextAngle().ToVec() * distance);
|
|
|
|
// prefer teleporting to grids
|
|
if (!_mapManager.TryFindGridAt(targetCoords, out var gridUid, out var grid))
|
|
continue;
|
|
|
|
// the implant user probably does not want to be in your walls
|
|
var valid = true;
|
|
foreach (var entity in grid.GetAnchoredEntities(targetCoords))
|
|
{
|
|
if (!_physicsQuery.TryGetComponent(entity, out var body))
|
|
continue;
|
|
|
|
if (body.BodyType != BodyType.Static ||
|
|
!body.Hard ||
|
|
(body.CollisionLayer & (int) CollisionGroup.Impassable) == 0)
|
|
continue;
|
|
|
|
valid = false;
|
|
break;
|
|
}
|
|
if (valid)
|
|
break;
|
|
}
|
|
_xform.SetWorldPosition(ent, targetCoords.Position);
|
|
_xform.AttachToGridOrMap(ent, xform);
|
|
_audio.PlayPvs(implant.TeleportSound, ent);
|
|
|
|
args.Handled = true;
|
|
}
|
|
|
|
private void OnDnaScramblerImplant(EntityUid uid, SubdermalImplantComponent component, UseDnaScramblerImplantEvent args)
|
|
{
|
|
if (component.ImplantedEntity is not { } ent)
|
|
return;
|
|
|
|
if (TryComp<HumanoidAppearanceComponent>(ent, out var humanoid))
|
|
{
|
|
var newProfile = HumanoidCharacterProfile.RandomWithSpecies(humanoid.Species);
|
|
_humanoidAppearance.LoadProfile(ent, newProfile, humanoid);
|
|
_metaData.SetEntityName(ent, newProfile.Name);
|
|
if (TryComp<DnaComponent>(ent, out var dna))
|
|
{
|
|
dna.DNA = _forensicsSystem.GenerateDNA();
|
|
}
|
|
if (TryComp<FingerprintComponent>(ent, out var fingerprint))
|
|
{
|
|
fingerprint.Fingerprint = _forensicsSystem.GenerateFingerprint();
|
|
}
|
|
_popup.PopupEntity(Loc.GetString("scramble-implant-activated-popup"), ent, ent);
|
|
}
|
|
|
|
args.Handled = true;
|
|
QueueDel(uid);
|
|
}
|
|
}
|