mirror of
https://github.com/WWhiteDreamProject/wwdpublic.git
synced 2026-04-17 21:48:58 +03:00
## Mirror of PR #26292: [Code cleanup: Purge calls to obsolete EntityCoordinates methods](https://github.com/space-wizards/space-station-14/pull/26292) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `f4cb02fb0ca385c858569c07c51afb0d24ade949` PR opened by <img src="https://avatars.githubusercontent.com/u/85356?v=4" width="16"/><a href="https://github.com/Tayrtahn"> Tayrtahn</a> at 2024-03-20 16:04:43 UTC --- PR changed 34 files with 70 additions and 56 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Cleaned up some outdated code. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Clean code is happy code. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > Updated all calls to obsolete EntityCoordinates methods (ToMap, ToMapPos, FromMap, ToVector2i, InRange) to non-obsolete ones (by passing in SharedTransformSystem as an arg). > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > Code > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > 🆑 > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > </details> --------- Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com>
94 lines
3.1 KiB
C#
94 lines
3.1 KiB
C#
using Content.Shared.Construction;
|
|
using Content.Shared.Examine;
|
|
using Content.Shared.Maps;
|
|
using JetBrains.Annotations;
|
|
using Robust.Shared.Map;
|
|
using Robust.Shared.Map.Components;
|
|
using Robust.Shared.Utility;
|
|
|
|
namespace Content.Server.Construction.Conditions
|
|
{
|
|
/// <summary>
|
|
/// Makes the condition fail if any entities on a tile have (or not) a component.
|
|
/// </summary>
|
|
[UsedImplicitly]
|
|
[DataDefinition]
|
|
public sealed partial class ComponentInTile : IGraphCondition
|
|
{
|
|
/// <summary>
|
|
/// If true, any entity on the tile must have the component.
|
|
/// If false, no entity on the tile must have the component.
|
|
/// </summary>
|
|
[DataField("hasEntity")]
|
|
public bool HasEntity { get; private set; }
|
|
|
|
[DataField("examineText")]
|
|
public string? ExamineText { get; private set; }
|
|
|
|
[DataField("guideText")]
|
|
public string? GuideText { get; private set; }
|
|
|
|
[DataField("guideIcon")]
|
|
public SpriteSpecifier? GuideIcon { get; private set; }
|
|
|
|
/// <summary>
|
|
/// The component name in question.
|
|
/// </summary>
|
|
[DataField("component")]
|
|
public string Component { get; private set; } = string.Empty;
|
|
|
|
public bool Condition(EntityUid uid, IEntityManager entityManager)
|
|
{
|
|
if (string.IsNullOrEmpty(Component)) return false;
|
|
|
|
var type = IoCManager.Resolve<IComponentFactory>().GetRegistration(Component).Type;
|
|
|
|
var transform = entityManager.GetComponent<TransformComponent>(uid);
|
|
if (transform.GridUid == null)
|
|
return false;
|
|
|
|
var transformSys = entityManager.System<SharedTransformSystem>();
|
|
var indices = transform.Coordinates.ToVector2i(entityManager, IoCManager.Resolve<IMapManager>(), transformSys);
|
|
var lookup = entityManager.EntitySysManager.GetEntitySystem<EntityLookupSystem>();
|
|
|
|
|
|
if (!entityManager.TryGetComponent<MapGridComponent>(transform.GridUid.Value, out var grid))
|
|
return !HasEntity;
|
|
|
|
if (!entityManager.System<SharedMapSystem>().TryGetTileRef(transform.GridUid.Value, grid, indices, out var tile))
|
|
return !HasEntity;
|
|
|
|
var entities = tile.GetEntitiesInTile(LookupFlags.Approximate | LookupFlags.Static, lookup);
|
|
|
|
foreach (var ent in entities)
|
|
{
|
|
if (entityManager.HasComponent(ent, type))
|
|
return HasEntity;
|
|
}
|
|
|
|
return !HasEntity;
|
|
}
|
|
|
|
public bool DoExamine(ExaminedEvent args)
|
|
{
|
|
if (string.IsNullOrEmpty(ExamineText))
|
|
return false;
|
|
|
|
args.PushMarkup(Loc.GetString(ExamineText));
|
|
return true;
|
|
}
|
|
|
|
public IEnumerable<ConstructionGuideEntry> GenerateGuideEntry()
|
|
{
|
|
if (string.IsNullOrEmpty(GuideText))
|
|
yield break;
|
|
|
|
yield return new ConstructionGuideEntry()
|
|
{
|
|
Localization = GuideText,
|
|
Icon = GuideIcon,
|
|
};
|
|
}
|
|
}
|
|
}
|