Files
wwdpublic/Content.Shared/Overlays/Switchable/SwitchableOverlaySystem.cs
Piras314 cf247d1e4e Fix Night Vision (#1554)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Fixes the bug where you could put a mouse on your head and get free
night vision. This works by adding a bool to the
SwitchableVisionOverlayComponent `IsEquipment` that will be checked for
before granting the thermal/night vision action. Port of
https://github.com/Goob-Station/Goob-Station/pull/1448

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

No night vision with the mouse on your head:

![image](https://github.com/user-attachments/assets/ccde942c-7f08-405f-9215-b904e0d4dd6a)

Goggles still work:

![image](https://github.com/user-attachments/assets/a7c7e0f4-b49b-4255-86e3-511441234f02)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

🆑 Piras314, Aviu
- fix: Fixed being able to get night vision from putting a mouse on your
head.

---------

Signed-off-by: VMSolidus <evilexecutive@gmail.com>
Co-authored-by: Aviu00 <93730715+Aviu00@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
(cherry picked from commit 03b7a8a6bfbbc13bc9b7bd27fe414086500592be)
2025-01-15 23:55:38 +03:00

171 lines
5.8 KiB
C#

using Content.Shared.Actions;
using Content.Shared.Inventory;
using Robust.Shared.Audio.Systems;
using Robust.Shared.GameStates;
using Robust.Shared.Network;
using Robust.Shared.Player;
using Robust.Shared.Timing;
namespace Content.Shared.Overlays.Switchable;
public abstract class SwitchableOverlaySystem<TComp, TEvent> : EntitySystem
where TComp : SwitchableOverlayComponent
where TEvent : InstantActionEvent
{
[Dependency] private readonly SharedAudioSystem _audio = default!;
[Dependency] private readonly SharedActionsSystem _actions = default!;
[Dependency] private readonly IGameTiming _timing = default!;
[Dependency] private readonly INetManager _net = default!;
public override void Initialize()
{
SubscribeLocalEvent<TComp, TEvent>(OnToggle);
SubscribeLocalEvent<TComp, ComponentInit>(OnInit);
SubscribeLocalEvent<TComp, MapInitEvent>(OnMapInit);
SubscribeLocalEvent<TComp, ComponentShutdown>(OnShutdown);
SubscribeLocalEvent<TComp, GetItemActionsEvent>(OnGetItemActions);
SubscribeLocalEvent<TComp, ComponentGetState>(OnGetState);
SubscribeLocalEvent<TComp, ComponentHandleState>(OnHandleState);
}
public override void FrameUpdate(float frameTime)
{
base.FrameUpdate(frameTime);
if (_net.IsClient)
ActiveTick(frameTime);
}
public override void Update(float frameTime)
{
base.Update(frameTime);
if (_net.IsServer)
ActiveTick(frameTime);
}
private void ActiveTick(float frameTime)
{
var query = EntityQueryEnumerator<TComp>();
while (query.MoveNext(out var uid, out var comp))
{
if (comp.PulseTime <= 0f || comp.PulseAccumulator >= comp.PulseTime)
continue;
comp.PulseAccumulator += frameTime;
if (comp.PulseAccumulator < comp.PulseTime)
continue;
Toggle(uid, comp, false, false);
RaiseSwitchableOverlayToggledEvent(uid, uid, comp.IsActive);
RaiseSwitchableOverlayToggledEvent(uid, Transform(uid).ParentUid, comp.IsActive);
}
}
private void OnGetState(EntityUid uid, TComp component, ref ComponentGetState args)
{
args.State = new SwitchableVisionOverlayComponentState
{
Color = component.Color,
IsActive = component.IsActive,
ActivateSound = component.ActivateSound,
DeactivateSound = component.DeactivateSound,
ToggleAction = component.ToggleAction,
LightRadius = component is ThermalVisionComponent thermal ? thermal.LightRadius : 0f,
};
}
private void OnHandleState(EntityUid uid, TComp component, ref ComponentHandleState args)
{
if (args.Current is not SwitchableVisionOverlayComponentState state)
return;
component.Color = state.Color;
component.ActivateSound = state.ActivateSound;
component.DeactivateSound = state.DeactivateSound;
if (component.ToggleAction != state.ToggleAction)
{
_actions.RemoveAction(uid, component.ToggleActionEntity);
component.ToggleAction = state.ToggleAction;
if (component.ToggleAction != null)
_actions.AddAction(uid, ref component.ToggleActionEntity, component.ToggleAction);
}
if (component is ThermalVisionComponent thermal)
thermal.LightRadius = state.LightRadius;
if (component.IsActive == state.IsActive)
return;
component.IsActive = state.IsActive;
RaiseSwitchableOverlayToggledEvent(uid,
component.IsEquipment ? Transform(uid).ParentUid : uid,
component.IsActive);
}
private void OnGetItemActions(Entity<TComp> ent, ref GetItemActionsEvent args)
{
if (ent.Comp.IsEquipment && ent.Comp.ToggleAction != null && args.SlotFlags is not SlotFlags.POCKET and not null)
args.AddAction(ref ent.Comp.ToggleActionEntity, ent.Comp.ToggleAction);
}
private void OnShutdown(EntityUid uid, TComp component, ComponentShutdown args)
{
if (component.IsEquipment)
return;
_actions.RemoveAction(uid, component.ToggleActionEntity);
}
private void OnInit(EntityUid uid, TComp component, ComponentInit args)
{
component.PulseAccumulator = component.PulseTime;
}
private void OnMapInit(EntityUid uid, TComp component, MapInitEvent args)
{
if (component is { IsEquipment: false, ToggleActionEntity: null, ToggleAction: not null })
_actions.AddAction(uid, ref component.ToggleActionEntity, component.ToggleAction);
}
private void OnToggle(EntityUid uid, TComp component, TEvent args)
{
Toggle(uid, component, !component.IsActive);
RaiseSwitchableOverlayToggledEvent(uid, args.Performer, component.IsActive);
args.Handled = true;
}
private void Toggle(EntityUid uid, TComp component, bool activate, bool playSound = true)
{
if (playSound && _net.IsClient && _timing.IsFirstTimePredicted)
{
_audio.PlayEntity(activate ? component.ActivateSound : component.DeactivateSound,
Filter.Local(),
uid,
false);
}
if (component.PulseTime > 0f)
{
component.PulseAccumulator = activate ? 0f : component.PulseTime;
return;
}
component.IsActive = activate;
Dirty(uid, component);
}
private void RaiseSwitchableOverlayToggledEvent(EntityUid uid, EntityUid user, bool activated)
{
var ev = new SwitchableOverlayToggledEvent(user, activated);
RaiseLocalEvent(uid, ref ev);
}
}
[ByRefEvent]
public record struct SwitchableOverlayToggledEvent(EntityUid User, bool Activated);