Pieter-Jan Briers ccea85136b Random spontaneous cleanup PR (#25131) ...

* Use new Subs.CVar helper

Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.

This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.

* Fix a bunch of warnings

* More warning fixes

* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.

* Get rid of some more ISerializationHooks for enums

* And a little more

* Apply suggestions from code review

Co-authored-by: 0x6273 <0x40@keemail.me>

---------

Co-authored-by: 0x6273 <0x40@keemail.me>
(cherry picked from commit 68ce53ae17985876d6d112b764b2144964a9f42e)

2024-02-18 23:02:29 +01:00

..

Abilities/Mime

Firestarter fixes (#24647)

2024-02-08 12:04:52 +01:00

Access

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Actions

…

Acz

…

Administration

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Advertise

Reduce vendor thank you message spam and add variety (#23746)

2024-01-26 22:14:58 +01:00

Advertisements

Reduce vendor thank you message spam and add variety (#23746)

2024-01-26 22:14:58 +01:00

Afk

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Alert

Emergency revert for pulling (#24923)

2024-02-08 12:34:47 +01:00

AlertLevel

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Ame

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Animals

Revert 'Revert 'Solution Entities'' (#23168)

2024-01-23 23:00:42 +01:00

Announcements

…

Anomaly

Remove obsolete transform call (#24217)

2024-02-08 12:23:11 +01:00

Antag

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

Arcade

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Armor

Add price multiplier for armor component (#24561)

2024-01-28 00:27:48 +01:00

Atmos

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Audio

…

BarSign/Systems

…

Beam

…

Bed

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Bible

UseDelay + ItemCooldown merge (#22502)

2024-01-26 21:32:09 +01:00

Body

Gibbing refactor (Per-part gibbing and giblet throwing!) (#24989)

2024-02-18 22:46:02 +01:00

Botany

Fix hybridization seedless probability (#25084)

2024-02-18 22:38:04 +01:00

Buckle/Systems

Powered stasis bed prevents body decay (#23520)

2024-01-26 22:16:32 +01:00

Cabinet

…

Camera

…

CardboardBox

…

Cargo

Rip out remaining machine upgrades (#24413)

2024-01-27 23:43:49 +01:00

CartridgeLoader

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

CharacterInfo

…

Charges

…

Chat

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Chemistry

predict egg cracking + refactor (#25028)

2024-02-08 12:41:42 +01:00

Chunking

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Cloning

Metempsychosis Returns (#685)

2024-02-18 03:36:16 +01:00

Clothing

…

Cluwne

…

CombatMode

…

Commands

Action, Action Container, and Action Upgrade changes (#24005)

2024-01-26 22:51:47 +01:00

Communications

Predict two-way levers (#25043)

2024-02-18 22:46:26 +01:00

Configurable

…

Connection

Cvar to allow whitelisted players to bypass panic bunker (#23885)

2024-01-26 22:37:39 +01:00

Construction

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Containers

Content ecs containers (#22484)

2024-01-22 18:47:55 +01:00

Contests

…

Coordinates

…

CPUJob/JobQueues/Queues

…

Crayon

…

CrewManifest

BUI bugfixes / improvements (#23881)

2024-01-26 22:38:21 +01:00

CriminalRecords/Systems

move criminal records console component to shared (#24957)

2024-02-08 12:37:47 +01:00

Cuffs

…

Damage

DamageSpecifier Total => GetTotal (#24160)

2024-01-27 23:42:35 +01:00

Database

Client customization late-join spawner priority for arrivals/cryostorage (#24586)

2024-02-08 12:16:20 +01:00

Decals

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Defusable

Move grenade components to shared (#22691)

2024-02-08 12:22:56 +01:00

DeltaV

bring back paradox anomaly (#825)

2024-02-13 16:55:35 +01:00

Destructible

Revert 'Revert 'Solution Entities'' (#23168)

2024-01-23 23:00:42 +01:00

DetailExaminable

…

DeviceLinking

make linking logic gates 1000% better (#25041)

2024-02-18 22:55:58 +01:00

DeviceNetwork

Predict two-way levers (#25043)

2024-02-18 22:46:26 +01:00

Devour

Content ecs containers (#22484)

2024-01-22 18:47:55 +01:00

Dice

…

Discord

…

Disposal

Predict two-way levers (#25043)

2024-02-18 22:46:26 +01:00

DoAfter

…

Doors

Allow opening doors mid-deny animation, if you have the access (#24969)

2024-02-08 12:39:03 +01:00

Dragon

…

Drone

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Drunk

…

Effects

…

Electrocution

Rebalances electrocution damage to a log scale (#24829)

2024-02-08 12:37:49 +01:00

Emoting

…

Emp

…

Engineering

…

Ensnaring

Content ecs containers (#22484)

2024-01-22 18:47:55 +01:00

EntityList

…

Entry

Freeze eventbus dictionaries (#22628)

2024-01-26 21:50:22 +01:00

EUI

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

Examine

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

Execution

what the fuck

2024-01-26 23:00:38 +01:00

Explosion

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Extinguisher

Revert 'Revert 'Solution Entities'' (#23168)

2024-01-23 23:00:42 +01:00

Eye/Blinding

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Fax

Predict two-way levers (#25043)

2024-02-18 22:46:26 +01:00

Flash

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Fluids

Remove soapy water (#24301)

2024-02-08 12:31:59 +01:00

Forensics

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Friends

…

GameTicking

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Gateway

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Gatherable

…

GenericAntag

bring back paradox anomaly (#825)

2024-02-13 16:55:35 +01:00

Ghost

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

GhostKick

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

Glue

Fixed GluedComponent interactions with metamorphic glasses (#24943)

2024-02-08 12:41:41 +01:00

Gravity

Rip out remaining machine upgrades (#24413)

2024-01-27 23:43:49 +01:00

Guardian

Make some damage sources not cancel do afters (#24635)

2024-02-08 11:49:23 +01:00

GuideGenerator

Make some prototypes use frozen collections (#22576)

2024-01-22 18:36:50 +01:00

Hands/Systems

Emergency revert for pulling (#24923)

2024-02-08 12:34:47 +01:00

HealthExaminable

…

Holiday

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Holosign

Examine prediction (#23565)

2024-01-26 21:48:02 +01:00

HotPotato

…

Humanoid

bring back paradox anomaly (#825)

2024-02-13 16:55:35 +01:00

IdentityManagement

Content ecs containers (#22484)

2024-01-22 18:47:55 +01:00

IgnitionSource

UseDelay + ItemCooldown merge (#22502)

2024-01-26 21:32:09 +01:00

ImmovableRod

Destruction & impact sound rework pass 1 (#24282)

2024-01-26 23:10:41 +01:00

Implants

Fix scram implant's teleportation out of containers (#24827)

2024-02-08 12:41:40 +01:00

Info

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Instruments

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Interaction

Generalize tile prying to any tool quality (#24432)

2024-01-27 23:50:17 +01:00

Inventory

Virtual items cleanup (#23912)

2024-01-26 22:49:14 +01:00

IoC

Revert "Game server api (#23129)" (#23672)

2024-01-26 22:07:25 +01:00

IP

Dependency update / fixes / skrungle bungle (#23745)

2024-01-26 22:33:46 +01:00

Item

Virtual items cleanup (#23912)

2024-01-26 22:49:14 +01:00

Jittering

…

Jobs

Replace EntityUid parsing with NetEntity (#23474)

2024-01-26 21:29:52 +01:00

KillTracking

DamageSpecifier Total => GetTotal (#24160)

2024-01-27 23:42:35 +01:00

Kitchen

Fix bug with ActivelyMicrowavedComponent being stuck in powercuts (#23997)

2024-01-27 23:51:43 +01:00

Labels/Label

Localize preset labels on chem dispenser (#24617)

2024-02-08 11:52:28 +01:00

LandMines

…

Lathe

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Light

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Lightning

Adds explosion when attempting to microwave metal / bugfix (#23887)

2024-01-27 23:51:32 +01:00

Lock

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Lube

Revert 'Revert 'Solution Entities'' (#23168)

2024-01-23 23:00:42 +01:00

Magic

…

MagicMirror

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Mapping

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Maps

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

MassMedia

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Materials

Rip out remaining machine upgrades (#24413)

2024-01-27 23:43:49 +01:00

Mech

Suffocation alerts for nitrogen breathers (#24373)

2024-01-27 23:50:55 +01:00

Medical

Predict two-way levers (#25043)

2024-02-18 22:46:26 +01:00

Mind

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Mindshield

…

Mining

…

Mobs

…

MoMMI

…

Morgue

Examine prediction (#23565)

2024-01-26 21:48:02 +01:00

Motd

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

MouseRotator

…

Mousetrap

Fix clientside storage Whitelists (#24063)

2024-02-08 12:22:58 +01:00

Movement

…

NameIdentifier

Chill bounties + fixes (#23411)

2024-01-26 21:30:40 +01:00

Ninja

Store ninja objectives in conditions 2 (#20894)

2024-02-08 11:54:40 +01:00

NodeContainer

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

NPC

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Nuke

reduce nuke required floor radius variable (#22947)

2024-01-22 18:37:05 +01:00

NukeOps

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Nutrition

Fix clientside storage Whitelists (#24063)

2024-02-08 12:22:58 +01:00

Nyanotrasen

Metempsychosis Returns (#685)

2024-02-18 03:36:16 +01:00

Objectives

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

PAI

…

Paper

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Parallax

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

ParticleAccelerator

PA control box part detection fix (#24356)

2024-01-27 23:40:24 +01:00

Payload/EntitySystems

Examine prediction (#23565)

2024-01-26 21:48:02 +01:00

PDA

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Physics

Emergency revert for pulling (#24923)

2024-02-08 12:34:47 +01:00

Pinpointer

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Placement

…

Plants

…

Players

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

PneumaticCannon

Add events for GunComponent values, muzzle flashes and cartridge spread (#24077)

2024-02-08 11:52:29 +01:00

Pointing

Travelling pointing arrows, brains can no longer point (#24864)

2024-02-08 12:32:04 +01:00

Points

…

Polymorph

Cleanups PolymorphSystem/Components/Prototypes (#23721)

2024-02-08 12:20:24 +01:00

Popups

Make popups nullable (#24802)

2024-02-08 12:26:32 +01:00

Power

Predict two-way levers (#25043)

2024-02-18 22:46:26 +01:00

PowerCell

…

PowerSink

…

Prayer

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

Preferences/Managers

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

Procedural

Make procgen use weighted variants (#24669)

2024-02-08 11:54:39 +01:00

Projectiles

DamageSpecifier Total => GetTotal (#24160)

2024-01-27 23:42:35 +01:00

Pulling

Emergency revert for pulling (#24923)

2024-02-08 12:34:47 +01:00

Puppet

…

Radiation

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Radio

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

RandomAppearance

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

RandomMetadata

…

RatKing

…

Remotes

Changed door remote to trigger based on vision occlusion(#25093)

2024-02-18 22:43:26 +01:00

Repairable

…

Research

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Resist

Fix pressing shift while held triggering escape (#24878)

2024-02-08 12:31:28 +01:00

Respawn

…

Revenant

DamageSpecifier Total => GetTotal (#24160)

2024-01-27 23:42:35 +01:00

Revolutionary

better deconversion (#23315)

2024-01-26 22:37:15 +01:00

Roles

Store ninja objectives in conditions 2 (#20894)

2024-02-08 11:54:40 +01:00

Rotatable

…

Rotation

Fix rotation visuals desync & appearance state spam (#23016)

2024-01-22 18:37:45 +01:00

RoundEnd

Predict two-way levers (#25043)

2024-02-18 22:46:26 +01:00

Salvage

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Sandbox

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

Screens

Hallway textscreens (#24189)

2024-01-28 00:33:40 +01:00

SensorMonitoring

Predict two-way levers (#25043)

2024-02-18 22:46:26 +01:00

Sericulture

…

ServerInfo

…

ServerUpdates

…

Shuttles

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Silicons

Travelling pointing arrows, brains can no longer point (#24864)

2024-02-08 12:32:04 +01:00

Singularity

Make radiation collector a power supplier (#24978)

2024-02-08 12:39:59 +01:00

Solar

…

Sound

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Spawners

Client customization late-join spawner priority for arrivals/cryostorage (#24586)

2024-02-08 12:16:20 +01:00

Speech

Lower speech noise volume & refactor system (#24579)

2024-02-08 11:51:58 +01:00

Spider

…

SprayPainter

spray painter rework (#23287)

2024-02-08 12:25:35 +01:00

Spreader

The glowing forest anomaly (#24351)

2024-01-27 23:36:10 +01:00

Sprite

Kobold variety - allows kobolds to have random colors and horns (+ allows RandomSpriteComponent to uh. Actually choose random sprites for specific layers) (#23393)

2024-01-26 21:30:45 +01:00

Stack

…

Standing

…

Station

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

StationEvents

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

StationRecords

criminal records revival (#22510)

2024-02-08 12:37:29 +01:00

Stealth

…

Sticky

Content ecs containers (#22484)

2024-01-22 18:47:55 +01:00

Storage

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Store

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Strip

Virtual items cleanup (#23912)

2024-01-26 22:49:14 +01:00

Stunnable

Added display for amount of hits left in stun batons/stun prods. (#25141)

2024-02-18 22:55:52 +01:00

SubFloor

…

SurveillanceCamera

Predict two-way levers (#25043)

2024-02-18 22:46:26 +01:00

Tabletop

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

Teleportation

…

Temperature

…

Terminator

bring back paradox anomaly (#825)

2024-02-13 16:55:35 +01:00

Tesla

Tesla Gun (#23175)

2024-01-26 21:48:53 +01:00

Thief

Thief hotfix (#22976)

2024-01-22 18:38:38 +01:00

Tiles

Incendiary projectiles and lava firestack reduction (#23479)

2024-01-26 22:11:45 +01:00

Tips

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Toilet

…

Tools

Generalize tile prying to any tool quality (#24432)

2024-01-27 23:50:17 +01:00

Toolshed/Commands

…

Traitor

Replace EntityUid parsing with NetEntity (#23474)

2024-01-26 21:29:52 +01:00

Traits

Revert "Unrevivable trait (#24226)"

2024-01-26 23:42:54 +01:00

UserInterface

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

VendingMachines

Lock Anomaly generator to research access (#24464)

2024-02-08 12:11:07 +01:00

Verbs

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

VoiceMask

Fix sloshing electricity & enable SpeechVerb masking (#24238)

2024-01-27 23:51:27 +01:00

Voting

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

Wagging

Remove tail wag emote text (#25054)

2024-02-18 22:35:07 +01:00

Warps

…

Weapons

Revert "Make flare gun explode, damage and stun the player when used … (#24679)

2024-02-08 11:52:32 +01:00

Weather

…

Whitelist

Obsolete refactor - ConnectedClient to Channel (#24409)

2024-01-27 23:44:02 +01:00

Wires

Decouple panels and wires (#24840)

2024-02-08 12:32:00 +01:00

Worldgen

Random spontaneous cleanup PR (#25131)

2024-02-18 23:02:29 +01:00

Xenoarchaeology

Gibbing refactor (Per-part gibbing and giblet throwing!) (#24989)

2024-02-18 22:46:02 +01:00

Zombies

Emergency revert for pulling (#24923)

2024-02-08 12:34:47 +01:00

AssemblyInfo.cs

…

Content.Server.csproj

Dependency update / fixes / skrungle bungle (#23745)

2024-01-26 22:33:46 +01:00

Content.Server.csproj.DotSettings

…

GlobalUsings.cs

…

Program.cs

…