mirror of
https://github.com/WWhiteDreamProject/wwdpublic.git
synced 2026-04-17 21:48:58 +03:00
## Mirror of PR #26292: [Code cleanup: Purge calls to obsolete EntityCoordinates methods](https://github.com/space-wizards/space-station-14/pull/26292) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `f4cb02fb0ca385c858569c07c51afb0d24ade949` PR opened by <img src="https://avatars.githubusercontent.com/u/85356?v=4" width="16"/><a href="https://github.com/Tayrtahn"> Tayrtahn</a> at 2024-03-20 16:04:43 UTC --- PR changed 34 files with 70 additions and 56 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Cleaned up some outdated code. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Clean code is happy code. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > Updated all calls to obsolete EntityCoordinates methods (ToMap, ToMapPos, FromMap, ToVector2i, InRange) to non-obsolete ones (by passing in SharedTransformSystem as an arg). > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > Code > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > 🆑 > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > </details> --------- Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com>
284 lines
9.5 KiB
C#
284 lines
9.5 KiB
C#
using Content.Server.GenericAntag;
|
|
using Content.Server.Objectives.Components;
|
|
using Content.Server.Objectives.Systems;
|
|
using Content.Server.Popups;
|
|
using Content.Server.Roles;
|
|
using Content.Shared.Actions;
|
|
using Content.Shared.Dragon;
|
|
using Content.Shared.Maps;
|
|
using Content.Shared.Mind;
|
|
using Content.Shared.Mind.Components;
|
|
using Content.Shared.Mobs;
|
|
using Content.Shared.Movement.Systems;
|
|
using Robust.Shared.Audio;
|
|
using Robust.Shared.Audio.Systems;
|
|
using Robust.Shared.GameStates;
|
|
using Robust.Shared.Map;
|
|
using Robust.Shared.Player;
|
|
|
|
namespace Content.Server.Dragon;
|
|
|
|
public sealed partial class DragonSystem : EntitySystem
|
|
{
|
|
[Dependency] private readonly CarpRiftsConditionSystem _carpRifts = default!;
|
|
[Dependency] private readonly IMapManager _mapManager = default!;
|
|
[Dependency] private readonly ITileDefinitionManager _tileDef = default!;
|
|
[Dependency] private readonly MovementSpeedModifierSystem _movement = default!;
|
|
[Dependency] private readonly PopupSystem _popup = default!;
|
|
[Dependency] private readonly RoleSystem _role = default!;
|
|
[Dependency] private readonly SharedActionsSystem _actions = default!;
|
|
[Dependency] private readonly SharedAudioSystem _audio = default!;
|
|
[Dependency] private readonly SharedTransformSystem _transform = default!;
|
|
|
|
private EntityQuery<CarpRiftsConditionComponent> _objQuery;
|
|
|
|
/// <summary>
|
|
/// Minimum distance between 2 rifts allowed.
|
|
/// </summary>
|
|
private const int RiftRange = 15;
|
|
|
|
/// <summary>
|
|
/// Radius of tiles
|
|
/// </summary>
|
|
private const int RiftTileRadius = 2;
|
|
|
|
private const int RiftsAllowed = 3;
|
|
|
|
public override void Initialize()
|
|
{
|
|
base.Initialize();
|
|
|
|
_objQuery = GetEntityQuery<CarpRiftsConditionComponent>();
|
|
|
|
SubscribeLocalEvent<DragonComponent, MapInitEvent>(OnInit);
|
|
SubscribeLocalEvent<DragonComponent, ComponentShutdown>(OnShutdown);
|
|
SubscribeLocalEvent<DragonComponent, DragonSpawnRiftActionEvent>(OnSpawnRift);
|
|
SubscribeLocalEvent<DragonComponent, RefreshMovementSpeedModifiersEvent>(OnDragonMove);
|
|
SubscribeLocalEvent<DragonComponent, MobStateChangedEvent>(OnMobStateChanged);
|
|
SubscribeLocalEvent<DragonComponent, GenericAntagCreatedEvent>(OnCreated);
|
|
}
|
|
|
|
public override void Update(float frameTime)
|
|
{
|
|
base.Update(frameTime);
|
|
|
|
var query = EntityQueryEnumerator<DragonComponent>();
|
|
while (query.MoveNext(out var uid, out var comp))
|
|
{
|
|
if (comp.WeakenedAccumulator > 0f)
|
|
{
|
|
comp.WeakenedAccumulator -= frameTime;
|
|
|
|
// No longer weakened.
|
|
if (comp.WeakenedAccumulator < 0f)
|
|
{
|
|
comp.WeakenedAccumulator = 0f;
|
|
_movement.RefreshMovementSpeedModifiers(uid);
|
|
}
|
|
}
|
|
|
|
// At max rifts
|
|
if (comp.Rifts.Count >= RiftsAllowed)
|
|
continue;
|
|
|
|
// If there's an active rift don't accumulate.
|
|
if (comp.Rifts.Count > 0)
|
|
{
|
|
var lastRift = comp.Rifts[^1];
|
|
|
|
if (TryComp<DragonRiftComponent>(lastRift, out var rift) && rift.State != DragonRiftState.Finished)
|
|
{
|
|
comp.RiftAccumulator = 0f;
|
|
continue;
|
|
}
|
|
}
|
|
|
|
comp.RiftAccumulator += frameTime;
|
|
|
|
// Delete it, naughty dragon!
|
|
if (comp.RiftAccumulator >= comp.RiftMaxAccumulator)
|
|
{
|
|
Roar(uid, comp);
|
|
QueueDel(uid);
|
|
}
|
|
}
|
|
}
|
|
|
|
private void OnInit(EntityUid uid, DragonComponent component, MapInitEvent args)
|
|
{
|
|
Roar(uid, component);
|
|
_actions.AddAction(uid, ref component.SpawnRiftActionEntity, component.SpawnRiftAction);
|
|
}
|
|
|
|
private void OnShutdown(EntityUid uid, DragonComponent component, ComponentShutdown args)
|
|
{
|
|
DeleteRifts(uid, false, component);
|
|
}
|
|
|
|
private void OnSpawnRift(EntityUid uid, DragonComponent component, DragonSpawnRiftActionEvent args)
|
|
{
|
|
if (component.Weakened)
|
|
{
|
|
_popup.PopupEntity(Loc.GetString("carp-rift-weakened"), uid, uid);
|
|
return;
|
|
}
|
|
|
|
if (component.Rifts.Count >= RiftsAllowed)
|
|
{
|
|
_popup.PopupEntity(Loc.GetString("carp-rift-max"), uid, uid);
|
|
return;
|
|
}
|
|
|
|
if (component.Rifts.Count > 0 && TryComp<DragonRiftComponent>(component.Rifts[^1], out var rift) && rift.State != DragonRiftState.Finished)
|
|
{
|
|
_popup.PopupEntity(Loc.GetString("carp-rift-duplicate"), uid, uid);
|
|
return;
|
|
}
|
|
|
|
var xform = Transform(uid);
|
|
|
|
// Have to be on a grid fam
|
|
if (!_mapManager.TryGetGrid(xform.GridUid, out var grid))
|
|
{
|
|
_popup.PopupEntity(Loc.GetString("carp-rift-anchor"), uid, uid);
|
|
return;
|
|
}
|
|
|
|
// cant stack rifts near eachother
|
|
foreach (var (_, riftXform) in EntityQuery<DragonRiftComponent, TransformComponent>(true))
|
|
{
|
|
if (riftXform.Coordinates.InRange(EntityManager, _transform, xform.Coordinates, RiftRange))
|
|
{
|
|
_popup.PopupEntity(Loc.GetString("carp-rift-proximity", ("proximity", RiftRange)), uid, uid);
|
|
return;
|
|
}
|
|
}
|
|
|
|
// cant put a rift on solars
|
|
foreach (var tile in grid.GetTilesIntersecting(new Circle(xform.WorldPosition, RiftTileRadius), false))
|
|
{
|
|
if (!tile.IsSpace(_tileDef))
|
|
continue;
|
|
|
|
_popup.PopupEntity(Loc.GetString("carp-rift-space-proximity", ("proximity", RiftTileRadius)), uid, uid);
|
|
return;
|
|
}
|
|
|
|
var carpUid = Spawn(component.RiftPrototype, xform.MapPosition);
|
|
component.Rifts.Add(carpUid);
|
|
Comp<DragonRiftComponent>(carpUid).Dragon = uid;
|
|
}
|
|
|
|
// TODO: just make this a move speed modifier component???
|
|
private void OnDragonMove(EntityUid uid, DragonComponent component, RefreshMovementSpeedModifiersEvent args)
|
|
{
|
|
if (component.Weakened)
|
|
{
|
|
args.ModifySpeed(0.5f, 0.5f);
|
|
}
|
|
}
|
|
|
|
private void OnMobStateChanged(EntityUid uid, DragonComponent component, MobStateChangedEvent args)
|
|
{
|
|
// Deletes all rifts after dying
|
|
if (args.NewMobState != MobState.Dead)
|
|
return;
|
|
|
|
if (component.SoundDeath != null)
|
|
_audio.PlayPvs(component.SoundDeath, uid);
|
|
|
|
// objective is explicitly not reset so that it will show how many you got before dying in round end text
|
|
DeleteRifts(uid, false, component);
|
|
}
|
|
|
|
private void OnCreated(EntityUid uid, DragonComponent comp, ref GenericAntagCreatedEvent args)
|
|
{
|
|
var mindId = args.MindId;
|
|
var mind = args.Mind;
|
|
|
|
_role.MindAddRole(mindId, new DragonRoleComponent(), mind);
|
|
_role.MindAddRole(mindId, new RoleBriefingComponent()
|
|
{
|
|
Briefing = Loc.GetString("dragon-role-briefing")
|
|
}, mind);
|
|
}
|
|
|
|
private void Roar(EntityUid uid, DragonComponent comp)
|
|
{
|
|
if (comp.SoundRoar != null)
|
|
_audio.PlayPvs(comp.SoundRoar, uid);
|
|
}
|
|
|
|
/// <summary>
|
|
/// Delete all rifts this dragon made.
|
|
/// </summary>
|
|
/// <param name="uid">Entity id of the dragon</param>
|
|
/// <param name="resetRole">If true, the role's rift count will be reset too</param>
|
|
/// <param name="comp">The dragon component</param>
|
|
public void DeleteRifts(EntityUid uid, bool resetRole, DragonComponent? comp = null)
|
|
{
|
|
if (!Resolve(uid, ref comp))
|
|
return;
|
|
|
|
foreach (var rift in comp.Rifts)
|
|
{
|
|
QueueDel(rift);
|
|
}
|
|
|
|
comp.Rifts.Clear();
|
|
|
|
// stop here if not trying to reset the objective's rift count
|
|
if (!resetRole || !TryComp<MindContainerComponent>(uid, out var mindContainer) || !mindContainer.HasMind)
|
|
return;
|
|
|
|
var mind = Comp<MindComponent>(mindContainer.Mind.Value);
|
|
foreach (var objId in mind.AllObjectives)
|
|
{
|
|
if (_objQuery.TryGetComponent(objId, out var obj))
|
|
{
|
|
_carpRifts.ResetRifts(objId, obj);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Increment the dragon role's charged rift count.
|
|
/// </summary>
|
|
public void RiftCharged(EntityUid uid, DragonComponent? comp = null)
|
|
{
|
|
if (!Resolve(uid, ref comp))
|
|
return;
|
|
|
|
if (!TryComp<MindContainerComponent>(uid, out var mindContainer) || !mindContainer.HasMind)
|
|
return;
|
|
|
|
var mind = Comp<MindComponent>(mindContainer.Mind.Value);
|
|
foreach (var objId in mind.AllObjectives)
|
|
{
|
|
if (_objQuery.TryGetComponent(objId, out var obj))
|
|
{
|
|
_carpRifts.RiftCharged(objId, obj);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
/// <summary>
|
|
/// Do everything that needs to happen when a rift gets destroyed by the crew.
|
|
/// </summary>
|
|
public void RiftDestroyed(EntityUid uid, DragonComponent? comp = null)
|
|
{
|
|
if (!Resolve(uid, ref comp))
|
|
return;
|
|
|
|
// do reset the rift count since crew destroyed the rift, not deleted by the dragon dying.
|
|
DeleteRifts(uid, true, comp);
|
|
|
|
// We can't predict the rift being destroyed anyway so no point adding weakened to shared.
|
|
comp.WeakenedAccumulator = comp.WeakenedDuration;
|
|
_movement.RefreshMovementSpeedModifiers(uid);
|
|
_popup.PopupEntity(Loc.GetString("carp-rift-destroyed"), uid, uid);
|
|
}
|
|
}
|