mirror of
https://github.com/WWhiteDreamProject/wwdpublic.git
synced 2026-04-17 21:48:58 +03:00
## Mirror of PR #26292: [Code cleanup: Purge calls to obsolete EntityCoordinates methods](https://github.com/space-wizards/space-station-14/pull/26292) from <img src="https://avatars.githubusercontent.com/u/10567778?v=4" alt="space-wizards" width="22"/> [space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14) ###### `f4cb02fb0ca385c858569c07c51afb0d24ade949` PR opened by <img src="https://avatars.githubusercontent.com/u/85356?v=4" width="16"/><a href="https://github.com/Tayrtahn"> Tayrtahn</a> at 2024-03-20 16:04:43 UTC --- PR changed 34 files with 70 additions and 56 deletions. The PR had the following labels: - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Cleaned up some outdated code. > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > Clean code is happy code. > > ## Technical details > <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> > Updated all calls to obsolete EntityCoordinates methods (ToMap, ToMapPos, FromMap, ToVector2i, InRange) to non-obsolete ones (by passing in SharedTransformSystem as an arg). > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > Code > - [X] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > 🆑 > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > </details> --------- Signed-off-by: VMSolidus <evilexecutive@gmail.com> Co-authored-by: SimpleStation14 <Unknown> Co-authored-by: VMSolidus <evilexecutive@gmail.com>
165 lines
4.7 KiB
C#
165 lines
4.7 KiB
C#
using Content.Client.Administration.Managers;
|
|
using Content.Client.Movement.Systems;
|
|
using Content.Shared.Sandbox;
|
|
using Robust.Client.Console;
|
|
using Robust.Client.Placement;
|
|
using Robust.Client.Placement.Modes;
|
|
using Robust.Shared.Map;
|
|
using Robust.Shared.Player;
|
|
|
|
namespace Content.Client.Sandbox
|
|
{
|
|
public sealed class SandboxSystem : SharedSandboxSystem
|
|
{
|
|
[Dependency] private readonly IClientAdminManager _adminManager = default!;
|
|
[Dependency] private readonly IClientConsoleHost _consoleHost = default!;
|
|
[Dependency] private readonly IMapManager _map = default!;
|
|
[Dependency] private readonly IPlacementManager _placement = default!;
|
|
[Dependency] private readonly ContentEyeSystem _contentEye = default!;
|
|
[Dependency] private readonly SharedTransformSystem _transform = default!;
|
|
|
|
private bool _sandboxEnabled;
|
|
public bool SandboxAllowed { get; private set; }
|
|
public event Action? SandboxEnabled;
|
|
public event Action? SandboxDisabled;
|
|
|
|
public override void Initialize()
|
|
{
|
|
_adminManager.AdminStatusUpdated += CheckStatus;
|
|
SubscribeNetworkEvent<MsgSandboxStatus>(OnSandboxStatus);
|
|
}
|
|
|
|
private void CheckStatus()
|
|
{
|
|
var currentStatus = _sandboxEnabled || _adminManager.IsActive();
|
|
if (currentStatus == SandboxAllowed)
|
|
return;
|
|
SandboxAllowed = currentStatus;
|
|
if (SandboxAllowed)
|
|
{
|
|
SandboxEnabled?.Invoke();
|
|
}
|
|
else
|
|
{
|
|
SandboxDisabled?.Invoke();
|
|
}
|
|
}
|
|
|
|
public override void Shutdown()
|
|
{
|
|
_adminManager.AdminStatusUpdated -= CheckStatus;
|
|
base.Shutdown();
|
|
}
|
|
|
|
private void OnSandboxStatus(MsgSandboxStatus ev)
|
|
{
|
|
SetAllowed(ev.SandboxAllowed);
|
|
}
|
|
|
|
private void SetAllowed(bool sandboxEnabled)
|
|
{
|
|
_sandboxEnabled = sandboxEnabled;
|
|
CheckStatus();
|
|
}
|
|
|
|
public void Respawn()
|
|
{
|
|
RaiseNetworkEvent(new MsgSandboxRespawn());
|
|
}
|
|
|
|
public void GiveAdminAccess()
|
|
{
|
|
RaiseNetworkEvent(new MsgSandboxGiveAccess());
|
|
}
|
|
|
|
public void GiveAGhost()
|
|
{
|
|
RaiseNetworkEvent(new MsgSandboxGiveAghost());
|
|
}
|
|
|
|
public void Suicide()
|
|
{
|
|
RaiseNetworkEvent(new MsgSandboxSuicide());
|
|
}
|
|
|
|
public bool Copy(ICommonSession? session, EntityCoordinates coords, EntityUid uid)
|
|
{
|
|
if (!SandboxAllowed)
|
|
return false;
|
|
|
|
// Try copy entity.
|
|
if (uid.IsValid()
|
|
&& EntityManager.TryGetComponent(uid, out MetaDataComponent? comp)
|
|
&& !comp.EntityDeleted)
|
|
{
|
|
if (comp.EntityPrototype == null || comp.EntityPrototype.NoSpawn || comp.EntityPrototype.Abstract)
|
|
return false;
|
|
|
|
if (_placement.Eraser)
|
|
_placement.ToggleEraser();
|
|
|
|
_placement.BeginPlacing(new()
|
|
{
|
|
EntityType = comp.EntityPrototype.ID,
|
|
IsTile = false,
|
|
TileType = 0,
|
|
PlacementOption = comp.EntityPrototype.PlacementMode
|
|
});
|
|
return true;
|
|
}
|
|
|
|
// Try copy tile.
|
|
if (!_map.TryFindGridAt(coords.ToMap(EntityManager, _transform), out _, out var grid) || !grid.TryGetTileRef(coords, out var tileRef))
|
|
return false;
|
|
|
|
if (_placement.Eraser)
|
|
_placement.ToggleEraser();
|
|
|
|
_placement.BeginPlacing(new()
|
|
{
|
|
EntityType = null,
|
|
IsTile = true,
|
|
TileType = tileRef.Tile.TypeId,
|
|
PlacementOption = nameof(AlignTileAny)
|
|
});
|
|
return true;
|
|
}
|
|
|
|
// TODO: need to cleanup these
|
|
public void ToggleLight()
|
|
{
|
|
_consoleHost.ExecuteCommand("togglelight");
|
|
}
|
|
|
|
public void ToggleFov()
|
|
{
|
|
_contentEye.RequestToggleFov();
|
|
}
|
|
|
|
public void ToggleShadows()
|
|
{
|
|
_consoleHost.ExecuteCommand("toggleshadows");
|
|
}
|
|
|
|
public void ToggleSubFloor()
|
|
{
|
|
_consoleHost.ExecuteCommand("showsubfloor");
|
|
}
|
|
|
|
public void ShowMarkers()
|
|
{
|
|
_consoleHost.ExecuteCommand("showmarkers");
|
|
}
|
|
|
|
public void ShowBb()
|
|
{
|
|
_consoleHost.ExecuteCommand("physics shapes");
|
|
}
|
|
|
|
public void MachineLinking()
|
|
{
|
|
_consoleHost.ExecuteCommand("signallink");
|
|
}
|
|
}
|
|
}
|