mirror of
https://github.com/WWhiteDreamProject/wwdpublic.git
synced 2026-04-18 05:59:03 +03:00
b1c29bc460
# Description
Fixes notifications so that they always trigger when the chat is not
open, fixes a possible exploit where a user can send a message that is
longer than the max message length, and improves the UX of NanoChat in a
few areas.
Original message from
https://github.com/Goob-Station/Goob-Station/pull/1313:
> Fixed NanoChat message notifications not showing up in situations
where you'd definitely expect them to occur.
>
> Now, for a chat to not send a notification upon a new message, three
conditions need to be fulfilled:
> - You don't have the chat muted
> - Your PDA UI is open
> - You have NanoChat as your open program
> - Your currently-selected chat is the aforementioned chat
More changes:
- Validate NanoChat message length & chat name/job title length on the
server
c063001ca9.
-If they are too long, they will be truncated to the maximum length.
- Improve the UI for editing a chat:
- Added a proper icon (used to be the letter E) for the Edit Chat
button.
- The Edit Chat popup now has correct text: the title is now "Edit a
contact", not "Add a new chat" and the Create button has been renamed to
the Confirm button.
- Editing a chat no longer deselects the current chat.
- This is done by adding a new NanoChatUiMessageType entry, `EditChat`
and a new server-side handler function just for chat edits. The previous
edit chat method simply *deleted* the chat from the client and created a
new one.
- Form validation is now more robust: you can now only submit the edit
if you've made changes to the name or job title.
- Fixed NanoChat not appearing in PDAs with more than 5 pre-installed
programs by increasing the PDA disk space (max program count) from 5 to
8, the current disk space in Wizden.
- The job title now appears on the notification title.
- The title will be truncated if it's too long.
- Improved form validation on the New Chat popup by only allowing users
to submit if the Number field is 4 numbers long. Previously, inputs like
"0" "12" "289" were valid which is ultimately incorrect as phone numbers
function more like strings that just happen to be digit-only and less
like actual numbers.
- The left chat list will now truncate names and job titles if they're
too long.
## Changelog
🆑 Skubman
- add: NanoChat message notifications will now show you the job title of
the sender alongside their name.
- add: The NanoChat edit button now has a proper icon.
- tweak: The disk space (max amount of installable programs) on PDAs has
been increased from 5 to 8. This also fixes a bug where NanoChat was not
being installed on PDAs with more than 5 pre-installed cartridges.
- tweak: The character limit for names and job titles in NanoChat has
been increased to their actual limit on ID cards (30 characters).
- tweak: NanoChat chat list names/titles and notification titles that
are too long will be shortened, indicated with "..." at the end.
- tweak: The NanoChat edit popup now displays the correct text, instead
of appearing identical to the new chat popup.
- fix: NanoChat will now send a new message notification no matter what
if you don't have the chat open.
- fix: Editing a chat in NanoChat no longer deselects that chat.
- fix: Fixed a issue where users could potentially send NanoChat
messages longer than the maximum allowed message length.
- fix: Fixed being able to create a new chat when you haven't typed in 4
digits in the number field.
(cherry picked from commit f11d2e7976491a5c95aeb36eaa7a313624197a88)
48 lines
1.4 KiB
C#
48 lines
1.4 KiB
C#
using Content.Shared.Containers.ItemSlots;
|
|
using Robust.Shared.GameStates;
|
|
|
|
namespace Content.Shared.CartridgeLoader;
|
|
|
|
[RegisterComponent, NetworkedComponent]
|
|
public sealed partial class CartridgeLoaderComponent : Component
|
|
{
|
|
public const string CartridgeSlotId = "Cartridge-Slot";
|
|
|
|
[DataField]
|
|
public ItemSlot CartridgeSlot = new();
|
|
|
|
/// <summary>
|
|
/// List of programs that come preinstalled with this cartridge loader
|
|
/// </summary>
|
|
[DataField("preinstalled")] // TODO remove this and use container fill.
|
|
public List<string> PreinstalledPrograms = new();
|
|
|
|
/// <summary>
|
|
/// The currently running program that has its ui showing
|
|
/// </summary>
|
|
[ViewVariables(VVAccess.ReadWrite)]
|
|
public EntityUid? ActiveProgram = default;
|
|
|
|
/// <summary>
|
|
/// The list of programs running in the background, listening to certain events
|
|
/// </summary>
|
|
[ViewVariables]
|
|
public readonly List<EntityUid> BackgroundPrograms = new();
|
|
|
|
/// <summary>
|
|
/// The maximum amount of programs that can be installed on the cartridge loader entity
|
|
/// </summary>
|
|
[DataField]
|
|
public int DiskSpace = 8;
|
|
|
|
/// <summary>
|
|
/// Controls whether the cartridge loader will play notifications if it supports it at all
|
|
/// TODO: Add an option for this to the PDA
|
|
/// </summary>
|
|
[DataField]
|
|
public bool NotificationsEnabled = true;
|
|
|
|
[DataField(required: true)]
|
|
public Enum UiKey = default!;
|
|
}
|