wwdpublic

mirror of https://github.com/WWhiteDreamProject/wwdpublic.git synced 2026-04-26 01:57:51 +03:00

Files

Mnemotechnican faa239a6e5 Fix 125 Toolshed Commands Being Unusable for Anyone without +HOST (#572 )

# Description
For reasons unknown, AdminManager has two command permission managers:
_commandPermissions and _toolshedCommandPermissions. It used to load
normal command permissions into the former, and toolshed command
permissions into the latter. Since _toolshedCommandPermissions is NEVER
actually used in checking whether a player can execute a command, all
toolshed commands remained unavailable to anyone without +HOST.

This PR provides a bandaid fix for that: it makes it so that the same
permissions are loaded into both managers at the same time. It's
necessary to load them into _commandPermissions in order to allow
regular players to execute them, and it's also necessary to load them
into _toolshedCommandPermissions because otherwise the ToolshedManager
will complain about those commands lacking permission flags.

This should also fixes some commands such as `spawn`, `pos`, `comp`
being inaccessible to admins with +DEBUG and more.

<details><summary><h1>Media</h1></summary><p>


![image](https://github.com/user-attachments/assets/12afedef-0db3-43f2-8335-e95582a4a3f9)


![image](https://github.com/user-attachments/assets/f23ae98a-1e1b-4d28-8446-ca60e8239a03)

Admin-only commands are unaffected:


![image](https://github.com/user-attachments/assets/d64a5a8d-f184-4a9d-bc71-ae80635df626)


</p></details>

---

# Changelog

🆑
- fix: Fixed toolshed command permissions. This will mostly affect
admins who don't have full host access.

2024-07-29 06:54:01 +01:00