Files
wwdpublic/Content.Client
SimpleStation14 cb108dd012 Mirror: Prevents FloorOcclusion from breaking rendering (#136)
## Mirror of PR #25960: [Prevents FloorOcclusion from breaking
rendering](https://github.com/space-wizards/space-station-14/pull/25960)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `717da4a8f3b6d68cb17d6bf75c84eae6ce46e1b5`

PR opened by <img
src="https://avatars.githubusercontent.com/u/68350815?v=4"
width="16"/><a href="https://github.com/DoutorWhite"> DoutorWhite</a> at
2024-03-10 08:16:46 UTC
PR merged by <img
src="https://avatars.githubusercontent.com/u/19864447?v=4"
width="16"/><a href="https://github.com/web-flow"> web-flow</a> at
2024-03-10 17:07:24 UTC

---

PR changed 1 files with 6 additions and 1 deletions.

The PR had the following labels:


---

<details open="true"><summary><h1>Original Body</h1></summary>

> ## About the PR
> 
> This PR adds a condition so that FloorOcclusionSystem does not
overwrite existing PostShaders.
> 
> ## Why / Balance
> 
> Because if a Mutable PostShader already exists, the
FloorOcclusionSystem will simply replace it with its own, which is
Immutable, which creates conflict with other systems and breaks the
game's rendering and UI, to the point that all clients are immediately
left with a black screen and the FPS drops to 0, eventually resulting in
a crash. There is an in-game situation where this bug is replicable and
I will not address it publicly in this PR because it is potentially game
breaking, if you want you can chat with me via DM on discord (my name is
the same).
> 
> ## Technical details
> 
> Adds an extra condition so that the FloorOcclusionSystem does not
replace the PostShader of other systems. Honestly this is a workaround,
this system should be redone in the engine, but I don't have the
knowledge to do so.
> 
> ## Media
> 
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> The FloorOcclusionSystem should no longer work if there is already
another PostShader in sprite.
> 
> **Changelog**
> 
> 🆑
> - fix: Prevents rendering from crashing in certain scenarios
> 


</details>

Co-authored-by: DoutorWhite <68350815+DoutorWhite@users.noreply.github.com>
2024-05-04 20:42:47 -04:00
..
2024-02-08 12:17:35 +01:00
2023-10-03 14:15:46 -05:00
2023-10-03 14:15:46 -05:00
2024-03-08 12:54:53 +01:00
2024-02-08 12:06:49 +01:00
2024-03-08 09:52:50 +01:00
2024-02-18 23:23:34 +01:00
2024-03-07 01:03:46 +01:00
2024-03-01 01:04:24 +01:00
2024-02-09 16:51:32 +00:00
2023-10-03 14:15:46 -05:00
2024-03-05 09:49:43 +01:00
2023-12-02 20:16:36 +01:00
2024-03-05 09:48:41 +01:00
2024-01-26 21:43:12 +01:00
2023-11-19 22:09:46 +01:00
2024-01-21 19:58:28 +01:00
2023-12-02 20:16:36 +01:00
2024-01-26 21:47:47 +01:00
2024-02-18 23:27:28 +01:00
2024-01-26 21:50:20 +01:00
2023-10-24 18:04:06 +02:00
2024-03-07 01:06:59 +01:00
2023-10-03 14:15:46 -05:00
2023-10-03 14:15:46 -05:00
2023-10-08 19:52:10 +02:00
2024-02-18 23:27:28 +01:00
2024-02-08 12:10:34 +01:00
2024-02-18 23:27:28 +01:00
2024-01-28 00:33:40 +01:00
2024-01-22 18:38:38 +01:00
2023-11-12 20:35:48 +01:00
2023-12-02 20:16:36 +01:00
2023-12-02 20:16:36 +01:00