Commit Graph

18 Commits

Author SHA1 Message Date
deltanedas
f1e472608b biggest gridinv update OF ALL TIME (#25834)
* add SaveItemLocation keybind

* make item direction public to avoid having to change between Angle for no reason

* add item location saving

* show

* Added a better save keybind, made it draw saved positions, and trying to save in a position it has already been saved in removes that position.

* w

* code style

* Make taken spots appear blue

* style

* !

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: notquitehadouken <tripwiregamer@gmail.com>
Co-authored-by: I.K <45953835+notquitehadouken@users.noreply.github.com>
2024-07-11 19:48:51 -07:00
SimpleStation14
dfeb3b986d Mirror: Fix Recycled Containers Deleting Items Inside Them (#267)
## Mirror of PR #26045: [Fix recycled containers deleting items inside
them](https://github.com/space-wizards/space-station-14/pull/26045) from
<img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `d7484ae9f57477a5ec5c575e3077aa94c0564db6`

PR opened by <img
src="https://avatars.githubusercontent.com/u/83650252?v=4"
width="16"/><a href="https://github.com/SlamBamActionman">
SlamBamActionman</a> at 2024-03-12 16:16:42 UTC

---

PR changed 2 files with 19 additions and 1 deletions.

The PR had the following labels:
- Status: Awaiting Changes


---

<details open="true"><summary><h1>Original Body</h1></summary>

> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> 
> Right now you can delete any item that fits in a survival box by
placing it inside of one and then recycling the box in a
Recycler/Material Reclaimer. This PR fixes this by dumping out any item
inside containers.
> 
> - For Reclaimers, any recyclable items inside the container get placed
on top of the Reclaimer.
> - For Recyclers, any recyclable items inside the container get
recursively recycled as well.
> 
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> 
> I doubt it's intended behavior to be able to effectively delete any
item that fits in a box. Also ensures a recycled box provides the
correct amount of material as its contents also get recycled.
> 
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> 
> When trying to recycle, once all checks are passed it iterates through
the object's containers if it has any and dumps out any items onto the
machine doing the recycling.
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
>
![image](https://github.com/space-wizards/space-station-14/assets/83650252/9e95b099-ab95-449d-b5a1-25b80afda8cd)
> The result of recycling a survival box in a Recycler/Reclaimer.
> 
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> 🆑
> - fix: Recyclers no longer delete items stored inside of recycled
entities.
> 


</details>

---------

Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
2024-07-11 17:43:32 -07:00
Krunklehorn
1fb8bad18f Weight based AreaInsert and Dumpable delay, a janitor qol tweak (#24899)
Weight based delay, retuned average, fixed comments

(cherry picked from commit c775410370a650aa51a1feda99f45cefda0c811e)
2024-03-07 01:17:27 +01:00
Debug
d8df4327ec Fix PseudoItems (#821)
* Fix PseudoItem

* Add pain

* Cancel attack events
2024-02-12 21:52:49 +01:00
metalgearsloth
62c2728e38 Fix storage state (#23852)
slughands

(cherry picked from commit 24f8da8f0ce01b3523434e954d4d71e8193e75b5)
2024-01-26 22:22:41 +01:00
metalgearsloth
404ac576b8 Fix storagecomp serialization (#23780)
* Fix storagecomp serialization

* Fix state

(cherry picked from commit b22c9aa5e265994f87c9a3f41a95e0aef611b61d)
2024-01-26 22:17:53 +01:00
Nemanja
57d762185c Allow storage to specify a default orientation for stored items. (#23594)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
(cherry picked from commit a448e5fa567e8e781b9b3093376312cc9f654533)
2024-01-26 21:47:41 +01:00
Debug
e644725860 Fix missing imports 2024-01-22 18:55:26 +01:00
Leon Friedrich
46f411ef85 Cache ItemSizePrototype in StorageSystem (#22611)
(cherry picked from commit 364ecae94f66dc0a4e87760def5203cca4745cee)
2024-01-22 18:44:26 +01:00
Debug
18f0af1f68 Implement gridinv, proper (#703)
* Implement gridinv, 1500 squashed commits :elp:

* Me when

* Linter errors

* Fix katana belts
2024-01-21 19:58:28 +01:00
Debug
985b2f96f9 Prevent pseudoitems from being transferred between bags (#553)
* Update PseudoItemSystem.cs

* Rider full cleanup

* Also abort in sharedstorage

* Make the comp shared

* Why drop the bags?
2023-12-29 20:38:03 +01:00
Leon Friedrich
adee2a7465 Fix various errors/exceptions (#22841)
* Fix entity storage localization

* Fix HumanoidAppearanceComponent resolve

* Fix null reference exceptions

* Fix duplicate key error

* Fix artifact error spam

* actually maybe this is what its meant to do

* Fix entities playing sounds on deletion
2023-12-22 23:25:06 +01:00
deltanedas
40ec5595be open bag in combat mode (#22512)
* open bag in combat mode

* !!!!!

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2023-12-16 20:23:25 +01:00
metalgearsloth
b1ee2d48ff Unrevert audio (#21330)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2023-12-02 20:16:36 +01:00
Kara
b8f401d664 Bows & arrows (#19771) 2023-09-27 21:59:12 +02:00
metalgearsloth
a7208af7d6 Add ore bag area pickups (#19358) 2023-09-27 21:59:12 +02:00
DrSmugleaf
f1487348b6 Fix failing to insert into storage messages not being localized (#20049) 2023-09-27 21:59:12 +02:00
metalgearsloth
f38f0ab614 Predict StorageComponent (#19682) 2023-09-27 21:59:12 +02:00