Commit Graph

16 Commits

Author SHA1 Message Date
Carlen White
f4e9aaaaf3 Fix Mailing Units (space-wizards/space-station-14#30174 + Other) (#2485)
# Description

_Upstream: space-wizards/space-station-14#30174_

This fixes mailing units so their UI works again alongside their
sprites. It also adds a convenience feature to reset the destination on
send since it can trip up players as it makes sense to put in an item
_then_ choose a location.

# Changelog

🆑
- fix: Mailing Unit UI is now fixed
- fix: Mailing Units' no longer use the wrong sprite when charging
- tweak: Mailing Units clear target on send or selecting the same target

---------

Co-authored-by: themias <89101928+themias@users.noreply.github.com>
2025-07-20 13:38:06 +10:00
brainfood1183
eca325ce16 Toilet Upgrade (needs review) (#22133)
* Toilet Draft

* fixes

* toilets now have secret stash to place items in cistern.

* fixes

* plungers now unblock toilets.

* fix sprite

* new sprites and fix

* fixes

* improve seat sprites.

* fix

* removed visualisersystem changed to genericvisualizers

* flush sound for toilets and copyright for toilet sprites.

* fix atrributions

* fixes

* fix datafield flushtime

* sprite improvements

* fixes

* multiple changes

* fix

* fix

* fixes remove vv

* moved stash related functions to secret stash system from toilet.

* fix

* fix

* changes for recent review.

* fix

* fix
2024-07-11 20:43:35 -07:00
SimpleStation14
7c55b6afc6 Mirror: Fix mailing units turning into disposal units while recharging. (#387)
## Mirror of PR #26383: [Fix mailing units turning into disposal units
while
recharging.](https://github.com/space-wizards/space-station-14/pull/26383)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `94e4755a8de6885c97fac1cfb767144e8e07981a`

PR opened by <img
src="https://avatars.githubusercontent.com/u/32041239?v=4"
width="16"/><a href="https://github.com/nikthechampiongr">
nikthechampiongr</a> at 2024-03-24 11:57:45 UTC

---

PR changed 2 files with 14 additions and 3 deletions.

The PR had the following labels:
- Status: Needs Review


---

<details open="true"><summary><h1>Original Body</h1></summary>

> fixes #18275
> <!-- Please read these guidelines before opening your PR:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
> <!-- The text between the arrows are comments - they will not be
visible on your PR. -->
> 
> ## About the PR
> <!-- What did you change in this PR? -->
> This fixes mailing units appearing as disposal units when flushed.
> 
> ## Technical details
> <!-- If this is a code change, summarize at high level how your new
code works. This makes it easier to review. -->
> The states were hardcoded.
> 
> Now they are not.
> 
> Bug seems to have been introduced in #17803 as a part of a larger
refactor on disposal units. To my understanding, this was made in error
with the logic that no other objects would ever have a different
animation when flushing and charging but I am not sure.
> 
> ## Media
> <!-- 
> PRs which make ingame changes (adding clothing, items, new features,
etc) are required to have media attached that showcase the changes.
> Small fixes/refactors are exempt.
> Any media may be used in SS14 progress reports, with clear credit
given.
> 
> If you're unsure whether your PR will require media, ask a maintainer.
> 
> Check the box below to confirm that you have in fact seen this (put an
X in the brackets, like [X]):
> -->
> 
> - [x] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
> 
> **Changelog**
> <!--
> Make players aware of new features and changes that could affect how
they play the game by adding a Changelog entry. Please read the
Changelog guidelines located at:
https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog
> -->
> 
> <!--
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑
> - add: Added fun!
> - remove: Removed fun!
> - tweak: Changed fun!
> - fix: Fixed fun!
> -->
> 🆑 
> - fix: Mailing units no longer spontaneously turn into disposal units
when flushed.


</details>

Co-authored-by: SimpleStation14 <Unknown>
2024-05-12 00:47:42 -04:00
metalgearsloth
b1ee2d48ff Unrevert audio (#21330)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2023-12-02 20:16:36 +01:00
metalgearsloth
c9648da984 Content update for NetEntities (#18935) 2023-09-27 21:59:12 +02:00
faint
0b9b4f6532 Fix dumping into disposals (#19736) 2023-09-02 00:02:35 -04:00
metalgearsloth
b08967b752 Remove disposals compref (#19558)
This one was relatively painless.
2023-08-30 19:08:23 -06:00
metalgearsloth
08d3b17bc0 Remove redundant disposals layer (#17848) 2023-07-06 14:41:35 +10:00
metalgearsloth
3eb93988e5 Disposals refactor (#17803) 2023-07-06 13:39:34 +10:00
TemporalOroboros
9849737e5a Cleans up warnings in disposals (#17419) 2023-06-22 00:31:19 +10:00
eoineoineoin
be94048932 Convert DisposalUnitVisualizer to VisualizerSystem (#13637) 2023-02-03 18:26:50 -04:00
Julian Giebel
b2436c22a7 Adds disposal mailing units (again) (#7630) 2022-08-13 22:57:25 -07:00
Vera Aguilera Puerto
680ad72939 And a bunch more. 2021-12-08 12:19:45 +01:00
Vera Aguilera Puerto
5cd42c9ad6 Inline UID 2021-12-03 15:53:09 +01:00
Vera Aguilera Puerto
69b270017b Inline TryGetComponent completely, for real 2021-12-03 14:17:01 +01:00
metalgearsloth
4da74d0ee4 Refactor disposals to ECS (#4418)
* ECS up disposals

Also significantly reduced its CPU usage.

* Make update significantly less S L O W

* Start units pressurised

* Client-side flush lerping

* Fix powered not toggling UI

* Fix flush button

* InteractUsing

* Minor optimisations

* Fix collisions

* Make visual state ECS

* Almost done with shared

* Most stuff moved

* Optimise item sleeping
2021-08-12 13:40:38 +10:00