Commit Graph

9 Commits

Author SHA1 Message Date
Timfa
b188acf886 Update Content.Shared/Gibbing/Systems/GibbingSystem.cs
Signed-off-by: Timfa <timfalken@hotmail.com>
(cherry picked from commit 5354e25eca2e4aca0d77dd02a9a54559ac2773a0)
2025-03-29 16:40:11 +03:00
Space
c2e74312ee fixed typo and rogue white space.
(cherry picked from commit 0cb83b0128d43cbff717f2219354e7c3b45df6d5)
2025-03-29 16:39:41 +03:00
Space
e0a7ef5103 BaseContainer access made it possible for mid loop container changes. Used ToList() to create a list that is not modified mid loop. Applied changes to both dropped and gibbed, even if the problem only seemed to triggered on dropped right now. To keep it consistant.
(cherry picked from commit 3ba10657da0a9fbc55d4224475f9af829cafe3c4)
2025-03-29 16:39:32 +03:00
Space
a51fcdb05f Reverted back to forEach loop, but used a list for looping that is not changed by external events like the BaseContainer. Minimizing logic changes.
(cherry picked from commit 6e00e515a1c42caf73a6328f06f194216628e367)
2025-03-29 16:39:25 +03:00
Space
8878ba242f removed unused using
(cherry picked from commit 9e7503e2ecec772cfeea8654b2eecb4d6a9bdade)
2025-03-29 16:39:19 +03:00
Space
0650687ca0 events could remove container sibling component mid for loop causing a exception.
(cherry picked from commit 8fbdad4d247942bc5e32bbfcf0cab4c4d7c8f483)
2025-03-29 16:39:13 +03:00
Pieter-Jan Briers
ccea85136b Random spontaneous cleanup PR (#25131)
* Use new Subs.CVar helper

Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.

This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.

* Fix a bunch of warnings

* More warning fixes

* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.

* Get rid of some more ISerializationHooks for enums

* And a little more

* Apply suggestions from code review

Co-authored-by: 0x6273 <0x40@keemail.me>

---------

Co-authored-by: 0x6273 <0x40@keemail.me>
(cherry picked from commit 68ce53ae17985876d6d112b764b2144964a9f42e)
2024-02-18 23:02:29 +01:00
Jezithyr
9c6a9e23f0 Gibbing contents hotfix (#25114)
Fixing gibbing contents not respecting Include/Exclude container lists. This is currently unused

(cherry picked from commit 8e59b4f50546c9ba53981ab4b22bcd1595d775d6)
2024-02-18 22:46:25 +01:00
Jezithyr
6737912059 Gibbing refactor (Per-part gibbing and giblet throwing!) (#24989)
* Moving Gibbing rework out from medrefactor into it's own PR

* Re-enabled warning for missing gibbable on TryGibEntity

* Implemented better logic for gibbing failover and better logging

* Allowing audio params and drop scattering customization per component. Created UnGibbable organ base types and made brains ungibbable.
Removed delete brain from gibBody function. Artifact crusher does not destroy brains anymore. It only destroyed brains before not other organs which was wierd.

* Update Content.Shared/Body/Systems/SharedBodySystem.Body.cs

Fixing space for multiplication

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Added event raised when attempting to gib contained entities to allow modification of allowed and excluded container ids

* removing audioParams var from component (sound specifier includes it)

* Fixing signature

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
(cherry picked from commit 541d8f8715e4e74a77501863c2573aaa1eb33add)
2024-02-18 22:46:02 +01:00