Commit Graph

7 Commits

Author SHA1 Message Date
SimpleStation14
10f5e66cdb Mirror: Convert "IgnoreWeatherComponent" into "BlockWeatherComponent" (#220)
## Mirror of PR #26135: [Convert "IgnoreWeatherComponent" into
"BlockWeatherComponent"](https://github.com/space-wizards/space-station-14/pull/26135)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `4aa72af574cc7a3370085fb70831fbde1df29077`

PR opened by <img
src="https://avatars.githubusercontent.com/u/96445749?v=4"
width="16"/><a href="https://github.com/TheShuEd"> TheShuEd</a> at
2024-03-15 09:30:10 UTC

---

PR changed 10 files with 12 additions and 11 deletions.

The PR had the following labels:


---

<details open="true"><summary><h1>Original Body</h1></summary>

> ## About the PR
> inverting the logic of the component. Now inversely, tagging an entity
with this component will cause it to block weather if it is attached to
the floor. Previously, this conversely excluded the entity from weather
checking, and only applied to trees on planets.
> 
> It now blocks rain on walls, windows, airlocks. 
> 
> ## Why / Balance
> 95% of the structures in the game should not block weather. Railings,
tables, chairs, fences all logically allow water to pass through. We're
making a map under rainy skies, and it's annoying.
>
![image](https://github.com/space-wizards/space-station-14/assets/96445749/d383e2c1-17a3-4c83-8620-e558f3ba9b3c)
>
![image](https://github.com/space-wizards/space-station-14/assets/96445749/f872d0ca-aac2-43b0-a2c4-ba0ed29443f5)
>
![image](https://github.com/space-wizards/space-station-14/assets/96445749/4b225631-0ec6-45d7-911d-76aa35128b35)
> 
> this will also be useful for the visual part of expeditions or
something with planets when weather is added there in the future


</details>

Co-authored-by: SimpleStation14 <Unknown>
2024-05-12 00:02:50 -04:00
metalgearsloth
e6737b6f50 Fix weather audio (#21949) 2023-12-02 20:25:44 +01:00
metalgearsloth
b1ee2d48ff Unrevert audio (#21330)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2023-12-02 20:16:36 +01:00
DrSmugleaf
9cc8a7fc81 Remove 700 usages of Component.Owner (#21100) 2023-10-20 15:31:13 +02:00
metalgearsloth
22ae0e7ed8 Fix weather blocking in some instances (#14561) 2023-03-11 14:11:19 +11:00
metalgearsloth
46b27a68ff Weather tweaks (#14271) 2023-03-07 12:28:50 +11:00
metalgearsloth
81a1c6d7de Weather effects (#12528)
Co-authored-by: metalgearsloth <metalgearsloth@gmail.com>
2023-01-17 20:26:52 +11:00