Commit Graph

67 Commits

Author SHA1 Message Date
Cojoke
8f355ef036 Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem (#30084)
* Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem

* guap

* More fixes

* Wait you can do that?

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>

(cherry picked from commit ef1fadf2752789ffc4f59309e2dd7490aee6f4e7)
2025-07-20 14:08:05 +10:00
SlamBamActionman
4959f88522 Better DNA forensics & ReagentData (#26699)
* Added the ability for blood to track DNA using ReagentData; Forensic Scanner now accounts for solution DNA, non-DNA holders have "Unknown DNA"

* Removes touch DNA for puddles, adds DNA to vomit

* DNA now leaves traces in containers and those marked without don't show DNA on scan (except for puddles), gibbed parts have DNA

* Fix stupid metamorphic glass bug grrr

* Removed SpillableComponent since DnaSubstanceTraceComponent is used instead

* Removes data field from maps, adds DNA tracking for some missed items

* Give default value, fix missing values.

* Fixes recipe bug

* Review changes

* Make the Data list into a nullable type

* Revert map changes

* Move gibbed unknown DNA to forensicssystem

(cherry picked from commit 07174d0aaf2832bc6ecc3a6baba21bc0aa5e0556)
2025-07-12 01:47:22 +10:00
Kara
0e9ac91ed3 Resolve 'EntitySystem.Get<T>()' is obsolete in content (#27936)
* PROJECT 0 WARNINGS: Resolve `'EntitySystem.Get<T>()' is obsolete` in content

* pass entman

* dog ass test

* webeditor

(cherry picked from commit 993eef1e7c22b2b79e528967ef5bb669f50236b1)
2025-07-12 01:31:53 +10:00
RocketBoss360
8f4cb8a2b3 Shadowkin Blood Change (#1904)
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Replaces Shadowkin's blood type with black blood, to fit their
pre-existing organ set
<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Add reagent Black Blood
- [x] Change shadowkin blood type and injury color
- [x] Lock in descriptions and exact hex code
- [x] Add artifact trigger

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

![420641667-bde592ce-d26e-4656-ab24-14d85fee4741](https://github.com/user-attachments/assets/1454e659-3ae6-4e07-98fa-f2bc88fd238b)

![420641642-f51cafd2-b1ee-4e64-8e5e-80923feb7e09](https://github.com/user-attachments/assets/1600acf7-7d41-4c54-914b-775fbd29d20e)

</p>
</details>

---

# Changelog

<!--
You can add an author after the `🆑` to change the name that appears
in the changelog (ex: `🆑 Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

🆑

- tweak: Changed shadowkin blood type to black blood, to better fit
their organs' color palette

(cherry picked from commit 33de108fb39d09e2eff5cce586755671007a6746)
2025-03-21 17:06:28 +03:00
Tayrtahn
ac943d9327 Add prediction to Spill Container verb, add dummy TrySpill methods to shared (#25813)
* Moved abstract spill methods to shared; added prediction to spill container verb.

* Rerun tests

* Requested changes

* Note Client behavior in Spill method docs
2024-07-11 20:34:26 -07:00
SimpleStation14
3b2eb1348e Mirror: SlowContactsSystem to SpeedModifierContactsSystem mini rework (#235)
## Mirror of PR #26110: [SlowContactsSystem to
SpeedModifierContactsSystem mini
rework](https://github.com/space-wizards/space-station-14/pull/26110)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `c35ff87e146f0cda7c10782f4ab80b784b51e5fe`

PR opened by <img
src="https://avatars.githubusercontent.com/u/96445749?v=4"
width="16"/><a href="https://github.com/TheShuEd"> TheShuEd</a> at
2024-03-14 09:45:33 UTC

---

PR changed 9 files with 42 additions and 34 deletions.

The PR had the following labels:
- Status: Needs Review


---

<details open="true"><summary><h1>Original Body</h1></summary>

> ## About the PR
> system and components are renamed. It can now be used including to
accelerate entities
> 
> ## Why / Balance
> more reusability for the system
> 
> ## Technical details
> Now the system calculates the arithmetic mean of all the entities that
affects your speed.


</details>

Co-authored-by: SimpleStation14 <Unknown>
2024-05-12 00:33:33 -04:00
stellar-novas
b702cbd41d Code Cleanup: Puddles and Spreaders (#39)
# Description

Ports https://github.com/space-wizards/space-station-14/pull/26102.

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2024-03-27 19:19:13 -04:00
Tayrtahn
b97afd8346 Add prediction for puddle and spillable examines (#25794)
Prediction for puddle and spillable examines

(cherry picked from commit 4943151111c8db9ac94701128b08f857b3abd3e6)
2024-03-07 01:19:36 +01:00
Arendian
b98e16ff53 Spacelube slide (#24801)
* Space lube now makes you slide

* review

* oh lord he slippin

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
(cherry picked from commit 4f3b8d740cecfb736b018fd78a2be71f5397644d)
2024-02-08 12:17:49 +01:00
Kara
d35e2f39a7 Roundstart variation game rules (#24397)
* Raise `StationPostInitEvent` broadcast

* Basic variation pass handling

* standardize names + rule entities

* why does it work like that?

* add to defaults

* light break variation pass

* ent spawn entry

* move some stationevent utility functions to gamerule + add one for finding random tile on specified station

* forgot how statistics works

* powered light variation pass is good now

* station tile count function

* public method to ensure all solutions (for procedural use before mapinit)

* move gamerulesystem utility funcs to partial

* ensure all solutions before spilling in puddlesystem. for use when spilling before mapinit

* trash & puddle variation passes!

* oh yeah

* ehh lets live a little

* std

* utility for game rule check based on comp

* entprotoid the trash spawner oops

* generalize trash variation

* use added instead of started for secret rule

* random cleanup

* generic replacement variation system

* Wall rusting variation rule

* account for modifying while enumerating

* use localaabb

* fix test

* minor tweaks

* reinforced wall replacer + puddletweaker

(cherry picked from commit cc24ba6a317c4bee84ffa1eda8397c255ca92be9)
2024-02-08 12:03:43 +01:00
mr-bo-jangles
7075f5c37d Optimise the puddle system to reach an equilibrium quickly. (#23776)
* Optimise the puddle system to reach an equilibrium quickly.

* Remove use of Linq
Try to be more efficient with Tuples

* review

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
(cherry picked from commit 064d52db412d9cf80ace425db8573aea2dfc7d81)
2024-01-26 22:27:12 +01:00
Kara
03b3e36d43 Examine prediction (#23565)
* Initial prediction

* new group handling

* groups for all examines that use multiple rn

* compile

* why was it doing this??

* handle newlines with sorting properly

(cherry picked from commit 0ae3858b69b695697ea9300609460f8ddb70ebbf)
2024-01-26 21:48:02 +01:00
TemporalOroboros
ce27944275 Revert 'Revert 'Solution Entities'' (#23168)
(cherry picked from commit d23c8d5c19e56a582b6b12f832bd318efbdac7c7)
2024-01-23 23:00:42 +01:00
metalgearsloth
b1ee2d48ff Unrevert audio (#21330)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2023-12-02 20:16:36 +01:00
brainfood1183
4c1c1e43c9 blue blood now requires copper instead of iron to cure bloodloss (#20863)
* blue blood now requires copper instead of iron to cure bloodloss

* arachnid species now needs copper to cure bloodloss and copper pills added to medkits.

* fix puddlesystem proto

* remove the cool

* no longer uses hastag, instead uses custom heart organ and hasorgan.

* fix
2023-11-12 20:29:10 +01:00
Psychpsyo
3fc496001a Soapy Water & Edible Soap (#20364)
* soap reagent and soapy water

* make soapy water recognizable

* Fix tile cleaning bug

CleanDecalsReaction was able to take more than the reactVolume it was given.

* make soapy water an evaporating reagent

* Tile reactions when mopping

* Fix indescribably soap flavor

* Adjust soap flavours

Soap and soapy water now taste clean and syndie soap tastes like punishment.

* Better soap numbers & DeleteOnSolutionEmpty

* Changed TrashOnEmpty to TrashOnSolutionEmpty

* Last TrashOnSolutionEmpty change

* Fix merged code not compiling

* Requested changes.
2023-11-12 20:26:09 +01:00
DrSmugleaf
9cc8a7fc81 Remove 700 usages of Component.Owner (#21100) 2023-10-20 15:31:13 +02:00
TemporalOroboros
8c55d3e5ce Moves SolutionContainerManagerComponent to Shared. (#20944) 2023-10-14 22:07:17 +02:00
Leon Friedrich
ff872bec6a Remove SpreaderNodeGroup (#20230)
* Remove SpreaderNodeGroup

* Fix airtight updates

* more smoke stuff

* more smoke fixes

* wtf is smoke code

* Fix merge

* Fix divide by zero
2023-10-08 19:52:10 +02:00
Leon Friedrich
e4ca6f4fb9 Allow solutions to store extra reagent data (#19323) 2023-09-05 07:55:10 +10:00
metalgearsloth
0f917d22d7 Color flash effect fixes (#18952) 2023-08-10 10:44:52 -07:00
Slava0135
9443cb1d25 Add splash spill effect (#18536) 2023-08-05 21:44:18 +10:00
Vasilis
eda7e744a3 Spilling liquids no longer exposes true identify (#18505)
* mama i did it by myself!

* wait how does this fix it? what???

* oops
2023-07-31 19:15:17 -04:00
Slava0135
7ee91ce4f1 make puddles not appear on space tiles (#17822) 2023-07-05 23:59:48 +10:00
Slava0135
d3f7a9e820 Update puddle stickiness (#16597) 2023-06-03 12:34:43 -07:00
metalgearsloth
cb7f73927d Reduce puddle tile friction (#16375) 2023-05-13 11:45:53 -04:00
PixelTK
8269a500b3 Arachnid species (#13945) 2023-04-30 02:19:06 +10:00
metalgearsloth
f12f277c35 Puddle fixes (#15820) 2023-04-26 21:29:31 +10:00
metalgearsloth
1cde3ff112 Spreaders travels across connected grids and SpreaderIgnore tag (#15419) 2023-04-24 16:04:49 -04:00
metalgearsloth
6076130987 Janitor QoL (#15626) 2023-04-23 18:20:03 +10:00
metalgearsloth
317a4013eb Puddles & spreader refactor (#15191) 2023-04-10 15:37:03 +10:00
Kara
e7e9be0073 Reagent interactivity (pt. 1) (#15130)
* Puddle slippy

* spillable melee

* splash spilling!

* splat melee sound

* p
2023-04-06 16:20:48 -05:00
Slava0135
81159b0ff5 better fluid spreading (#14529) 2023-03-25 01:09:52 +11:00
Leon Friedrich
466384b081 Solution rejig (#12428) 2023-01-12 14:41:40 +11:00
Leon Friedrich
bce1f9fe89 Mopping and puddle tweaks (#13238)
fix undefined
Fixes https://github.com/space-wizards/space-station-14/issues/11830
2022-12-31 22:03:26 -08:00
Willhelm53
a1dcc500a8 Puddle Visuals: ECS/Refactor and fixes (#11941)
* Don't stop me now, cuz I'm havin' such a good time (I'm havin' a ball!)

* YEET

* No changes to intended behaviour at this point. Pretty much just a refactor + bugfixes.

* tweaks to RandomizeState, removing an error caused by setting the state after setting the RSI

* Comments cleanup and removed IsSlippery. To re-add soon for this PR.

* test

* We don't actually use this PuddleGeneric anywhere

* cheeky

* Uncheeky, and tweaks based on #8203

* Recheeky

* A small price to pay for `checks passed`

* Beauty, like ice, our footing does betray; Who can tread sure on the smooth, slippery way

* Undo Slippery Checks

* Begin smoothing. Need to fix the animation-not-playing bug again

* Cleanup

* animation bugfix

* IgnoredComponents tests fix
2022-12-19 20:40:53 -06:00
Ygg01
75ea093d78 Fluid spread refactor (#11908)
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Fix undefined
2022-11-15 22:30:59 +11:00
Kara
459f8d23eb Shards damage barefoot users + steptrigger-related general cleanup (#9585) 2022-07-10 02:28:37 -07:00
metalgearsloth
8905996cfc Make raiselocalevent not broadcast by default (#8998) 2022-06-22 09:53:41 +10:00
keronshb
f7b1bda3e5 Reorders Sound Systems signatures to match Popup Systems. (#8728) 2022-06-13 09:45:47 +10:00
Leon Friedrich
ca7960382b Missing nullables (#8634) 2022-06-04 17:17:48 +10:00
Pieter-Jan Briers
ebfe5e888f Kick mines (real) (#8056)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2022-05-18 14:07:35 +10:00
metalgearsloth
72da2db62d Content changes for grid splitting (#7645) (#7746)
Co-authored-by: Vera Aguilera Puerto <gradientvera@outlook.com>
2022-04-24 13:54:25 +10:00
metalgearsloth
ecaad9c349 Revert "Update submodule (again)" (#7730) 2022-04-24 02:26:00 +10:00
metalgearsloth
8c7772630c Content changes for grid splitting (#7645)
Co-authored-by: Vera Aguilera Puerto <gradientvera@outlook.com>
2022-04-24 00:59:38 +10:00
mirrorcult
e85bdc2d87 More blood tweaks (#6811) 2022-02-20 17:18:24 -07:00
Ygg01
6f36f5b60d Replace old Overflow algorithm (#6280)
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2022-02-15 13:22:26 +11:00
Willhelm53
8d29047a3a Puddle Evaporation Fix (#6584) 2022-02-10 14:07:21 -07:00
Willhelm53
4d3a381962 Mopping Puddle Dilution and Wet Floor Sparkles (#6273) 2022-02-04 19:26:11 -07:00
Leon Friedrich
21480c716a Correct anchor events (#6140) 2022-01-12 18:49:28 +01:00