SimpleStation14
2bf744ddf6
Mirror: Landmine stepoff ( #358 )
...
## Mirror of PR #22962 : [Landmine
stepoff](https://github.com/space-wizards/space-station-14/pull/22962 )
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4 "
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards )/[space-station-14](https://github.com/space-wizards/space-station-14 )
###### `54dd273f660d6d8d523d0771bb8d8437373b082e`
PR opened by <img
src="https://avatars.githubusercontent.com/u/59531932?v=4 "
width="16"/><a href="https://github.com/YuriyKiss "> YuriyKiss</a> at
2023-12-25 12:38:55 UTC
---
PR changed 13 files with 95 additions and 47 deletions.
The PR had the following labels:
- Status: Awaiting Changes
---
<details open="true"><summary><h1>Original Body</h1></summary>
> ## About the PR
> Landmine will explode when player steps off it. Landmine will make a
sound effect when player steps on it
> Close #21658 (Issue has some other suggestions, turn them into
separate issues if relevant)
>
> Requires https://github.com/space-wizards/RobustToolbox/pull/4883
>
> ## Why / Balance
> IRL some landmines will only trigger after you release the pressure
put on them.
>
> ## Technical details
> There are two landmine modes now, one will make landmine trigger
immediately after player steps on them another one will only trigger
after player steps off the landmine (this is the default now).
>
> ## Media
> Landmine stepoff in action:
>
>
https://github.com/space-wizards/space-station-14/assets/59531932/6e884619-7217-4301-bd78-6e843e0d78f1
>
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> ## Breaking changes
>
>
> **Changelog**
> - tweak: landmines will trigger after you step off them
> - add: landmine trigger sound
>
</details>
Signed-off-by: VMSolidus <evilexecutive@gmail.com >
Co-authored-by: SimpleStation14 <Unknown>
Co-authored-by: VMSolidus <evilexecutive@gmail.com >
2024-06-17 11:12:29 +01:00
SimpleStation14
cd0be961a1
Mirror: Thrown soap/banana/(etc?) will fail to slip until it lands ( #280 )
...
## Mirror of PR #24494 : [Thrown soap/banana/(etc?) will fail to slip
until it
lands](https://github.com/space-wizards/space-station-14/pull/24494 )
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4 "
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards )/[space-station-14](https://github.com/space-wizards/space-station-14 )
###### `e061cb3f8c9dc8ddc26624ead2086dfb41465aae`
PR opened by <img
src="https://avatars.githubusercontent.com/u/35878406?v=4 "
width="16"/><a href="https://github.com/Errant-4 "> Errant-4</a> at
2024-01-25 00:04:36 UTC
---
PR changed 1 files with 21 additions and 1 deletions.
The PR had the following labels:
- Status: Awaiting Changes
---
<details open="true"><summary><h1>Original Body</h1></summary>
> ## About the PR
> Thrown objects can no longer slip until they have landed. For a
succesful slip, the attacker must now calculate how to throw the soap in
front of/on the target. If the target is chasing and very close, it
might be more effective to drop the soap/banana rather than throw it,
but then this choice is another decision that must be quickly made to
carry out the slip (also you can mess that up and slip yourself)
>
> A "MISS" popup is displayed mostly just to communicate that this was
not a glitch until players get used to the idea. This popup can be
removed later if we don't want it
>
> I tested what I could think of, but might have missed something, more
eyes would be good on this one
>
> fixes #18027
>
> ## Why / Balance
> Slips are too easy for how annoying (or potentially lethal) they are.
Currently, slip throws are heavily slanted to succeed at short range,
where they will nearly always hit. As the range increases, it becomes
more and more possible to dodge. But it's basically impossible to _fail_
the attack, the question is, will the target be able to anticipate and
slow down to dodge it. This change is intended to make thrown slips,
especially at short range, difficult for the attacker too, not just the
target.
>
> If the argument for the current state is that the target should git
gud, why should that not also apply to the attacker?
>
>
> (Also if we want to talk about what's "realistic", it also makes very
little sense to yeet a banana peel at someone and have them fall over
from that, unless one tacitly agrees that the attack automatically
always hits right under their feet (yet keeps flying anyway) )
>
> ## Media
>
>
https://github.com/space-wizards/space-station-14/assets/35878406/9e548b2d-ab99-4cbf-98b8-9ecd7cd14711
>
> - [X] I have added screenshots/videos to this PR showcasing its
changes ingame, **or** this PR does not require an ingame showcase
>
> **Changelog**
>
> Make sure to take this Changelog template out of the comment block in
order for it to show up.
> 🆑 Errant
> - tweak: Thrown objects can no longer slip while they are still in
flight.
>
</details>
Co-authored-by: SimpleStation14 <Unknown>
2024-05-11 23:44:08 -04:00
Arendian
d6cb163db3
Fix sliding bug ( #24846 )
...
* Fix slip bug
* debug assert
* count
* DebugAssert
(cherry picked from commit 9e484c4b61352a81bb84e2e1e9e030d13ff1464a)
2024-02-08 12:32:21 +01:00
Arendian
b98e16ff53
Spacelube slide ( #24801 )
...
* Space lube now makes you slide
* review
* oh lord he slippin
---------
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com >
(cherry picked from commit 4f3b8d740cecfb736b018fd78a2be71f5397644d)
2024-02-08 12:17:49 +01:00
metalgearsloth
b1ee2d48ff
Unrevert audio ( #21330 )
...
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com >
2023-12-02 20:16:36 +01:00
Debug
fd2cc8570d
Sync master up to 1/10 ( #74 )
...
* Automatic changelog update
* Make NPC names proper nouns & fix some genders (#20534 )
* Proper names & genders
* Uppercase proper names
* Make Smile female
* fix bingus wrinkly head (#20531 )
* rouny meat and steak (#20526 )
* lost friendship flavor
* add rouny steak
* rouny special meat
* rouny meat textures
---------
Co-authored-by: deltanedas <@deltanedas:kde.org>
* Automatic changelog update
* Wearable Wet Floor Sign and 'Janitorial Suicide Vest' (#20311 )
* Explosive wet floor sign & janitorial suicide vest
* fix attributions
* Remove name & desc from explosive wet floor sign
* Make wet floor sign chameleonable
* Automatic changelog update
* Minor slippery stuff (#20535 )
* Update submodule to 162.2.0 (#20570 )
* Predicted armor (#20560 )
* clean up some lines in smile the slime prototype (#20552 )
* Revert "Use full file path for temp replays (#19002 )" (#20545 )
* Add EyesGlasses into ClothesMate (#20523 )
* Automatic changelog update
* Fix Punpun crew monitor sensor (#20484 )
* Automatic changelog update
* EasyPry airlocks for arrivals. Now also prying refactor I guess (#19394 )
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com >
* Automatic changelog update
* Make arcades hackable again (#20555 )
* Automatic changelog update
* Health alert tweaks (#20557 )
* Automatic changelog update
* Add active and ended game rule components, generic TryRoundStartAttempt and minPlayers field (#20564 )
* Improve active game rule querying, add generic try round start attempt method, move minPlayers to GameRuleComponent
* Nukeops todo and cleanup
* Remove Active field
* Add EndedGameRuleComponent
* bartender suit (#20521 )
* give me a drink bartender
* guh
* aARG
* Necropolis and mine walls (#20578 )
* Automatic changelog update
* archaic accent tweaks (#20567 )
* Automatic changelog update
* Add confirmation to kick and respawn in the admin player actions panel (#20542 )
* Remove windows-latest CI runs, remove unused build-test-release.yml (#20540 )
* Change .editorconfig to keep existing attribute arrangement (#20538 )
* Automatic changelog update
* Catch replay start and end errors on round restarts (#20565 )
* Update trivial components to use auto comp states (#20539 )
* Fix role unbans not applying in real time (#20547 )
* Disable AHelp buttons when no player is selected, update button styling (#20568 )
* Automatic changelog update
* Added a toggle fullscreen button (default F11) (#20272 )
* Added a toggle fullscreen button (default F11)
* Removed un-needed comments
* Review Requested Changes
* Fixed Acidental Spacing Change
* bwoink, removed extraneous code
* nothing, litterally
* Automatic changelog update
* Fix not networking markings (#20588 )
* Automatic changelog update
* Update RobustToolbox to v162.2.1 (#20590 )
* Automatic changelog update
* Glorfcode (force say on damage/stun/crit) (#20562 )
* Automatic changelog update
* Fix AHelp progressively showing more AHelp panels (#20591 )
* Automatic changelog update
* caninsert entitystorage tweaks (#20589 )
* Automatic changelog update
* Fix mapping actions crashing on load (#20592 )
* Fix loading a map with a ThirstComponent crashing the game (#20594 )
* Fix electrocution displaying real name of disguised players (#20603 )
* Organ fixes (#20488 )
* Automatic changelog update
* Kettle medical rework (#20435 )
* Initial try at medical rework for kettle
* Re-add decal decorations to Kettle's medical
* Add more lockers to kettle's med
* Actually upload kettle's map, not its proto
* Automatic changelog update
* Added blocked visuals to volumetric pump (#20610 )
* Automatic changelog update
* Move TimedDespawn to engine (#20515 )
* Update submodule to 163.0.0 (#20616 )
* Remove v0.1 version number from local main menu screen (#20617 )
* Remove cloneData parameter from AutoNetworkedField (#20596 )
* Update submodule to 164.0.0 (#20618 )
* fix cognizine ghost role (#20632 )
Co-authored-by: deltanedas <@deltanedas:kde.org>
* Automatic changelog update
* Move ID layer one pixel to correct alignment (#20630 )
* Update nukie hardsuit descriptions (#20529 )
* Make holofans destructable (#20445 )
* Automatic changelog update
* bowl is open (#20453 )
Co-authored-by: deltanedas <@deltanedas:kde.org>
* Add TestPair.WaitCommand() (#20615 )
* Rename ThreatPrototype and mark fields as required (#20611 )
* Adjust hard bomb shape (#20608 )
* dragon refactor, objectives and use GenericAntag (#20201 )
Co-authored-by: deltanedas <@deltanedas:kde.org>
* Automatic changelog update
* Added generic empty liquids tank (#20563 )
* Move view variables verb to the top of the list with no category and localize it (#20546 )
* saltern update (#20325 )
Co-authored-by: deltanedas <@deltanedas:kde.org>
* Fix followers leaking (#20643 )
* Add Winter Boots (#20622 )
* add
* fix prototype
* Add QM mantle (#20621 )
* add
* fix prototype
* Automatic changelog update
* Slime mobs breathe nitrogen and resprite their organs (#20577 )
* Slimes breathe nitrogen and resprite their organs
* ups
* mmm
* Automatic changelog update
* Fix the new lizard horn's consistency + issue (#20620 )
* fix
* add
* Revert "add"
This reverts commit a054a3204a8f185a94ceb80b1bd3bc9f30423711.
* Add RandomHumanoidAppearance component to for space ninjas (#20605 )
* Automatic changelog update
* Space cat breathes space (#20550 )
* Space cat breathes space
Made Space Cat lungs ROBUST
* Made Space Cat's lungs ROBUST 2.0
* Automatic changelog update
* Wide anomaly locator (#20581 )
* Add files via upload
* Add files via upload
* Add files via upload
* Add files via upload
* add textures
* fix encoding
* fix 2
* Automatic changelog update
* Fixed Telescopic Shield Lighting (#20650 )
* Fixed Telescopic Shield Lighting Bug fix #20199
* no need for these at all
---------
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com >
* Automatic changelog update
* Add a special hardsuit for nukie medic (#20471 )
* Automatic changelog update
* Carry over other mutations when doing species mutation (#20551 )
* Automatic changelog update
* Add Spanish accent to poncho and sombrero (#20377 )
---------
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com >
Co-authored-by: Psychpsyo <60073468+Psychpsyo@users.noreply.github.com >
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com >
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com >
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com >
Co-authored-by: ravage <142820619+ravage123321@users.noreply.github.com >
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com >
Co-authored-by: LEVELcat <68501903+LEVELcat@users.noreply.github.com >
Co-authored-by: Repo <47093363+Titian3@users.noreply.github.com >
Co-authored-by: nikthechampiongr <32041239+nikthechampiongr@users.noreply.github.com >
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com >
Co-authored-by: Doru991 <75124791+Doru991@users.noreply.github.com >
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com >
Co-authored-by: Skarletto <122584947+Skarletto@users.noreply.github.com >
Co-authored-by: NULL882 <104377798+NULL882@users.noreply.github.com >
Co-authored-by: lunarcomets <140772713+lunarcomets@users.noreply.github.com >
Co-authored-by: Miro Kavaliou <miraslauk@gmail.com >
Co-authored-by: Kara <lunarautomaton6@gmail.com >
Co-authored-by: Kacper Urbańczyk <kacperjaroslawurbanczyk@gmail.com >
Co-authored-by: TsjipTsjip <19798667+TsjipTsjip@users.noreply.github.com >
Co-authored-by: daerSeebaer <61566539+daerSeebaer@users.noreply.github.com >
Co-authored-by: Fluffiest Floofers <thebluewulf@gmail.com >
Co-authored-by: Flareguy <78941145+Flareguy@users.noreply.github.com >
Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com >
Co-authored-by: Kevin Zheng <kevinz5000@gmail.com >
Co-authored-by: drteaspoon420 <87363733+drteaspoon420@users.noreply.github.com >
Co-authored-by: Ubaser <134914314+UbaserB@users.noreply.github.com >
Co-authored-by: Nim <128169402+Nimfar11@users.noreply.github.com >
Co-authored-by: Kacper Urbańczyk <mikrel071204@gmail.com >
Co-authored-by: Tox Cruize <141375638+TexCruize@users.noreply.github.com >
Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com >
Co-authored-by: Michael Cu <43478115+michaelcu@users.noreply.github.com >
2023-10-03 14:15:46 -05:00
Leon Friedrich
8af149e61c
Add climb & slip tests ( #15459 )
2023-04-16 23:07:03 -07:00
Slava0135
620c40e087
Add explosive banana peel 2 ( #14491 )
2023-03-23 11:54:14 -04:00
metalgearsloth
bf79d76666
Content update for ECS physics ( #13291 )
2023-01-15 15:38:59 +11:00
Ygg01
75ea093d78
Fluid spread refactor ( #11908 )
...
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com >
Fix undefined
2022-11-15 22:30:59 +11:00
Leon Friedrich
92e92dceb0
Unrevert #10934
2022-10-25 11:06:00 +11:00
Emisse
80fd37041f
Revert "Fix unintentional inventory relayed event handling " ( #12182 )
2022-10-24 17:06:04 +02:00
Leon Friedrich
145471be2d
Fix unintentional inventory relayed event handling ( #10934 )
...
* Add InventoryRelayedEvent<TEvent>
* implement relays
* typos
* a
2022-10-24 01:04:49 -07:00
metalgearsloth
1782eb6ad7
Fix even more warnings ( #11968 )
...
Also more instances of someone using TryComp instead of HasComp
Co-authored-by: metalgearsloth <metalgearsloth@gmail.com >
2022-10-16 08:49:22 -07:00
metalgearsloth
78a4ab6eb2
Update for collision events by-ref ( #10933 )
2022-09-14 17:26:26 +10:00
metalgearsloth
12e1a961d6
Reduce knocked down players tile friction ( #11035 )
2022-09-10 23:49:10 -07:00
metalgearsloth
590a6ce969
Slipping, now with 20% more ecs ( #4310 )
...
* Slipping, now with 20% more ecs
* vereview
2021-07-21 22:13:58 +10:00
Visne
b7dc3c81ae
Remove redundant #nullable enable ( #4275 )
2021-07-16 17:37:09 -07:00
DrSmugleaf
ff1a2d97ea
Re-organize all projects ( #4166 )
2021-06-09 22:19:39 +02:00