From 6d36a63f6c9daedf735902ecb305eb6cdcea411a Mon Sep 17 00:00:00 2001 From: slarticodefast <161409025+slarticodefast@users.noreply.github.com> Date: Fri, 19 Jul 2024 12:42:58 +0300 Subject: [PATCH] Fix EmbeddableProjectileComponent and ThrowingAngleComponent interaction (#30112) * fix embeddable offset with throwing angle * number (cherry picked from commit eaace152aeb30622849826572f2aab62f5575d3a) --- .../Projectiles/SharedProjectileSystem.cs | 5 ++++- .../Entities/Objects/Weapons/Melee/spear.yml | 18 +++++++++--------- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/Content.Shared/Projectiles/SharedProjectileSystem.cs b/Content.Shared/Projectiles/SharedProjectileSystem.cs index e77e8047af..8559294e41 100644 --- a/Content.Shared/Projectiles/SharedProjectileSystem.cs +++ b/Content.Shared/Projectiles/SharedProjectileSystem.cs @@ -209,7 +209,10 @@ public abstract partial class SharedProjectileSystem : EntitySystem if (component.Offset != Vector2.Zero) { - _transform.SetLocalPosition(uid, xform.LocalPosition + xform.LocalRotation.RotateVec(component.Offset), + var rotation = xform.LocalRotation; + if (TryComp(uid, out var throwingAngleComp)) + rotation += throwingAngleComp.Angle; + _transform.SetLocalPosition(uid, xform.LocalPosition + rotation.RotateVec(component.Offset), xform); } diff --git a/Resources/Prototypes/Entities/Objects/Weapons/Melee/spear.yml b/Resources/Prototypes/Entities/Objects/Weapons/Melee/spear.yml index 71d53bdd1c..6989d81647 100644 --- a/Resources/Prototypes/Entities/Objects/Weapons/Melee/spear.yml +++ b/Resources/Prototypes/Entities/Objects/Weapons/Melee/spear.yml @@ -5,7 +5,7 @@ description: Definition of a Classic. Keeping murder affordable since 200,000 BCE. components: - type: EmbeddableProjectile - offset: 0.15,0.15 + offset: -0.15,0.0 - type: EmbedPassiveDamage - type: ThrowingAngle angle: 225 @@ -18,10 +18,10 @@ fix1: shape: !type:PolygonShape vertices: - - -0.40,-0.30 - - -0.30,-0.40 - - 0.40,0.30 - - 0.30,0.40 + - -0.40,-0.30 + - -0.30,-0.40 + - 0.40,0.30 + - 0.30,0.40 density: 20 mask: - ItemMask @@ -220,10 +220,10 @@ fix1: shape: !type:PolygonShape vertices: - - -0.40,-0.30 - - -0.30,-0.40 - - 0.40,0.30 - - 0.30,0.40 + - -0.40,-0.30 + - -0.30,-0.40 + - 0.40,0.30 + - 0.30,0.40 density: 20 mask: - ItemMask