From 5da171ebcd203e5b953f4e7d573397902929d6bb Mon Sep 17 00:00:00 2001 From: Remuchi <72476615+Remuchi@users.noreply.github.com> Date: Sun, 14 Sep 2025 20:05:01 +0700 Subject: [PATCH] [Fix] Don't Ping On Empty Changelog (#840) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Update actions_changelogs_since_last_run.py * style✨ * i forgor * Update actions_changelogs_since_last_run.py --- Tools/actions_changelogs_since_last_run.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Tools/actions_changelogs_since_last_run.py b/Tools/actions_changelogs_since_last_run.py index e45927d3b1..e89ce56640 100755 --- a/Tools/actions_changelogs_since_last_run.py +++ b/Tools/actions_changelogs_since_last_run.py @@ -18,7 +18,7 @@ GITHUB_RUN = os.environ["GITHUB_RUN_ID"] GITHUB_TOKEN = os.environ["GITHUB_TOKEN"] CHANGELOG_DIR = os.environ["CHANGELOG_DIR"] CHANGELOG_WEBHOOK = os.environ["CHANGELOG_WEBHOOK"] -ROLES_TO_PING = os.environ["ROLES_TO_PING"] +ROLES_TO_PING = os.environ["ROLES_TO_PING"] # https://discord.com/developers/docs/resources/webhook DISCORD_SPLIT_LIMIT = 2000 @@ -129,9 +129,6 @@ def send_to_discord(entries: Iterable[ChangelogEntry]) -> None: if not CHANGELOG_WEBHOOK: print(f"No discord webhook URL found, skipping discord send") return - - roles_msg = ', '.join(map(lambda id: f'<@&{id}>', ROLES_TO_PING.replace(" ","").split(','))) - send_discord(roles_msg) message_content = io.StringIO() # We need to manually split messages to avoid discord's character limit @@ -173,6 +170,8 @@ def send_to_discord(entries: Iterable[ChangelogEntry]) -> None: message_text = message_content.getvalue() if len(message_text) > 0: print("Sending final changelog to discord") + roles_msg = ', '.join(map(lambda id: f'<@&{id}>', ROLES_TO_PING.replace(" ","").split(','))) + send_discord(roles_msg) send_discord(message_text)